Re: [VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-14 Thread Gary Gregory
On Sat, Oct 14, 2017 at 1:28 PM, Oliver Heger wrote: > Hi Benedikt, > > it seems that the binary artifact does not contain the real classes, but > classes manipulated by Cobertura. commons-io-2.6.jar contains a > cobertura.properties file, and opening a class in a

Re: [LANG] Add module-info.java?

2017-10-14 Thread Ralph Goers
I need to point out that even after removing that there would be a lot of stuff in log4j-core that doesn’t work in Android. Ralph > On Oct 14, 2017, at 12:02 PM, Gary Gregory wrote: > > I am wondering if this is a little too early. A lot of tooling our there > does not

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Gary Gregory
Running with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T13:39:06-06:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version: 1.8.0_144, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_144\jre Default locale: en_US, platform encoding:

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Gary Gregory
Darn, I meant TestNG. Gary On Sat, Oct 14, 2017 at 12:58 PM, Gary Gregory wrote: > How does it compare to RelaxNG? > > G > > On Sat, Oct 14, 2017 at 12:49 PM, Matt Sicker wrote: > >> AssertJ is an assertion library and works with JUnit or whatever

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Gary Gregory
How does it compare to RelaxNG? G On Sat, Oct 14, 2017 at 12:49 PM, Matt Sicker wrote: > AssertJ is an assertion library and works with JUnit or whatever testing > framework you want. Essentially, it's a replacement for Hamcrest + > org.junit.Assert. > > On 14 October 2017 at

Re: [VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-14 Thread Gary Gregory
+1 ASC, MD5, SHA1 all OK. Running 'mvn clean site' with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T13:39:06-06:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version: 1.8.0_144, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_144\jre

Re: [LANG] Add module-info.java?

2017-10-14 Thread Gary Gregory
I am wondering if this is a little too early. A lot of tooling our there does not play well with Java 9 class files. The last time I tried to use Log4j 2 (which contains Java 9 classes files in the right multi-jar spot) with an Android app, the Android tooling threw up all over itself because it

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Bruno P. Kinoshita
Hi, I may be doing something wrong, but the site generation with `mvn clean site` appears to be failing on $ git log -n 1 commit 01b06d5ef5c5ac3bd651bedcfec7433231cea371 Author: Stefan Bodewig Date: Sat Oct 14 15:17:09 2017 +0200 prepare RC1 of Commons Compress 1.15

[GitHub] commons-collections issue #32: Update testcase

2017-10-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/32 Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [2/2] [lang] remove unused bcel test dependency

2017-10-14 Thread Benedikt Ritter
Nice one! schrieb am Sa. 14. Okt. 2017 um 15:27: > remove unused bcel test dependency > > > Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo > Commit: > http://git-wip-us.apache.org/repos/asf/commons-lang/commit/66226ec1 > Tree:

[GitHub] commons-collections pull request #32: Update testcase

2017-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/32 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

[GitHub] commons-collections pull request #32: Update testcase

2017-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/32 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Pascal Schumacher
Any time. :-) Migrating is not hard, as there are scripts to do most of the work, see: https://joel-costigliola.github.io/assertj/assertj-core-converting-junit-assertions-to-assertj.html Am 14.10.2017 um 19:06 schrieb Benedikt Ritter: About time we migrate to AssertJ. :-) Gary Gregory

Re: [LANG] Add module-info.java?

2017-10-14 Thread Gary Gregory
Oh sure, but each roadblock matters... breaking up our core jar would help too I am sure. Gary On Oct 14, 2017 16:05, "Ralph Goers" wrote: > I need to point out that even after removing that there would be a lot of > stuff in log4j-core that doesn’t work in

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread vspkponse
Github user vspkponse commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Looking forwarding :) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Gary Gregory
I have no interest in switching from JUnit, especially with JUnit 5 around the corner. Gary On Sat, Oct 14, 2017 at 12:25 PM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Any time. :-) > > Migrating is not hard, as there are scripts to do most of the work, see: > >

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Matt Sicker
AssertJ is an assertion library and works with JUnit or whatever testing framework you want. Essentially, it's a replacement for Hamcrest + org.junit.Assert. On 14 October 2017 at 13:27, Gary Gregory wrote: > I have no interest in switching from JUnit, especially with

Re: [LANG] Add module-info.java?

2017-10-14 Thread Bruno P. Kinoshita
Can't cast an opinion on that as I haven't read much about modules yet. But a major version was mentioned in other comments. I remember an issue in lang [1] for Java 9 modules around circuit breakers and the java.desktop (or something named like that) module. I have prepared a WIP alternative

[GitHub] commons-collections pull request #32: Update testcase

2017-10-14 Thread vamsi-kavuri
GitHub user vamsi-kavuri opened a pull request: https://github.com/apache/commons-collections/pull/32 Update testcase Updating test cases based on the comments given in #29 You can merge this pull request into a Git repository by running: $ git pull

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Benedikt Ritter
About time we migrate to AssertJ. :-) Gary Gregory schrieb am Sa. 14. Okt. 2017 um 18:55: > Thank you for doing that! That was driving me nuts! > > Gary > > On Oct 14, 2017 10:53, wrote: > > > Repository: commons-collections > > Updated

Re: [LANG] Add module-info.java?

2017-10-14 Thread Romain Manni-Bucau
Hi guys, A side note but wonder if you noticed jar scanners were - indeed - not supporting mjar and just filtering classes by extension leading to class not found with mjar? For instance log4j2 broke meecrowave shade setup which was working pre-mjar time - no impact on the not shade mode cause

Re: [VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-14 Thread Bruno P. Kinoshita
Hi, [ X ] +1 Release these artifacts Building from tag $ git log -n 1 commit a219081780bb1714876ef3e1109283b96f3b007b Author: Benedikt Ritter Date: Sat Sep 30 16:33:46 2017 +0200 Update version numbers for Commons IO release 2.6 With Apache Maven 3.3.9

Re: [VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-14 Thread Oliver Heger
Hi Benedikt, it seems that the binary artifact does not contain the real classes, but classes manipulated by Cobertura. commons-io-2.6.jar contains a cobertura.properties file, and opening a class in a decompiler shows some Cobertura-specific initialization code. Can you please double-check?

[GitHub] commons-collections issue #32: Update testcase

2017-10-14 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/32 [![Coverage Status](https://coveralls.io/builds/13717831/badge)](https://coveralls.io/builds/13717831) Coverage decreased (-0.008%) to 86.616% when pulling

Re: [LANG] Add module-info.java?

2017-10-14 Thread Gary Gregory
Oh sure, but each roadblock matters... breaking up our core jar would help too I am sure. Gary On Oct 14, 2017 16:05, "Ralph Goers" wrote: > I need to point out that even after removing that there would be a lot of > stuff in log4j-core that doesn’t work in

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

2017-10-14 Thread Gary Gregory
Thank you for doing that! That was driving me nuts! Gary On Oct 14, 2017 10:53, wrote: > Repository: commons-collections > Updated Branches: > refs/heads/master 641aa1c66 -> b9522976f > > > MapUtilsTest: fix order of expected and actual parameter in assertions >

Re: [2/2] [lang] remove unused bcel test dependency

2017-10-14 Thread Gary Gregory
boom! :-) too bad Checkstyle does not do that for you! Gary On Oct 14, 2017 10:54, "Benedikt Ritter" wrote: > Nice one! > > schrieb am Sa. 14. Okt. 2017 um 15:27: > >> remove unused bcel test dependency >> >> >> Project:

Re: [LANG] Add module-info.java?

2017-10-14 Thread Matt Sicker
Which is mainly because the version of Java in Android is intentionally lacking about half of the standard library. Perhaps this will improve in the future now that they're adopting OpenJDK, though. On 14 October 2017 at 17:04, Ralph Goers wrote: > I need to point

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Stefan Bodewig
On 2017-10-15, Bruno P. Kinoshita wrote: > I may be doing something wrong, but the site generation with `mvn > clean site` appears to be failing [snip] > With: > (...) > [INFO] Loading execution data file > /home/kinow/Development/java/apache/commons-compress/target/jacoco.exec > [INFO]

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Stefan Bodewig
On 2017-10-15, Bruno P. Kinoshita wrote: > Oh, don't know how I didn't see the building file. Will make a mental > note to look for it the next time :-) thank you. No, thank you. I've made a mental note to include site building instructions with the vote thread next time :-) Stefan

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Bruno P. Kinoshita
Sent previously e-mail with correct +1 vote, but while pasting my environment settings I accidentally hit send. Just to conclude. Also building OK with IBM JDK 1.8 and Oracle JDK 1.7, both on Ubuntu LTS. Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)

[GitHub] commons-imaging pull request #32: add test for DataReaderStripsTest::applyPr...

2017-10-14 Thread testingsavvy
GitHub user testingsavvy opened a pull request: https://github.com/apache/commons-imaging/pull/32 add test for DataReaderStripsTest::applyPredictor This PR adds a new test for `DataReaderStripsTest::applyPredictor`, so that it can be tested in isolation. You can merge this pull

Re: [VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Bruno P. Kinoshita
Oh, don't know how I didn't see the building file. Will make a mental note to look for it the next time :-) thank you. [ X ] +1 Release these artifacts Building OK on commit 01b06d5ef5c5ac3bd651bedcfec7433231cea371 Author: Stefan Bodewig Date: Sat Oct 14 15:17:09 2017

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread vspkponse
Github user vspkponse commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Check failed? I have test it in IntelliJ IDEA and my web project is ok where is the mistake? --- - To

Re: [COLLECTIONS] Test failures on Windows

2017-10-14 Thread Bruno P. Kinoshita
Build passing OK in the same environment I used for COLLECTIONS-661, with a Windows 10, JDK 1.8, and locale set to en_US. Changed the whole operating system settings and locale to pt_BR (where commas/dots are too reversed for thousands, decimals), confirmed in mvn -v that it changed, then

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

2017-10-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 Sorry about that. :( But the correct parameter order part of you pull request is still relevant. It would be nice if you could create a new rebased pull request for

Re: [COLLECTIONS] Test failures on Windows

2017-10-14 Thread Pascal Schumacher
Thanks! Works for me. Am 14.10.2017 um 03:02 schrieb Gary Gregory: OK, I should have that fixed up in the tests. Please give it a go. Gary On Thu, Oct 12, 2017 at 2:23 AM, Pascal Schumacher

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 A possible solution for this problem would be to use reflection instead. --- - To unsubscribe, e-mail:

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread vspkponse
Github user vspkponse commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Will you update another new version based on java8/9 and add some new functions some day? --- - To unsubscribe, e-mail:

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-14 Thread Pascal Schumacher
O.k. I took a look. The cli-jar only add the single class "cli.Digest" mentioned below. It includes other classes from the main jar, probably classes used directly or indirectly by "cli.Digest". Am 14.10.2017 um 00:32 schrieb Gary Gregory: There is more than one class IIRC, still not worth

[GitHub] commons-dbutils pull request #4: Now LocalDate,LocalDateTime,Instant are ava...

2017-10-14 Thread vspkponse
GitHub user vspkponse opened a pull request: https://github.com/apache/commons-dbutils/pull/4 Now LocalDate,LocalDateTime,Instant are available. Original was the decompiled version from v1.7 .class .I fixed some of the differences. Tell me or edit it if the github .java original

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Thanks for the pull request. DBUtils currently still requires only java 6, but you are using classes which were introduced in java 8. Therefore the builds on java 6/7 fail

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread vspkponse
Github user vspkponse commented on the issue: https://github.com/apache/commons-dbutils/pull/4 Ok --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-dbutils/pull/4 I'm sure we will, but as far as I know there is no concrete plan when that will happen. --- - To unsubscribe,

Re: [LANG] Add module-info.java?

2017-10-14 Thread Stephen Colebourne
On 14 October 2017 at 14:05, Rob Tompkins wrote: >> On Oct 14, 2017, at 8:43 AM, Benedikt Ritter wrote: > Feels like a change that would warrant a major version change, but that would > have us maintaining another major version branch. No need for a

Re: [COLLECTIONS] Test failures on Windows

2017-10-14 Thread Gary Gregory
Thank you for being the RM! Looking forward to the RC. Gary On Oct 14, 2017 06:09, "Benedikt Ritter" wrote: > Okay, so we’re ready to push out a release candidate? Great! I’ll see when > I find the time to do that :-) > > Awesome team work! > > Benedikt > > > Am 14.10.2017

[GitHub] commons-io pull request #46: IO-507: Rename ByteOrderUtils class to ByteOrde...

2017-10-14 Thread britter
Github user britter closed the pull request at: https://github.com/apache/commons-io/pull/46 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #43: Make code style of hasBOM() consistent with get...

2017-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/43 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LOGGING] Release with Java 9 Module support

2017-10-14 Thread Benedikt Ritter
> Am 01.10.2017 um 21:27 schrieb Stephen Colebourne : > > On 1 October 2017 at 11:34, Stefan Bodewig wrote: >> - only add the automatic module name to commons-logging and release api >> and adapter as they are. > > Exactly. This is the right approach.

Re: [jcs] No access to assign an issue in JIRA (JCS-184)

2017-10-14 Thread Thomas Vandahl
On 14.10.17 01:22, Gary Gregory wrote: > Well, crud, when I look at the list of JIRA projects I can administer, I do > not see Commons JCS. > > Anyone else? I can and I fixed it. Bye, Thomas - To unsubscribe, e-mail:

Re: [LANG] Add module-info.java?

2017-10-14 Thread Pascal Schumacher
Am 14.10.2017 um 14:43 schrieb Benedikt Ritter: Hi, Stephen Colebourne has raised a PR on GitHub to add a module-info.java file to Commons Lang [1]. The build is configured in a way, that the resulting jar will also work on Java 7 and 8. Since module-info is a Java 9 feature, the build will

[GitHub] commons-dbutils issue #4: Now LocalDate,LocalDateTime,Instant are available.

2017-10-14 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-dbutils/pull/4 We could release what we have now and the at least update to Java 7 if not 8. --- - To unsubscribe, e-mail:

Re: [COLLECTIONS] Test failures on Windows

2017-10-14 Thread Benedikt Ritter
Okay, so we’re ready to push out a release candidate? Great! I’ll see when I find the time to do that :-) Awesome team work! Benedikt > Am 14.10.2017 um 12:25 schrieb Bruno P. Kinoshita > : > > Build passing OK in the same environment I used for

[VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-14 Thread Benedikt Ritter
Hello, we have fixed quite a few bugs and added some nice new features since Apache Commons IO 2.5 was released, so I would like to release Apache Commons IO 2.6 based on RC2. The changes since RC1 are: - Worked on the design of the ByteOrderParser class - Fixed IO-546 - Fixed IO-553 Commons

[LANG] Add module-info.java?

2017-10-14 Thread Benedikt Ritter
Hi, Stephen Colebourne has raised a PR on GitHub to add a module-info.java file to Commons Lang [1]. The build is configured in a way, that the resulting jar will also work on Java 7 and 8. Since module-info is a Java 9 feature, the build will only work on Java 9. I’d like to hear opinions on

Re: [LANG] Add module-info.java?

2017-10-14 Thread Rob Tompkins
> On Oct 14, 2017, at 8:43 AM, Benedikt Ritter wrote: > > Hi, > > Stephen Colebourne has raised a PR on GitHub to add a module-info.java file > to Commons Lang [1]. The build is configured in a way, that the resulting jar > will also work on Java 7 and 8. Since

[VOTE] Release Compress 1.15 based on RC1

2017-10-14 Thread Stefan Bodewig
Hi all this is mostly a bugfix release but it was about time for a new release. Compress 1.15 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/ (svn revision 22476) The tag is here: