Re: svn commit: r1826005 - in /commons/proper/commons-parent/trunk: RELEASE-NOTES.txt src/changes/changes.xml

2018-03-06 Thread Rob Tompkins
> On Mar 6, 2018, at 2:24 PM, Gary Gregory wrote: > > Thanks Rob! > No worries. :-) > Gary > > On Tue, Mar 6, 2018, 10:32 wrote: > >> Author: chtompki >> Date: Tue Mar 6 17:32:18 2018 >> New Revision: 1826005 >> >> URL:

[LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
Hello all, This is a [LAZY][VOTE] for releasing Apache Commons Parent 44 (from RC2). Tag name: commons-parent-44-RC2 Tag URL: https://svn.apache.org/repos/asf/commons/proper/commons-parent/tags/commons-parent-44-RC2/ Commit ID the tag points at: 1826033 Site Zip:

Re: [VFS] FILE_OR_FOLDER breaking tests

2018-03-06 Thread Bernd Eckenfels
Those tests should be behind a capability for sure, but I thought they are already (as the resource and URL fikesystem already passes the tests). What filesystem do you have in mind and what are examples of failing testcases? I think I had fixed a few for WebDav back in the days. Gruss Bernd

Re: svn commit: r1826005 - in /commons/proper/commons-parent/trunk: RELEASE-NOTES.txt src/changes/changes.xml

2018-03-06 Thread Gary Gregory
Thanks Rob! Gary On Tue, Mar 6, 2018, 10:32 wrote: > Author: chtompki > Date: Tue Mar 6 17:32:18 2018 > New Revision: 1826005 > > URL: http://svn.apache.org/viewvc?rev=1826005=rev > Log: > Updating changes and RELEASE-NOTES.txt > > Modified: >

Re: [VFS] FILE_OR_FOLDER breaking tests

2018-03-06 Thread Otto Fowler
protected void addBaseTests() throws Exception { addTests(ProviderCacheStrategyTests.class); addTests(UriTests.class); addTests(NamingTests.class); // --> file or folder rework addTests(ContentTests.class); // --> file or folder rework addTests(ProviderReadTests.class);

Re: [parent] maven-surefire-plugin 2.21.0

2018-03-06 Thread Rob Tompkins
> On Mar 6, 2018, at 11:40 AM, Gary Gregory wrote: > > On Tue, Mar 6, 2018 at 9:10 AM, Gary Gregory wrote: > >> Let's wait for maven-surefire-plugin 2.21.0 to populate to MC, update >> [parent], before trying another RC... SVP. This should

Re: [io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-06 Thread Gary Gregory
On Tue, Mar 6, 2018 at 4:13 PM, sebb wrote: > On 6 March 2018 at 21:38, Gary Gregory wrote: > > Hi All: > > > > Any objection to adding: > > > > /** > > * Reads n lines from this reader. > > */ > > List > >

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
Hm….looking. At first look thought, that doesn’t look like something that we would want to expect. > On Mar 6, 2018, at 3:50 PM, Gary Gregory wrote: > > Hi Rob, > > Thank you for providing another RC. > > When I run: > > mvn clean verify package > > I get: > >

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
I’ve seen something like this before where your local .m2 repository is making things behave strangely. You could try deleting the commons-parent directory there. Betting you ran an install on 44 earlier when you were committing the surefire changes. -Rob > On Mar 6, 2018, at 4:13 PM, Gary

[io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-06 Thread Gary Gregory
Hi All: Any objection to adding: /** * Reads n lines from this reader. */ List org.apache.commons.io.input.ReversedLinesFileReader.readLine(long lineCount) ? Gary

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
Shouldn't japicmp be configured with oldVersionPattern set to 43? Or disabled for this component, which might make more sense? Gary On Tue, Mar 6, 2018 at 2:34 PM, Gary Gregory wrote: > > > On Tue, Mar 6, 2018 at 2:25 PM, Rob Tompkins wrote: > >>

Re: [io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-06 Thread sebb
On 6 March 2018 at 21:38, Gary Gregory wrote: > Hi All: > > Any objection to adding: > > /** > * Reads n lines from this reader. > */ > List > org.apache.commons.io.input.ReversedLinesFileReader.readLine(long lineCount) > > ? Yes. The name makes it sound like it is

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
Yes, that makes sense to me as well. I’ll get to the next RC in the morning. -Rob > On Mar 6, 2018, at 5:02 PM, Gary Gregory wrote: > > Shouldn't japicmp be configured with oldVersionPattern set to 43? Or > disabled for this component, which might make more sense? > >

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
Review in progress... I would be nice if this worked: md5sum -c commons-parent-44-src.zip.md5 sha1sum -c commons-parent-44-src.zip.sha1 I am using md5sum from Git's MingW64 shell. Gary On Tue, Mar 6, 2018 at 1:14 PM, Rob Tompkins wrote: > Hello all, > > This is a

Re: [io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-06 Thread sebb
On 6 March 2018 at 23:22, Gary Gregory wrote: > On Tue, Mar 6, 2018 at 4:13 PM, sebb wrote: > >> On 6 March 2018 at 21:38, Gary Gregory wrote: >> > Hi All: >> > >> > Any objection to adding: >> > >> > /** >> > * Reads n lines

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
On Tue, Mar 6, 2018 at 2:25 PM, Rob Tompkins wrote: > I’ve seen something like this before where your local .m2 repository is > making things behave strangely. You could try deleting the commons-parent > directory there. Betting you ran an install on 44 earlier when you were

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
Darn. I was hoping that would work. Do you get the same from the tag? > On Mar 6, 2018, at 4:34 PM, Gary Gregory wrote: > >> On Tue, Mar 6, 2018 at 2:25 PM, Rob Tompkins wrote: >> >> I’ve seen something like this before where your local .m2

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
Hi Rob, Thank you for providing another RC. When I run: mvn clean verify package I get: [INFO] Generating "japicmp" report --- japicmp-maven-plugin:0.11.0:cmp-report [debug] No packaging support defined, no filtering [info] Skipping execution because packaging of this module is 'pom'.

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
I downloaded the .zip and ran “mvn clean verify package” successfully with the environment: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T03:58:13-04:00) Maven home: /usr/local/Cellar/maven/3.5.2/libexec Java version: 1.8.0_152, vendor: Oracle Corporation Java home:

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
Using java 1.8.0_162 I get a successful run. Here’s my log: https://gist.github.com/chtompki/c5df28381244da0d2e126d6b5a1353e0 Can you run with -X and put your full log somewhere….I’m curious to look at it. -Rob > On Mar 6,

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
I forgot to mention that I used the src zip as opposed to the tar gz if that matters. Gary On Tue, Mar 6, 2018 at 2:02 PM, Rob Tompkins wrote: > I downloaded the .zip and ran “mvn clean verify package” successfully with > the environment: > > Apache Maven 3.5.2

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Gary Gregory
Yeah, the -X output is 1 MB which is too big for my free pastbin account... I'll email it to you... Gary On Tue, Mar 6, 2018 at 2:08 PM, Rob Tompkins wrote: > Using java 1.8.0_162 I get a successful run. Here’s my log: > >

[CANCEL][LAZY][VOTE] Release Commons Parent 44 based on RC2.

2018-03-06 Thread Rob Tompkins
I’m going to try to sort out Gary’s issue, and stage an RC3 in the morning. Cheers, -Rob > On Mar 6, 2018, at 3:14 PM, Rob Tompkins wrote: > > Hello all, > > This is a [LAZY][VOTE] for releasing Apache Commons Parent 44 (from RC2). > > Tag name: > commons-parent-44-RC2

Re: Prepare commons to JDK 9

2018-03-06 Thread Gary Gregory
Hi All: On a slightly different tack, I think that it is way to early to require Java 9 for ANY Commons components. I see a case for updating all components to at least Java 7, and hopefully 8. What you will likely hear from some quarters are comments of the type "What feature of Java X is

Re: [email] Update from Java 6 to 7

2018-03-06 Thread Gary Gregory
On Fri, Mar 2, 2018 at 9:52 AM, Pascal Schumacher wrote: > +1, otherwise we would have to revert https://github.com/apache/comm > ons-email/commit/2239326be5c2791a23eea07eaed3d81f2e7000cf > > Am 02.03.2018 um 17:45 schrieb Gary Gregory: > >> I propose we update Commons

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-06 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/4 Hello @cdeneux ! Thank you for your PR. Would you mind updating this PR with a unit test? It would be best if the test failed without the changes to the main file.

Prepare commons to JDK 9

2018-03-06 Thread Kamila Molina Orellana
Dear all, As an idea for GSoC that came up in [1], we want to settle some guidelines that other commons projects might follow to make the shift. We came up with some ideas in [2]. I wanted to ask about some experience you have had while moving to JDK 9 in other commons-projects. I wanted to

Re: [io] org.apache.commons.io.input.ReversedLinesFileReader.readLine(long)

2018-03-06 Thread Gary Gregory
On Tue, Mar 6, 2018 at 4:32 PM, sebb wrote: > On 6 March 2018 at 23:22, Gary Gregory wrote: > > On Tue, Mar 6, 2018 at 4:13 PM, sebb wrote: > > > >> On 6 March 2018 at 21:38, Gary Gregory wrote: > >> > Hi All:

[ANNOUNCE] Commons Release Plugin 1.1 Released.

2018-03-06 Thread Rob Tompkins
[This announcement is only going to the dev list.] The Apache Commons Release Plugin team is pleased to announce the release of Apache Commons Release Plugin 1.1. The Apache Commons Release Plugin is a collection of Java based Maven mojos for Apache Commons Release process. These mojos are

Re: [All] GitHub partial update

2018-03-06 Thread Gary Gregory
Yep, INFRA... Gary On Tue, Mar 6, 2018, 07:24 Otto Fowler wrote: > You should open an INFRA ticket > > On March 6, 2018 at 09:12:41, Gilles (gil...@harfang.homelinux.org) wrote: > > > Hi. > > > > It seems there are glitches with the mirroring (?). > > > > The current

[parent] maven-surefire-plugin 2.21.0

2018-03-06 Thread Gary Gregory
Let's wait for maven-surefire-plugin 2.21.0 to populate to MC, update [parent], before trying another RC... SVP. This should fixing testing on Java >= 10. Gary

[All] GitHub partial update

2018-03-06 Thread Gilles
Hi. It seems there are glitches with the mirroring (?). The current version of this file (on GitHub) https://github.com/apache/commons-numbers/blob/master/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/CStandardTest.java is not the same as on Apache

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Rob Tompkins
> On Mar 6, 2018, at 8:41 AM, Jochen Wiedmann wrote: > >> On Tue, Mar 6, 2018 at 2:24 PM, Gilles wrote: >> (1) >> "FindBugs" should be replaced by "SpotBugs" (or there will >> be failures when creating "module-info" files). > > +1 to

Re: [All] GitHub partial update

2018-03-06 Thread Otto Fowler
You should open an INFRA ticket On March 6, 2018 at 09:12:41, Gilles (gil...@harfang.homelinux.org) wrote: > Hi. > > It seems there are glitches with the mirroring (?). > > The current version of this file (on GitHub) > > >

[CANCEL][LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Rob Tompkins
I’m cancelling this vote to include the findbugs replacement. -Rob > On Mar 6, 2018, at 6:54 AM, Rob Tompkins wrote: > > Hello all, > > This is a [LAZY][VOTE] for releasing Apache Commons Parent 44 (from RC1). > > Tag name: > commons-parent-44-RC1 > > Tag URL: >

Re: [All] GitHub partial update

2018-03-06 Thread Gilles
On Tue, 06 Mar 2018 14:31:24 +, Gary Gregory wrote: Yep, INFRA... Gary On Tue, Mar 6, 2018, 07:24 Otto Fowler wrote: You should open an INFRA ticket Done: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-16150 Gilles On March 6, 2018 at

[parent] No version for the assembly plugin

2018-03-06 Thread Gary Gregory
Hi All: Is there a reason why our [parent] POM does not define a version for the assembly plugin? Granted, it is defined in the Apache parent POM. Gary

Re: [parent] maven-surefire-plugin 2.21.0

2018-03-06 Thread Gary Gregory
On Tue, Mar 6, 2018 at 9:10 AM, Gary Gregory wrote: > Let's wait for maven-surefire-plugin 2.21.0 to populate to MC, update > [parent], before trying another RC... SVP. This should fixing testing on > Java >= 10. > Done. Gary > > Gary >

Re: [CANCEL][LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Gary Gregory
On Tue, Mar 6, 2018 at 7:17 AM, Rob Tompkins wrote: > I’m cancelling this vote to include the findbugs replacement. > Also the new surefire plugin version SVP; see the other thread I started before I found this one. Gary > > -Rob > > > On Mar 6, 2018, at 6:54 AM, Rob

[io] org.apache.commons.io.input.Tailer to implement Closeable

2018-03-06 Thread Gary Gregory
Hi All: It seems to me that org.apache.commons.io.input.Tailer should implement Closeable. Thoughts? Gary

[LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Rob Tompkins
Hello all, This is a [LAZY][VOTE] for releasing Apache Commons Parent 44 (from RC1). Tag name: commons-parent-44-RC1 Tag URL: https://svn.apache.org/repos/asf/commons/proper/commons-parent/tags/commons-parent-44-RC1/ Commit ID the tag points at: 1825978 Site Zip:

[VFS] FILE_OR_FOLDER breaking tests

2018-03-06 Thread Otto Fowler
If you have a filesystem, where everything could be a FILE_OR_FOLDER type ( or VIRTUAL until attached ), then it seems like you need to replace some of the testcases in the provider suites, since they assume or check for FILE and FOLDER explicitly. I guess my question is, are the tests as they

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Gilles
Hi. (1) "FindBugs" should be replaced by "SpotBugs" (or there will be failures when creating "module-info" files). (2) There is an invalid link in the release notes[1]: ---CUT--- Historical list of changes: http://commons.apache.org/commons-parent-pom.htmlchanges-report.html ---CUT---

Re: [LAZY][VOTE] Release Commons Parent 44 based on RC1

2018-03-06 Thread Jochen Wiedmann
On Tue, Mar 6, 2018 at 2:24 PM, Gilles wrote: > (1) > "FindBugs" should be replaced by "SpotBugs" (or there will > be failures when creating "module-info" files). +1 to doing this change quickly, possibly blocking a release. Jochen