Re: [Collections] Next

I suggesst that such a change be version 5.0 On Fri, Jul 13, 2018 at 10:33 PM, Gary Gregory wrote: > Hi all, > > Now that 4.2 is out I think we should update to Java 8 and adapt to lambda. > > Gary > -- I like: Like Like - The likeliest place on the web

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

My +1 and looking for more reviews. Gary On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.4.0 was released, so I would like to release > Apache Commons DBCP 2.5.0. > > The most significant

Re: [Collections] Next

That is not what we normally consider BC at Commons but I understand your point. Gary On Sun, Jul 15, 2018, 11:45 Claude Warren wrote: > It would no longer work with versions before 8. That would break BC would > it not? > > On Sun, Jul 15, 2018 at 1:13 PM, Gary Gregory > wrote: > > > That

Re: [Lang] Rounding Duration

Yes, you are right I forgot about it, but when new commons-lang will requires Java 8 I hope I will be able to help you ;) Aleksander On 15 July 2018 at 21:06, Pascal Schumacher wrote: > Hi Aleksander, > > guess you are referring to java.time.Duration? > > This class was added in Java 8 and

Re: [Collections] Next

That would only be needed if we break BC, let's see if we need to do that first... Gary On Sun, Jul 15, 2018, 01:09 Claude Warren wrote: > I suggesst that such a change be version 5.0 > > On Fri, Jul 13, 2018 at 10:33 PM, Gary Gregory > wrote: > > > Hi all, > > > > Now that 4.2 is out I think

Re: [Lang] Rounding Duration

Hi Aleksander, guess you are referring to java.time.Duration? This class was added in Java 8 and commons-lang currently only requires Java 7. Therefore we can not add this at the moment. Sorry, Pascal Am 14.07.2018 um 21:26 schrieb Aleksander Ściborek: Hello everyone During implamanting a

[GitHub] commons-text issue #85: Add optimization to limited levenshtein distance

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/85 [](https://coveralls.io/builds/17994356) Coverage decreased (-0.02%) to 97.813% when pulling

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

I can get to it this evening/tonight (UTC-4). -Rob > On Jul 15, 2018, at 2:03 PM, Gary Gregory wrote: > > My +1 and looking for more reviews. > > Gary > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: >> >> We have fixed quite a few bugs and added some significant enhancements >>

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

Build works fine on Windows 10 with Java 8. Artifacts and site look good. +1 I noticed the following things: * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. * In README.txt it is stated that "DBCP version 2 requires JDK 1.7.". This is not true for version 2.5. * I had

Re: [Lang] Rounding Duration

Let's cut a Lang release and then update to Java 8. Gary On Sun, Jul 15, 2018, 13:11 Aleksander Ściborek < aleksanderscibo...@gmail.com> wrote: > Yes, you are right > I forgot about it, but when new commons-lang will requires Java 8 I hope I > will be able to help you ;) > Aleksander > > On 15

Re: [Collections] Next

It would no longer work with versions before 8. That would break BC would it not? On Sun, Jul 15, 2018 at 1:13 PM, Gary Gregory wrote: > That would only be needed if we break BC, let's see if we need to do that > first... > > Gary > On Sun, Jul 15, 2018, 01:09 Claude Warren wrote: > > > I

[GitHub] commons-text pull request #85: Add optimization to limited levenshtein dista...

GitHub user luciano-medallia opened a pull request: https://github.com/apache/commons-text/pull/85 Add optimization to limited levenshtein distance When the length difference exceeds the threshold, we can return -1 immediately skipping the algorithm. The reason is that the length

[GitHub] commons-pool issue #9: Move common configuration setter to BaseGenericObject...

Github user coveralls commented on the issue: https://github.com/apache/commons-pool/pull/9 [](https://coveralls.io/builds/17996671) Coverage increased (+0.1%) to 84.988% when pulling

Re: [Lang] Rounding Duration

Am 15.07.2018 um 22:09 schrieb Gary Gregory: Let's cut a Lang release and then update to Java 8. +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #85: Add optimization to limited levenshtein dista...

Github user luciano-medallia commented on a diff in the pull request: https://github.com/apache/commons-text/pull/85#discussion_r202554676 --- Diff: src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java --- @@ -270,12 +270,6 @@ private static int

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

Thanks Rob. Gary On Sun, Jul 15, 2018, 15:01 Rob Tompkins wrote: > I can get to it this evening/tonight (UTC-4). > > -Rob > > > On Jul 15, 2018, at 2:03 PM, Gary Gregory > wrote: > > > > My +1 and looking for more reviews. > > > > Gary > > > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory >

[VOTE][RESULT] Release Apache Commons DBCP 2.5.0 based on RC1

This VOTE passes with +1s from the following PMC members: - Gary Gregory - Rob Tompkins - Oliver Heger I'll proceed with the release now and tomorrow. Gary On Sun, Jul 15, 2018 at 8:01 PM Rob Tompkins wrote: > +1: > > Signatures, Site, build (mvn clean test package site) with java8, java9 >

[GitHub] commons-pool issue #9: Move common configuration setter to BaseGenericObject...

Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/9 Hi @mcgitty, Thank you for the PR. Patch applied with slight modifications Gary --- - To

[GitHub] commons-pool pull request #9: Move common configuration setter to BaseGeneri...

Github user asfgit closed the pull request at: https://github.com/apache/commons-pool/pull/9 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

Thank you for your review; more below. ' On Sun, Jul 15, 2018 at 12:20 PM Oliver Heger wrote: > Build works fine on Windows 10 with Java 8. Artifacts and site look good. > > +1 > > I noticed the following things: > * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. > That

[GitHub] commons-text pull request #85: Add optimization to limited levenshtein dista...

Github user chtompki commented on a diff in the pull request: https://github.com/apache/commons-text/pull/85#discussion_r202562835 --- Diff: src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java --- @@ -270,12 +270,6 @@ private static int

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

+1: Signatures, Site, build (mvn clean test package site) with java8, java9 (with some weird erroneous stack traces associated with the maven-project-info-reports-plugin), and java10 (with similar erroneous stack traces) all look good. > On Jul 12, 2018, at 8:43 PM, Gary Gregory wrote: > >

[GitHub] commons-pool pull request #9: Move common configuration setter to BaseGeneri...

GitHub user mcgitty opened a pull request: https://github.com/apache/commons-pool/pull/9 Move common configuration setter to BaseGenericObjectPool Move common configuration setter calls to a new `BaseGenericObjectPool.setBaseConfig()` method to avoid repeated code in both