kinow commented on issue #100: TEXT-104: Jaro Winkler Distance refers to
similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-465063138
HI @saschaszott ! Thanks for updating it so quickly! Only had time to look
at it now (almost bed time). Will review it tomorrow
+1
Reports, signatures good
build works properly on java 8, and has documented failure on java 10 and 11.
Few nits checkstyle, pmd, cpd.
Quite happy that our test coverage is improving as well.
> On Feb 15, 2019, at 11:01 AM, Gary Gregory wrote:
>
> We have fixed quite a few bugs and added
vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-465420789
Either open a bug in jira, or send a message on the dev list, to start the
conversation.
On 2019-02-19, Marcelo Vanzin wrote:
> I'm opening a vote based on recent discussions about the extra noise
> generated by github updates going to dev@. So please vote:
> - +1 to redirect github updates of all commons repos to the issues@ list
> - -1 to keep things as is
> If the vote passes,
(please make sure to add me to CC)
+1
On Tue, 19 Feb 2019 at 21:13, Stefan Bodewig wrote:
>
> On 2019-02-19, Marcelo Vanzin wrote:
>
> > I'm opening a vote based on recent discussions about the extra noise
> > generated by github updates going to dev@. So please vote:
>
> > - +1 to redirect
kinow merged pull request #100: TEXT-104: Jaro Winkler Distance refers to
similarity
URL: https://github.com/apache/commons-text/pull/100
This is an automated message from the Apache Git Service.
To respond to the message,
kinow commented on issue #100: TEXT-104: Jaro Winkler Distance refers to
similarity
URL: https://github.com/apache/commons-text/pull/100#issuecomment-465452196
@saschaszott perfect contribution! You used good issue title, commit
messages, wrote tests using latest version of the API
Le mar. 19 févr. 2019 à 22:35, Marcelo Vanzin
a écrit :
>
> I'm opening a vote based on recent discussions about the extra noise
> generated by github updates going to dev@. So please vote:
>
> - +1 to redirect github updates of all commons repos to the issues@ list
> - -1 to keep things as is
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-465373572
Great. When will I be able to pull the version with these changes out of
the Maven repo?
vanzin closed pull request #91: run time support is added for openssl 1.0 and
1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91
This is an automated message from the Apache Git Service.
To respond to the
vanzin commented on issue #91: run time support is added for openssl 1.0 and
1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91#issuecomment-465374162
#92 takes care of this.
This is an automated message from
vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-465374074
Getting a release out will probably take a while, unless someone takes over
fixing the Windows side of
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-465382885
The project I'm using commons crypto for makes heavy use of a keyed
pseudorandom function, so
Hi all,
Just finished merging a pull request to TEXT-104, where the JaroWinkler
distance was updated. The class was actually computing a text similarity score,
not an edit distance. The user that contributed did a great job moving the
logic into a separate class, then updating the method to
kinow commented on issue #65: Performance Enhancement: Call toArray with Zero
Array Size
URL: https://github.com/apache/commons-io/pull/65#issuecomment-465462167
Thanks @namannigam . So I believe so far the overall consensus here is that
the change in the pull request is OK. Let's give it
I'm opening a vote based on recent discussions about the extra noise
generated by github updates going to dev@. So please vote:
- +1 to redirect github updates of all commons repos to the issues@ list
- -1 to keep things as is
If the vote passes, I'll take care of opening an infra ticket
+1
On Tue, Feb 19, 2019 at 1:35 PM Marcelo Vanzin
wrote:
> I'm opening a vote based on recent discussions about the extra noise
> generated by github updates going to dev@. So please vote:
>
> - +1 to redirect github updates of all commons repos to the issues@ list
> - -1 to keep things as is
>
This VOTE passes with 3 binding +1s:
- Bruno P. Kinoshita
- Gary Gregory
- Rob Tompkins
Gary
On Tue, Feb 19, 2019 at 10:17 AM Rob Tompkins wrote:
> +1
>
> Reports, signatures good
> build works properly on java 8, and has documented failure on java 10 and
> 11.
>
> Few nits checkstyle,
vanzin merged pull request #92: OpenSSL 1.1.0 updates with backward
compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92
This is an automated message from the Apache Git Service.
+1
Am 19.02.2019 um 22:35 schrieb Marcelo Vanzin:
I'm opening a vote based on recent discussions about the extra noise
generated by github updates going to dev@. So please vote:
- +1 to redirect github updates of all commons repos to the issues@ list
- -1 to keep things as is
If the vote
20 matches
Mail list logo
