Re: JDK 15 is in Rampdown Phase One

2020-06-26 Thread Rob Tompkins
Hi Rory, @XenoAmess (GitHub) found an error in our DateParser related to the addition of a locale called “ff_LR#Adlm,” which we’re tracking here: https://github.com/apache/commons-lang/pull/558 We wanted to let you know. Cheers, -Rob > On

Re: JDK 15 is in Rampdown Phase One

2020-06-26 Thread Rory O'Donnell
Thanks Xeno! Will let you know if anything else required. Rgds,Rory On 26/06/2020 13:15, Xeno Amess wrote: Hi. I submitted the bug(or issue) on bugs.java.com  as you requested. And it said internal review ID : 9065633. on the wabpage. If there anything else I should

Re: JDK 15 is in Rampdown Phase One

2020-06-26 Thread Xeno Amess
Hi. I submitted the bug(or issue) on bugs.java.com as you requested. And it said internal review ID : 9065633. on the wabpage. If there anything else I should do please let me know. Rory O'Donnell 于2020年6月26日周五 下午7:27写道: > Hi Rob, > > Thanks, we are waiting for a bug report to be logged by

Re: JDK 15 is in Rampdown Phase One

2020-06-26 Thread Rory O'Donnell
Hi Rob, Thanks, we are waiting for a bug report to be logged by Xeno. Rgds,Rory On 26/06/2020 11:10, Rob Tompkins wrote: Hi Rory, @XenoAmess (GitHub) found an error in our DateParser related to the addition of a locale called “ff_LR#Adlm,” which we’re tracking here:

Re: [lang] org.apache.commons.lang3.concurrent.Locks.Lock

2020-06-26 Thread Miguel Muñoz
The "lockedObject" might be better named "lockableObject." That way it makes no assumptions about its current state. Building on this, the class might be called Lockable. However, I also like the idea of calling the class Locker, as in a gym locker. The idea is that it holds something important.

Re: [lang] org.apache.commons.lang3.concurrent.Locks.Lock

2020-06-26 Thread Gary Gregory
The 'Locks' class is in master. My PR is in my 1st message. Gary On Fri, Jun 26, 2020 at 5:27 PM Miguel Muñoz wrote: > The "lockedObject" might be better named "lockableObject." That way it > makes no assumptions about its current state. Building on this, the class > might be called Lockable.

[lang] org.apache.commons.lang3.concurrent.Locks.Lock

2020-06-26 Thread Gary Gregory
Hi All: I know email is a challenging medium for code reviews, so please consider these comments coming from my best intentions, constructive and caring ;-) Also please excuse the meandering nature of this post. The new class org.apache.commons.lang3.concurrent.Locks.Lock needs better names IMO,