Re: [CLI] Changing the code style

2017-06-21 Thread Gary Gregory
On Fri, Jun 16, 2017 at 1:50 AM, Benedikt Ritter wrote: > Hi, > > CLI unlike other components has a custom code style. While other > components pretty much follow the Sun code guidelines, the CLI code base > uses a style like the Maven project. For me it’s annoying the switch

Re: [CLI] Changing the code style

2017-06-16 Thread Amey Jadiye
+1, keeping same discipline throughout components is always better, I liked the way Lang and Text is maintained at this point. not only checkstyle but findbug, clirr, javadoc also should passed clean for each component. Regards, Amey On Fri, Jun 16, 2017 at 2:20 PM, Benedikt Ritter

Re: [CLI] Changing the code style

2017-06-16 Thread Bruno P. Kinoshita
No objection from me. +1 and thanks for taking care of it :) Cheers Bruno From: Benedikt Ritter <brit...@apache.org> To: Commons Developers List <dev@commons.apache.org> Sent: Friday, 16 June 2017 8:50 PM Subject: [CLI] Changing the code style Hi,

[CLI] Changing the code style

2017-06-16 Thread Benedikt Ritter
Hi, CLI unlike other components has a custom code style. While other components pretty much follow the Sun code guidelines, the CLI code base uses a style like the Maven project. For me it’s annoying the switch code style configurations between components. If nobody objects, I’d like to apply