Re: [CLI] Changing the code style

[Gary Gregory]

On Fri, Jun 16, 2017 at 1:50 AM, Benedikt Ritter  wrote:

> Hi,
>
> CLI unlike other components has a custom code style. While other
> components pretty much follow the Sun code guidelines, the CLI code base
> uses a style like the Maven project. For me it’s annoying the switch code
> style configurations between components. If nobody objects, I’d like to
> apply the same rules like we have them in lang or text. I’m also going to
> enforce this rules using checkstyle and will make checkstyle part of the
> Travis CI build.
>

+1

Gary


>
> Cheers,
> Benedikt
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [CLI] Changing the code style

[Amey Jadiye]

+1, keeping same discipline throughout components is always better, I liked
the way Lang and Text is maintained at this point.
not only checkstyle but findbug, clirr, javadoc  also should passed clean
for each component.

Regards,
Amey

On Fri, Jun 16, 2017 at 2:20 PM, Benedikt Ritter  wrote:

> Hi,
>
> CLI unlike other components has a custom code style. While other
> components pretty much follow the Sun code guidelines, the CLI code base
> uses a style like the Maven project. For me it’s annoying the switch code
> style configurations between components. If nobody objects, I’d like to
> apply the same rules like we have them in lang or text. I’m also going to
> enforce this rules using checkstyle and will make checkstyle part of the
> Travis CI build.
>
> Cheers,
> Benedikt
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Re: [CLI] Changing the code style

[Bruno P. Kinoshita]

No objection from me. +1 and thanks for taking care of it :)

Cheers
Bruno

From: Benedikt Ritter <brit...@apache.org>
To: Commons Developers List <dev@commons.apache.org> 
Sent: Friday, 16 June 2017 8:50 PM
Subject: [CLI] Changing the code style



Hi,


CLI unlike other components has a custom code style. While other components 
pretty much follow the Sun code guidelines, the CLI code base uses a style like 
the Maven project. For me it’s annoying the switch code style configurations 
between components. If nobody objects, I’d like to apply the same rules like we 
have them in lang or text. I’m also going to enforce this rules using 
checkstyle and will make checkstyle part of the Travis CI build.


Cheers,

Benedikt

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[CLI] Changing the code style

[Benedikt Ritter]

Hi,

CLI unlike other components has a custom code style. While other components 
pretty much follow the Sun code guidelines, the CLI code base uses a style like 
the Maven project. For me it’s annoying the switch code style configurations 
between components. If nobody objects, I’d like to apply the same rules like we 
have them in lang or text. I’m also going to enforce this rules using 
checkstyle and will make checkstyle part of the Travis CI build.

Cheers,
Benedikt
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org