[GitHub] commons-collections pull request #36: The verification of unsupported iterat...

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/36


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections pull request #36: The verification of unsupported iterat...

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/36


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-collections pull request #36: The verification of unsupported iterat...

2018-03-07 Thread oscarlvp
GitHub user oscarlvp opened a pull request:

https://github.com/apache/commons-collections/pull/36

The verification of unsupported iterator methods was not complete.

In particular there is a verification for unsupported `add` and `set` 
methods in iterators. The verification misses an assertion. If the unsupported 
method does not throw the exception the test doesn't fail.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oscarlvp/commons-collections improving-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #36


commit 10700e61567f10e8ca551c1fc50a155c8a01141f
Author: oscarlvp 
Date:   2018-03-07T17:31:06Z

The verification of unsupported iterator methods was not complete.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org