[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-05-21 Thread markt-asf 
Github user markt-asf commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
Thanks for the PR. I've fixed this in a slightly different way after 
reviewing the prior changes. The tst case I used largely as-is. Thanks.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-04-04 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
I should be able to take a look tomorrow or the next day.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-30 Thread cdeneux 
Github user cdeneux commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
Hi @garydgregory,

To be able to release our product [Petals ESB](http://petals.ow2.org/), we 
wish embed this fix. We can use the official released artefact, or our own 
forked artefact.
To choose between both ways, can you tell me when you plan to merge this PR 
and when you release ? Have you everything you needed to do it ?

Regards,
Christophe


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-07 Thread cdeneux 
Github user cdeneux commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
Hi @garydgregory,

I have just updated the PR with a unit test validating the correct freeing 
of eviction objects.

Regards,
Christophe


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-06 Thread garydgregory 
Github user garydgregory commented on the issue:

https://github.com/apache/commons-pool/pull/4
  
Hello @cdeneux !

Thank you for your PR. 

Would you mind updating this PR with a unit test? It would be best if the 
test failed without the changes to the main file.

Thank you,
Gary


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-05 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-pool/pull/4
  

[![Coverage 
Status](https://coveralls.io/builds/15805552/badge)](https://coveralls.io/builds/15805552)

Coverage increased (+0.06%) to 84.784% when pulling 
**ec8b7769585bcb86a42a53a2d939c271194ebe9d on petalslink:POOL-337** into 
**30d5db67a2cd0bf3d9a2dd7ffaa7dd247760a9bd on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...

2018-03-05 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-pool/pull/4
  

[![Coverage 
Status](https://coveralls.io/builds/15805552/badge)](https://coveralls.io/builds/15805552)

Coverage increased (+0.06%) to 84.784% when pulling 
**ec8b7769585bcb86a42a53a2d939c271194ebe9d on petalslink:POOL-337** into 
**30d5db67a2cd0bf3d9a2dd7ffaa7dd247760a9bd on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org