[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory Thank you for the patient answer, I understand. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/7 If by "moving" you mean deleting a method from an interface, that would break binary compatibility, which we cannot do outside of a major release (where we would change the package name and Maven artifact id.) You _can_ add an interface any time since that does not break binary compatibility. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the operation of PooledObject. At present, can this be considered this way? If there is a need to add an interface, when can it be added? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the operation of PooledObject. At present, can this be considered this way? If there is a need to add an interface, when can it be added? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/7 Right, we cannot add method to existing interfaces outside of a major release. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 **Check checkAPIcompatibility failed:** - org.apache.commons.pool2.PooledObject: Method 'public void setState(org.apache.commons.pool2.PooledObjectState)' has been added to an interface --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 Add ```getState()``` on ```PooledObject```, checkAPIcompatibility failed. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
