Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-16 Thread Oliver Heger
Am 16.07.2018 um 02:17 schrieb Gary Gregory: > Thank you for your review; more below. > ' > On Sun, Jul 15, 2018 at 12:20 PM Oliver Heger > wrote: > >> Build works fine on Windows 10 with Java 8. Artifacts and site look good. >> >> +1 >> >> I noticed the following things: >> * In the first sen

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Rob Tompkins
+1: Signatures, Site, build (mvn clean test package site) with java8, java9 (with some weird erroneous stack traces associated with the maven-project-info-reports-plugin), and java10 (with similar erroneous stack traces) all look good. > On Jul 12, 2018, at 8:43 PM, Gary Gregory wrote: > > W

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Gary Gregory
Thank you for your review; more below. ' On Sun, Jul 15, 2018 at 12:20 PM Oliver Heger wrote: > Build works fine on Windows 10 with Java 8. Artifacts and site look good. > > +1 > > I noticed the following things: > * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. > That

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Gary Gregory
Thanks Rob. Gary On Sun, Jul 15, 2018, 15:01 Rob Tompkins wrote: > I can get to it this evening/tonight (UTC-4). > > -Rob > > > On Jul 15, 2018, at 2:03 PM, Gary Gregory > wrote: > > > > My +1 and looking for more reviews. > > > > Gary > > > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory > w

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Rob Tompkins
I can get to it this evening/tonight (UTC-4). -Rob > On Jul 15, 2018, at 2:03 PM, Gary Gregory wrote: > > My +1 and looking for more reviews. > > Gary > >> On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: >> >> We have fixed quite a few bugs and added some significant enhancements >> si

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Oliver Heger
Build works fine on Windows 10 with Java 8. Artifacts and site look good. +1 I noticed the following things: * In the first sentence of RELEASE-NOTES.txt the version has a -SNAPSHOT. * In README.txt it is stated that "DBCP version 2 requires JDK 1.7.". This is not true for version 2.5. * I had so

Re: [VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-15 Thread Gary Gregory
My +1 and looking for more reviews. Gary On Thu, Jul 12, 2018 at 6:43 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.4.0 was released, so I would like to release > Apache Commons DBCP 2.5.0. > > The most significant

[VOTE] Release Apache Commons DBCP 2.5.0 based on RC1

2018-07-12 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.4.0 was released, so I would like to release Apache Commons DBCP 2.5.0. The most significant change is support for JDCB 4.2 which now requires Java 8. Apache Commons DBCP 2.5.0 RC1 is available for