Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
On Thu, 27 Oct 2022 at 22:46, Gary Gregory wrote: > > Would you mind creating a ticket for the proper Maven plugin? https://issues.apache.org/jira/browse/MCHANGES-413 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
Would you mind creating a ticket for the proper Maven plugin?
Gary
On Wed, Oct 26, 2022, 12:58 Eric Bresie wrote:
> Looking on the plug-in side (1) if this hasn’t changed any and I’m reading
> it correctly, seems like the json Node in use has no displayName or name
> attributes present.
>
> Reference
> (1)
>
> https://github.com/behrica/maven-changes-plugin/blob/master/src/main/java/org/apache/maven/plugin/jira/RestJiraDownloader.java
>
>
> On Wed, Oct 26, 2022 at 11:31 AM Alex Herbert
> wrote:
>
> > Validated signatures on the binary and src distributions.
> >
> > Built from src.zip using:
> >
> > maven install site -P jacoco -P japicmp
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 11.0.16, vendor: Ubuntu, runtime:
> > /usr/lib/jvm/java-11-openjdk-amd64
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > "unix"
> >
> > I received a NullPointerException from the Jira report:
> >
> > [INFO] Generating "JIRA Report" report ---
> > maven-changes-plugin:2.12.1:jira-report
> > WARNING: An illegal reflective access operation has occurred
> > WARNING: Illegal reflective access by
> > org.apache.cxf.transport.http.CXFAuthenticator
> > (file:/home/ah403/.m2/repository/org/apache/cxf/
> > cxf-rt-transports-http/2.6.3/cxf-rt-transports-http-2.6.3.jar) to
> > field java.net.Authenticator.theAuthenticator
> > WARNING: Please consider reporting this to the maintainers of
> > org.apache.cxf.transport.http.CXFAuthenticator
> > WARNING: Use --illegal-access=warn to enable warnings of further
> > illegal reflective access operations
> > WARNING: All illegal access operations will be denied in a future release
> > [WARNING]
> > java.lang.NullPointerException
> >at org.apache.maven.plugin.jira.RestJiraDownloader.processPriority
> > (RestJiraDownloader.java:392)
> >at org.apache.maven.plugin.jira.RestJiraDownloader.buildIssues
> > (RestJiraDownloader.java:329)
> >at org.apache.maven.plugin.jira.RestJiraDownloader.doExecute
> > (RestJiraDownloader.java:172)
> >
> > The same build using Java 8 also had the same error using:
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> > /usr/lib/jvm/jdk1.8.0_333/jre
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > "unix"
> >
> > I checked your site build in the SVN staging repo and that also does
> > not have a Jira report.
> >
> > There is one skipped test for BCEL-291. The Jira ticket is marked as
> > fix version 6.6.0; the ticket is reopened. Perhaps the fix version
> > should be updated as it has not yet been fixed.
> >
> > There are a few PMD items to easily clean up. Empty catch blocks can
> > use 'catch(Exception ignored) {'. There are some redundant final
> > keywords to remove. Can be done post release.
> >
> > All other reports are OK. Some Spotbugs issues but they have been
> > around for a while.
> >
> > So this seems OK except the broken Jira report. I don't think this is
> > a blocker given that the live site for 6.6.0 also has no Jira report.
> > I cannot see anything custom in the pom to configure the jira report.
> > The exception stack trace is at method processPriority. So perhaps
> > there is a ticket with an unusual priority. I see some tickets where
> > there is an additional priority field with P1, P2, P3 as well as the
> > usual priority field with major, minor, etc (see BCEL-183 [1]). There
> > is nothing in commons parent configuring priority so it could be a
> > loss leader. When you search for issues in BCEL using e.g. 'project =
> > BCEL AND priority = P2' it finds no tickets, so this extra field is
> > not searchable. There is something broken with the Jira project for
> > BCEL. Fixing that is outside the scope of the release.
> >
> > +1
> >
> > Alex
> >
> > [1] https://issues.apache.org/jira/browse/BCEL-183
> >
> > On Sun, 23 Oct 2022 at 15:58, Gary Gregory
> wrote:
> > >
> > > We have fixed one bug since Apache Commons BCEL 6.6.0 was released, so
> > > I would like to release Apache Commons BCEL 6.6.1. This will help
> > > SpotBugs migrate from 6.5.0.
> > >
> > > Apache Commons BCEL 6.6.1 RC1 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.6.1-RC1 (svn
> > > revision 57519)
> > >
> > > The Git tag commons-bcel-6.6.1-RC1 commit for this RC is
> > > ec208052baf4c596f7e8cfacc281d3e2408809ac which you can browse here:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=ec208052baf4c596f7e8cfacc281d3e2408809ac
> > > You may checkout this tag using:
> > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > > --branch commons-bcel-6.6.1-RC1 commons-bcel-6.6.1-RC1
> > >
> > > Maven
Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
Thanks Alex! Gary On Thu, Oct 27, 2022, 08:39 Alex Herbert wrote: > On Thu, 27 Oct 2022 at 12:36, Alex Herbert > wrote: > > > > I have reopened the tickets, removed the P2 priority field (just in case > it was also contributing to the problem), assigned the priority as minor > and closed the tickets. > > > > The Jira report is now fixed. > > Strangely it was not fixed in the site build, only when running 'mvn > changes:jira-report'. I tracked this issue to the following tickets > that are resolved but not closed and are missing the priority field: > > BCEL-84, BCEL-38, BCEL-4, BCEL-80 > > I have changed them to priority minor. Now 'mvn clean package site' > works on master. > > Alex > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
On Thu, 27 Oct 2022 at 12:36, Alex Herbert wrote: > > I have reopened the tickets, removed the P2 priority field (just in case it > was also contributing to the problem), assigned the priority as minor and > closed the tickets. > > The Jira report is now fixed. Strangely it was not fixed in the site build, only when running 'mvn changes:jira-report'. I tracked this issue to the following tickets that are resolved but not closed and are missing the priority field: BCEL-84, BCEL-38, BCEL-4, BCEL-80 I have changed them to priority minor. Now 'mvn clean package site' works on master. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
I have reopened the tickets, removed the P2 priority field (just in case it
was also contributing to the problem), assigned the priority as minor and
closed the tickets.
The Jira report is now fixed.
Alex
On Thu, 27 Oct 2022 at 09:26, Alex Herbert wrote:
> Hi Eric,
>
> Thanks for the tip for investigating the jira report. I got the latest
> source code for the changes plugin and printed out the offending nodes
> that have no priority (issue id, key):
>
> Missing priority 12619331: BCEL-165
> Missing priority 12619323: BCEL-157
> Missing priority 12619318: BCEL-152
> Missing priority 12619293: BCEL-127
> Missing priority 12619287: BCEL-121
> Missing priority 12619279: BCEL-113
> Missing priority 12619276: BCEL-110
> Missing priority 12619241: BCEL-75
>
> Looking at these tickets (e.g. [1]) it seems that they share this in
> common:
>
> They have an external issue ID and a link to bugzilla
> The priority is of the form [P0, P1, P2, ...]. All have P2.
>
> Since the tickets are closed I suggest we reopen them and update the
> properties so that my test plugin can process the tickets.
>
> Alex
>
> [1] https://issues.apache.org/jira/browse/BCEL-165
>
> On Wed, 26 Oct 2022 at 17:58, Eric Bresie wrote:
> >
> > Looking on the plug-in side (1) if this hasn’t changed any and I’m
> reading
> > it correctly, seems like the json Node in use has no displayName or name
> > attributes present.
> >
> > Reference
> > (1)
> >
> https://github.com/behrica/maven-changes-plugin/blob/master/src/main/java/org/apache/maven/plugin/jira/RestJiraDownloader.java
> >
> >
> > On Wed, Oct 26, 2022 at 11:31 AM Alex Herbert
> > wrote:
> >
> > > Validated signatures on the binary and src distributions.
> > >
> > > Built from src.zip using:
> > >
> > > maven install site -P jacoco -P japicmp
> > >
> > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > > Maven home: /usr/local/apache-maven-3
> > > Java version: 11.0.16, vendor: Ubuntu, runtime:
> > > /usr/lib/jvm/java-11-openjdk-amd64
> > > Default locale: en_GB, platform encoding: UTF-8
> > > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > > "unix"
> > >
> > > I received a NullPointerException from the Jira report:
> > >
> > > [INFO] Generating "JIRA Report" report ---
> > > maven-changes-plugin:2.12.1:jira-report
> > > WARNING: An illegal reflective access operation has occurred
> > > WARNING: Illegal reflective access by
> > > org.apache.cxf.transport.http.CXFAuthenticator
> > > (file:/home/ah403/.m2/repository/org/apache/cxf/
> > > cxf-rt-transports-http/2.6.3/cxf-rt-transports-http-2.6.3.jar) to
> > > field java.net.Authenticator.theAuthenticator
> > > WARNING: Please consider reporting this to the maintainers of
> > > org.apache.cxf.transport.http.CXFAuthenticator
> > > WARNING: Use --illegal-access=warn to enable warnings of further
> > > illegal reflective access operations
> > > WARNING: All illegal access operations will be denied in a future
> release
> > > [WARNING]
> > > java.lang.NullPointerException
> > >at org.apache.maven.plugin.jira.RestJiraDownloader.processPriority
> > > (RestJiraDownloader.java:392)
> > >at org.apache.maven.plugin.jira.RestJiraDownloader.buildIssues
> > > (RestJiraDownloader.java:329)
> > >at org.apache.maven.plugin.jira.RestJiraDownloader.doExecute
> > > (RestJiraDownloader.java:172)
> > >
> > > The same build using Java 8 also had the same error using:
> > >
> > > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > > Maven home: /usr/local/apache-maven-3
> > > Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> > > /usr/lib/jvm/jdk1.8.0_333/jre
> > > Default locale: en_GB, platform encoding: UTF-8
> > > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > > "unix"
> > >
> > > I checked your site build in the SVN staging repo and that also does
> > > not have a Jira report.
> > >
> > > There is one skipped test for BCEL-291. The Jira ticket is marked as
> > > fix version 6.6.0; the ticket is reopened. Perhaps the fix version
> > > should be updated as it has not yet been fixed.
> > >
> > > There are a few PMD items to easily clean up. Empty catch blocks can
> > > use 'catch(Exception ignored) {'. There are some redundant final
> > > keywords to remove. Can be done post release.
> > >
> > > All other reports are OK. Some Spotbugs issues but they have been
> > > around for a while.
> > >
> > > So this seems OK except the broken Jira report. I don't think this is
> > > a blocker given that the live site for 6.6.0 also has no Jira report.
> > > I cannot see anything custom in the pom to configure the jira report.
> > > The exception stack trace is at method processPriority. So perhaps
> > > there is a ticket with an unusual priority. I see some tickets where
> > > there is an additional priority field with P1, P2, P3 as well as the
> > > usual priority field with major, minor, etc (see BCEL-183 [1]). There
> > > is nothing in commons parent
Re: (RestJiraDownloader) Re: [VOTE] Release Apache Commons BCEL 6.6.1 based on RC1
Hi Eric,
Thanks for the tip for investigating the jira report. I got the latest
source code for the changes plugin and printed out the offending nodes
that have no priority (issue id, key):
Missing priority 12619331: BCEL-165
Missing priority 12619323: BCEL-157
Missing priority 12619318: BCEL-152
Missing priority 12619293: BCEL-127
Missing priority 12619287: BCEL-121
Missing priority 12619279: BCEL-113
Missing priority 12619276: BCEL-110
Missing priority 12619241: BCEL-75
Looking at these tickets (e.g. [1]) it seems that they share this in common:
They have an external issue ID and a link to bugzilla
The priority is of the form [P0, P1, P2, ...]. All have P2.
Since the tickets are closed I suggest we reopen them and update the
properties so that my test plugin can process the tickets.
Alex
[1] https://issues.apache.org/jira/browse/BCEL-165
On Wed, 26 Oct 2022 at 17:58, Eric Bresie wrote:
>
> Looking on the plug-in side (1) if this hasn’t changed any and I’m reading
> it correctly, seems like the json Node in use has no displayName or name
> attributes present.
>
> Reference
> (1)
> https://github.com/behrica/maven-changes-plugin/blob/master/src/main/java/org/apache/maven/plugin/jira/RestJiraDownloader.java
>
>
> On Wed, Oct 26, 2022 at 11:31 AM Alex Herbert
> wrote:
>
> > Validated signatures on the binary and src distributions.
> >
> > Built from src.zip using:
> >
> > maven install site -P jacoco -P japicmp
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 11.0.16, vendor: Ubuntu, runtime:
> > /usr/lib/jvm/java-11-openjdk-amd64
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > "unix"
> >
> > I received a NullPointerException from the Jira report:
> >
> > [INFO] Generating "JIRA Report" report ---
> > maven-changes-plugin:2.12.1:jira-report
> > WARNING: An illegal reflective access operation has occurred
> > WARNING: Illegal reflective access by
> > org.apache.cxf.transport.http.CXFAuthenticator
> > (file:/home/ah403/.m2/repository/org/apache/cxf/
> > cxf-rt-transports-http/2.6.3/cxf-rt-transports-http-2.6.3.jar) to
> > field java.net.Authenticator.theAuthenticator
> > WARNING: Please consider reporting this to the maintainers of
> > org.apache.cxf.transport.http.CXFAuthenticator
> > WARNING: Use --illegal-access=warn to enable warnings of further
> > illegal reflective access operations
> > WARNING: All illegal access operations will be denied in a future release
> > [WARNING]
> > java.lang.NullPointerException
> >at org.apache.maven.plugin.jira.RestJiraDownloader.processPriority
> > (RestJiraDownloader.java:392)
> >at org.apache.maven.plugin.jira.RestJiraDownloader.buildIssues
> > (RestJiraDownloader.java:329)
> >at org.apache.maven.plugin.jira.RestJiraDownloader.doExecute
> > (RestJiraDownloader.java:172)
> >
> > The same build using Java 8 also had the same error using:
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> > /usr/lib/jvm/jdk1.8.0_333/jre
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-194-generic", arch: "amd64", family:
> > "unix"
> >
> > I checked your site build in the SVN staging repo and that also does
> > not have a Jira report.
> >
> > There is one skipped test for BCEL-291. The Jira ticket is marked as
> > fix version 6.6.0; the ticket is reopened. Perhaps the fix version
> > should be updated as it has not yet been fixed.
> >
> > There are a few PMD items to easily clean up. Empty catch blocks can
> > use 'catch(Exception ignored) {'. There are some redundant final
> > keywords to remove. Can be done post release.
> >
> > All other reports are OK. Some Spotbugs issues but they have been
> > around for a while.
> >
> > So this seems OK except the broken Jira report. I don't think this is
> > a blocker given that the live site for 6.6.0 also has no Jira report.
> > I cannot see anything custom in the pom to configure the jira report.
> > The exception stack trace is at method processPriority. So perhaps
> > there is a ticket with an unusual priority. I see some tickets where
> > there is an additional priority field with P1, P2, P3 as well as the
> > usual priority field with major, minor, etc (see BCEL-183 [1]). There
> > is nothing in commons parent configuring priority so it could be a
> > loss leader. When you search for issues in BCEL using e.g. 'project =
> > BCEL AND priority = P2' it finds no tickets, so this extra field is
> > not searchable. There is something broken with the Jira project for
> > BCEL. Fixing that is outside the scope of the release.
> >
> > +1
> >
> > Alex
> >
> > [1] https://issues.apache.org/jira/browse/BCEL-183
> >
> > On Sun, 23 Oct 2022 at 15:58, Gary Gregory wrote:
> > >
> > > We have fixed one
