Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-11 Thread Gilles
On Wed, 9 Aug 2017 10:56:47 +0100, sebb wrote: On 9 August 2017 at 03:57, Gilles wrote: On Tue, 8 Aug 2017 18:49:44 -0700, Chas Honton wrote: Since most of us work in an IDE, the "wasted" time of checkstyle for every build is negligible. IDEs vary in how easy it is to set up the checks to

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-09 Thread sebb
On 9 August 2017 at 03:57, Gilles wrote: > On Tue, 8 Aug 2017 18:49:44 -0700, Chas Honton wrote: >> >> Since most of us work in an IDE, the "wasted" time of checkstyle for >> every build is negligible. IDEs vary in how easy it is to set up the checks to agree with the project settings. And IDEs v

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Gilles
On Tue, 8 Aug 2017 18:49:44 -0700, Chas Honton wrote: Since most of us work in an IDE, the "wasted" time of checkstyle for every build is negligible. It's not just the wasted time of running the tool (which might well be negligible), it's the forcing of e.g. documenting a code that might turn o

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Chas Honton
Since most of us work in an IDE, the "wasted" time of checkstyle for every build is negligible. At my day job, all code is automatically reformatted as part of the build. It's just another step along with PMD, CPD, findbugs, sonar, jacoco, junit, and a few other static analyses. The more we auto

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Gilles
Hello. On Wed, 9 Aug 2017 00:20:00 +0200, Karl-Philipp Richter wrote: Hi, Am 07.08.2017 um 15:09 schrieb Gilles: Less work for the maintainers is good. :-) By "taking time" I meant that validating should not be enforced when calling "mvn compile" or "mvn test". I wouldn't worry about the tim

Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-08 Thread Karl-Philipp Richter
Hi, Am 07.08.2017 um 15:09 schrieb Gilles: > Less work for the maintainers is good. :-) > > By "taking time" I meant that validating should not be enforced when > calling "mvn compile" or "mvn test". I wouldn't worry about the time consumption of the validation even if it's run by every dev befor

Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-07 Thread Gilles
On Mon, 7 Aug 2017 14:49:16 +0300, Allon Mureinik wrote: On Mon, Aug 7, 2017 at 2:36 PM, Gilles wrote: On Mon, 7 Aug 2017 14:08:45 +0300, Allon Mureinik wrote: On Mon, Aug 7, 2017 at 12:16 PM, Gilles wrote: Hello. On Fri, 4 Aug 2017 21:17:43 +0300, Allon Mureinik wrote: We had a simil

Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-07 Thread Allon Mureinik
On Mon, Aug 7, 2017 at 2:36 PM, Gilles wrote: > On Mon, 7 Aug 2017 14:08:45 +0300, Allon Mureinik wrote: > >> On Mon, Aug 7, 2017 at 12:16 PM, Gilles >> wrote: >> >> Hello. >>> >>> On Fri, 4 Aug 2017 21:17:43 +0300, Allon Mureinik wrote: >>> >>> We had a similar discussion about Configuration. >

Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-07 Thread Gilles
On Mon, 7 Aug 2017 14:08:45 +0300, Allon Mureinik wrote: On Mon, Aug 7, 2017 at 12:16 PM, Gilles wrote: Hello. On Fri, 4 Aug 2017 21:17:43 +0300, Allon Mureinik wrote: We had a similar discussion about Configuration. Personally, I'm all for enforcing checkstyle during the validate phase,

Re: [ALL] Automated requirements (e.g. CheckStyle)? (Was: [MATH] Enforce run [...])

2017-08-07 Thread Allon Mureinik
On Mon, Aug 7, 2017 at 12:16 PM, Gilles wrote: > Hello. > > On Fri, 4 Aug 2017 21:17:43 +0300, Allon Mureinik wrote: > >> We had a similar discussion about Configuration. >> >> Personally, I'm all for enforcing checkstyle during the validate phase, >> but >> we couldn't reach a consensus about it