+1
Reports, signatures good
build works properly on java 8, and has documented failure on java 10 and 11.
Few nits checkstyle, pmd, cpd.
Quite happy that our test coverage is improving as well.
> On Feb 15, 2019, at 11:01 AM, Gary Gregory wrote:
>
> We have fixed quite a few bugs and added
My +1
Gary
On Fri, Feb 15, 2019 at 11:01 AM Gary Gregory wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.5.0 was released, so I would like to release
> Apache Commons DBCP 2.6.0.
>
> Apache Commons DBCP 2.6.0 RC1 is available for
[ x ] +1 Release these artifacts (assuming tests failing on Java10 and Java11
are OK)
Built with `mvn clean test install site` on
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_191, vendor:
I forgot to add that on Java 11, the test setup fails:
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
0.03 s <<< FAILURE! - in
org.apache.commons.dbcp2.managed.TestSynchronizationOrder
[ERROR]
