[GitHub] janpio commented on issue #389: WIP: CB-11244: Studio Project Compatibility: Now with merge commit

2017-08-09 Thread git
janpio commented on issue #389: WIP: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-321304897 Just a shoutout from the sidelines: Thanks for tackling this! ?? ?? ?? Working with the current generated

Re: [DISCUSS] Moving JIRA issues to Github

2017-08-09 Thread Steven Gill
Also, we are trying to formalize the proposal at https://github.com/cordova/cordova-discuss/pull/75 On Wed, Aug 9, 2017 at 10:20 AM, Steven Gill wrote: > For security, we already get requests sent to our private mailing list ( > priv...@cordova.apache.org). We then

[GitHub] cordova-plugin-geolocation pull request #92: CB-12895 : Added eslint and rem...

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: git commits being sent to dev

2017-08-09 Thread Steven Gill
it should be changed to comm...@cordova.apache.org now. Lets see On Tue, Aug 8, 2017 at 4:01 PM, Steven Gill wrote: > https://issues.apache.org/jira/browse/INFRA-14823 > > On Tue, Aug 8, 2017 at 3:41 PM, Shazron wrote: > >> Yeah, the last time was

[GitHub] cordova-plugin-device pull request #70: CB-12895 : Setup eslint and removed ...

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console

2017-08-09 Thread git
filmaj opened a new pull request #330: CB-13164: Integrated cordova-plugin-console URL: https://github.com/apache/cordova-ios/pull/330 ### What does this PR do? Adds support for `window.console` to be built in to generated cordova-ios projects. Essentially: sunsetting

[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...

2017-08-09 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/714 (and document 🙈 ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-docs issue #714: CB-12984: (docs) Add Android versions to "supported...

2017-08-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/714 Filed that issue here: https://issues.apache.org/jira/browse/CB-13162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/284#discussion_r132287655 --- Diff: doc/readme.md --- @@ -186,7 +186,7 @@ After building the Android and iOS projects, the Android application will contai Version

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/284#discussion_r132287819 --- Diff: doc/readme.md --- @@ -230,7 +230,7 @@ cordova {platform | platforms} [ | | --save | Updates the version specified in

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/284#discussion_r132287980 --- Diff: doc/readme.md --- @@ -374,7 +374,7 @@ based on the following criteria (listed in order of precedence): ### Examples --

[GitHub] cordova-docs pull request #717: CB-12760: (android) fix internal anchor link

2017-08-09 Thread janpio
Github user janpio closed the pull request at: https://github.com/apache/cordova-docs/pull/717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: git commits being sent to dev

2017-08-09 Thread Filip Maj
Looks like it's no longer spamming. HooraY! On Wed, Aug 9, 2017 at 10:44 AM, Steven Gill wrote: > it should be changed to comm...@cordova.apache.org now. Lets see > > On Tue, Aug 8, 2017 at 4:01 PM, Steven Gill wrote: > >>

[GitHub] cordova-docs issue #717: CB-12760: (android) fix internal anchor link

2017-08-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/717 Not a problem at all :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-docs issue #717: CB-12760: (android) fix internal anchor link

2017-08-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-docs/pull/717 I've rebased, merged and tweaked the commit message over in 4e0692a20. @janpio can you close this PR? Thanks for the fix! --- If your project is set up for it, you can reply to this

[GitHub] cordova-docs issue #717: CB-12760: (android) fix internal anchor link

2017-08-09 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-docs/pull/717 Thanks. Missed the commit message, sorry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #589: removed .jscs.json

2017-08-09 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/589 Thanks for the PR! I have rebased and merged in at 2dc7fe1a. @remcohaszing can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] Moving JIRA issues to Github

2017-08-09 Thread Steven Gill
For security, we already get requests sent to our private mailing list ( priv...@cordova.apache.org). We then create a private issue to track the problem and only make it public once we solve the problem and do a release. Instead of a private jira instance, we could use a private github repo.

[GitHub] cordova-plugin-inappbrowser pull request #236: CB-12895 : Added eslint and r...

2017-08-09 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/236 CB-12895 : Added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint ### What

[GitHub] cordova-plugin-globalization pull request #60: CB-12895 : added eslint and r...

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-cli issue #284: Update readme.md - Proposal of corrections

2017-08-09 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/284 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-cli pull request #284: Update readme.md - Proposal of corrections

2017-08-09 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/284#discussion_r132319941 --- Diff: doc/readme.md --- @@ -374,7 +374,7 @@ based on the following criteria (listed in order of precedence): ### Examples

[GitHub] cordova-plugin-globalization pull request #60: CB-12895 : added eslint and r...

2017-08-09 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/60 CB-12895 : added eslint and removed jshint ### Platforms affected ### What does this PR do? Added eslint and removed jshint. ### What

[GitHub] cordova-coho pull request #154: CB-12895 : Added eslint

2017-08-09 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/154 CB-12895 : Added eslint ### Platforms affected ### What does this PR do? Added eslint ### What testing has been done on this change?

Nightly build #449 for cordova has failed

2017-08-09 Thread Apache Jenkins Server
Nightly build #449 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/449/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/449/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-js pull request #146: CB-13163: fix using relative paths in calls to...

2017-08-09 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-js/pull/146 CB-13163: fix using relative paths in calls to require. Using relative paths in calls to `require` failed. The single-character patch caused me to chuckle. Added a test for this

[GitHub] cordova-js pull request #146: CB-13163: fix using relative paths in calls to...

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

2017-08-09 Thread MeirBon
Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 @RafaelKr Don't have the time right now to work on this. Feel free to make a pull request to my fork and I will take a look when I have time. --- If your project is set up for