[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Upon further review - the Podfile should not be added. The unit tests actually show the problem -- the Podfile was not created. The `spyOn` for `writeFileSync` in the tests should have a

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Tests fail. I cloned cordova-ios, applied the PR patch, npm install then npm test. Perhaps you forgot to check in `tests/spec/unit/fixtures/testProj/platforms/ios/Podfile`? Log:

[VOTE] Cordova-common@1.4.1 release

Please review and vote on this cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11690 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11690/ The

Re: [VOTE] Cordova-common@1.4.1 release

+1 On 8/9/16, 4:32 PM, "Steven Gill" wrote: >Please review and vote on this cordova-common Release >by replying to this email (and keep discussion on the DISCUSS thread) > >Release issue: https://issues.apache.org/jira/browse/CB-11690 > >Both tools have been published to

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 The `podMod.spec.js` tests should have a “cleanup” after all tests are run (not sure how in Jasmine 1.0) which should remove the test products

[GitHub] cordova-ios issue #234: CB-9825 cocoapod integration for plugins

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/234 Sadly Jasmine 1.x doesn't have an `afterAll` global function unlike Jasmine 2.x. You would have to nest the `describe` tests in a `describe`, sandwiched between two `it`s, the first is the

[GitHub] cordova-plugin-camera pull request #228: add CAMERA and READ_EXTERNAL_STORAG...

GitHub user bisrael opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/228 add CAMERA and READ_EXTERNAL_STORAGE permissions to the manifest file… ### Platforms affected ### What does this PR do? ### What testing has

[GitHub] cordova-plugin-camera issue #228: add CAMERA and READ_EXTERNAL_STORAGE permi...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/228 Cordova CI Build has one or more failures. **Commit** -

Nightly build #97 for cordova has succeeded!

Nightly build #97 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/97/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #476: CB-11679 Speed up save/restore tests

Github user alsorokin commented on the issue: https://github.com/apache/cordova-lib/pull/476 Nice performance increase, LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request #476: CB-11679 Speed up save/restore tests

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[Vote] Tools Release

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11685 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11685 The packages were

[GitHub] cordova-android pull request #322: CB-11683 android: Fixed linking to direct...

GitHub user sprzedamsanki opened a pull request: https://github.com/apache/cordova-android/pull/322 CB-11683 android: Fixed linking to directories Fixed bug described in CB-11683. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android issue #322: CB-11683 android: Fixed linking to directories

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/322 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/322?src=pr) is 33.78% (diff: 28.57%) > Merging

[GitHub] cordova-plugin-dialogs pull request #81: CB-11677 android: fix bug with prom...

GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/81 CB-11677 android: fix bug with prompt text You can merge this pull request into a Git repository by running: $ git pull https://github.com/matrosovN/cordova-plugin-dialogs

[GitHub] cordova-lib issue #477: CB-11688 Fix platform.spec timeout errors

Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/477 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/477?src=pr) is 80.69% (diff: 100%) > Merging [#477](https://codecov.io/gh/apache/cordova-lib/pull/477?src=pr) into

[GitHub] cordova-lib pull request #477: CB-11688 Fix platform.spec timeout errors

GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/477 CB-11688 Fix platform.spec timeout errors [Jira issue](https://issues.apache.org/jira/browse/CB-11688) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-dialogs issue #81: CB-11677 android: fix bug with prompt text

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/81 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-ios pull request #234: CB-9825 cocoapod integration for plugins

Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/234#discussion_r74154432 --- Diff: tests/spec/unit/podMod.spec.js --- @@ -0,0 +1,107 @@ +var fs = require('fs'), + path = require('path'), + cordova =