[GitHub] cordova-android issue #337: CB-11935 Call onPause & onResume on WebView

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/337 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/337?src=pr) is 35.15% (diff: 100%) > Merging

[GitHub] cordova-docs pull request #645: Wrong header-file attribute. "target" should...

GitHub user psavard opened a pull request: https://github.com/apache/cordova-docs/pull/645 Wrong header-file attribute. "target" should be "target-dir" instead. Attribute "target" of header-file does nothing to the file, It's still copied to the root of the plugin folder. Using

[GitHub] cordova-android pull request #337: CB-11935 Call onPause & onResume on WebVi...

GitHub user spirann opened a pull request: https://github.com/apache/cordova-android/pull/337 CB-11935 Call onPause & onResume on WebView Does a best-effort attempt to pause any processing that can be paused safely, such as animations and geolocation. Fix the potential

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user ekrapfl commented on the issue: https://github.com/apache/cordova-ios/pull/257 Out of curiosity, is there any reason to do the archive step at all when building in order to run? Perhaps there could be an option to skip archiving, which would be called when doing a run.

[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/195 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/b90d25c78f14bf0ca55b02f49f40278250663d5e)

[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/195 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/62fa66bff4daadd8297f15bfdaa931add7decb62)

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

Github user fredgalvao commented on the issue: https://github.com/apache/cordova-ios/pull/228 Is there any reason why this PR doesn't also export `CFBundleName` as the result of the short name on config.xml? Follow me for a while: According to [this page on the developer

Nightly build #163 for cordova has failed

Nightly build #163 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/163/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/163/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The only reasons to go through the archive step is to ensure that the build is signed with the right certificates. Building and deploying the .app directly would be signed with a development

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user ekrapfl commented on the issue: https://github.com/apache/cordova-ios/pull/257 dpogue: I see. I was only thinking of the case of trying to run a debug build on a device. I that case, I think skipping the archiving step would potentially be fine. However, if you were

Re: [Discuss] Cordova-Android 6.0.x

OK, so it's been a while. I think we're ready for a release of this soon. I just have to fix up check_reqs so it works, and then we can move forward with the Cordova-Android 6.0.0 release. Should we start the vote thread on Monday? On Tue, Sep 13, 2016 at 11:24 AM, Joe Bowser

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

Github user kerrishotts commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187431 --- Diff: README.md --- @@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

Github user kerrishotts commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81187425 --- Diff: README.md --- @@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 @mikepsinn pretty sure. Currently, the geolocation plugin already adds the `ACCESS_FINE_LOCATION` permission. So assuming we aren't removing that, we need to add the

[GitHub] cordova-ios pull request #260: CB-10078 fixed by refreshing cached userAgent...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Re: unzipping the .ipa. node.js has built-in support through the zlib module: https://nodejs.org/docs/latest-v0.10.x/api/zlib.html --- If your project is set up for it, you can reply to this

Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive on the package On Mon, Sep 26, 2016 at 2:47 PM, Steven Gill wrote: >

Develop a new plugin

Hi, I have a idea to develop a Calander plugin for cordova to add events and reminders. How should i begin to do it?. Is there a template to get started or should I have to write it from scratch? thanks -- Deshan Kalupahana, Undergraduate @ University of Peradeniya, Sri Lanka

Re: Develop a new plugin

Hi Deshan. I'm not sure if there's something like a template or plugin starter, but you can find your way going through the plugins documentation. https://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html On Thu, Sep 29, 2016 at 4:03 PM Deshan Kalupahana <

[GitHub] cordova-lib issue #494: Documentation for using cordova-lib with gulp

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/494 Please close this PR and file an issue at issues.cordova.io -- why is this a pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-docs pull request #645: Wrong header-file attribute. "target" should...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts issue #136: CB-11028 android: Allow to set custom la...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/136 @vladimir-kotikov, updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib issue #453: Support a display name via config.xml

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/453 I think we should as shortName is part of the W3C Widget spec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android issue #333: CB-11869 Fix cordova-js android exec tests

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-android/pull/333 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-lib pull request #494: Documentation for using cordova-lib with gulp

GitHub user mspace opened a pull request: https://github.com/apache/cordova-lib/pull/494 Documentation for using cordova-lib with gulp Is there any documentation available or will be for using cordova-lib with gulp tasks. For example ```javascript

[GitHub] cordova-js issue #137: CB-11522 [windows] Make cordova-js clone handle 'unkn...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-js/pull/137 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Nightly build #162 for cordova has failed

Nightly build #162 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/162/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/162/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-windows pull request #197: CB-11522 [windows] Make cordova-js clone ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #333: CB-11869 Fix cordova-js android exec test...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/333 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-js pull request #137: CB-11522 [windows] Make cordova-js clone handl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android issue #338: CB-11640: Fixing the checks so they check for Ja...

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/338 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/338?src=pr) is 35.15% (diff: 100%) > Merging

Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive on the package * Ran npm install && npm test @purplecabbage risingj.com On Thu, Sep 29, 2016 at

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Just tested this. We need to add a warning if users are not using the system ruby, like the pre-reqs check for xcodebuild (it wouldn't work like you said without the system ruby). I

[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/140#discussion_r81259581 --- Diff: src/platform-release.js --- @@ -111,7 +140,6 @@ function *updateJsSnapshot(repo, version) { } else if

[GitHub] cordova-plugin-wkwebview-engine pull request #22: CB-11937 - Travis CI build...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22 CB-11937 - Travis CI build failing You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Merged into master: https://github.com/apache/cordova-ios/commit/c6587cffe7afded445500c2f30addfdf65290797 -- you can close this PR. Thanks! --- If your project is set up for it, you can

[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/140 CB-11642 Updated CDVAvailability.h in coho prepare-release-branch CB-11642 Updated CDVAvailability.h in coho prepare-release-branch. It affects iOS only. You can merge this pull request

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Yeah, I was hoping to find a convenient way to override Ruby gem paths with environment variables or something, but for now it's probably worth just printing a warning for now. I'm

[GitHub] cordova-js pull request #138: CB-9967

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/138#discussion_r81262704 --- Diff: tasks/lib/bundle.js --- @@ -30,35 +30,44 @@ module.exports = function bundle(platform, debug, commitId, platformVersion, pla var

[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-js pull request #138: CB-9967

Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/138#discussion_r81263858 --- Diff: tasks/lib/bundle.js --- @@ -30,35 +30,44 @@ module.exports = function bundle(platform, debug, commitId, platformVersion, pla var

[GitHub] cordova-plugin-file issue #195: CB-11848 windows: Remove duplicate slash aft...

Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-file/pull/195 @vladimir-kotikov, updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/140#discussion_r81260399 --- Diff: src/platform-release.js --- @@ -111,7 +140,6 @@ function *updateJsSnapshot(repo, version) { } else if

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I filed https://github.com/phonegap/ios-deploy/issues/258 to solve the symlink issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-coho pull request #140: CB-11642 Updated CDVAvailability.h in coho p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-app-hello-world pull request #17: CB-11938 updated csp to include co...

GitHub user stevengill opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/17 CB-11938 updated csp to include content: for img-src You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request #338: CB-11640: Fixing the checks so they check...

GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/338 CB-11640: Fixing the checks so they check for Java 1.8 and higher FINAL VERSIONS Right now, we test for only final and not pre-release versions of the Java language. Therefore, no Java

[GitHub] cordova-android issue #338: CB-11640: Fixing the checks so they check for Ja...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/338 Seriously, I can't even find info on Java 9 working with Android, and jenv is not letting me switch between Java 8 and Java 9, so it's definitely not ready for primetime. :/ --- If your

[VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

Please review and vote on this release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11904 Both packages have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11904/ The packages were

[GitHub] cordova-js pull request #138: CB-9967

Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is