[GitHub] cordova-plugin-geolocation issue #83: CB-11962: (ios) Added variable NSLocat...

2016-10-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/83 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-docs issue #640: Make more comprehensible the french documentation

2016-10-06 Thread ponsfrilus
Github user ponsfrilus commented on the issue: https://github.com/apache/cordova-docs/pull/640 @dblotsky @stevengill @akofman thanks guy. I already tried on crowdin before I found the github page. Crowdin seems to me to be ardous... Anyhow will give it another try when I get some

[GitHub] cordova-plugin-file-transfer issue #160: When "Content-Type" has "multipart/...

2016-10-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/160 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer pull request #160: When "Content-Type" has "mul...

2016-10-06 Thread asapping99
GitHub user asapping99 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/160 When "Content-Type" has "multipart/form-data", should not contain a "Content-Length" in the boundary area. ### Platforms affected platform : ios ###

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

2016-10-06 Thread davidbarre
Github user davidbarre commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 Hi @TanaseButcaru, Do you continue to upgrade your unoffical plugin with version 2.3 ? Or do you consider that version 2.3 of official plugin fix this issues ?

[GitHub] cordova-plugin-file pull request #112: FileProxy.js makeNativeURL() will cau...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request #195: CB-11848 windows: Remove duplicate sl...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-10-06 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/340 If someone knew nothing about Android, and they just fiddled with their icons, would this change, or would we have to delete their old drawable for this to work? --- If your project is

Re: Nightly build #169 for cordova has failed

2016-10-06 Thread Shazron
cordova-cli test failing: > cordova@6.4.0-nightly.2016.10.6.4759c467 test /home/jenkins/jenkins-slave/workspace/cordova-nightly/cordova-cli > node node_modules/jasmine-node/bin/jasmine-node --captureExceptions --color spec .Error: Cannot find module 'dependency-ls' at

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-10-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/340 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/340?src=pr) is 35.15% (diff: 100%) > Merging

[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...

2016-10-06 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/339 OK, so, WTF was that? It appears that we have a test suite problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
GitHub user adzellman opened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can be

[GitHub] cordova-android issue #340: CB-8722 - Move app icons from drawable to mipmap

2016-10-06 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/340 If they were specifying icons via config.xml, this should just work. If they had the platform already installed and had modified files, this shouldn't affect those existing files. ---

[GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...

2016-10-06 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/339 CB-11964: Do a clean when installing a plugin to et around the bug This is a quick fix for the problem, and it might fix some other build errors. I'm not sure about doing it here,

[GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...

2016-10-06 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-android/pull/340 CB-8722 - Move app icons from drawable to mipmap https://issues.apache.org/jira/browse/CB-8722 Reasoning behind the change:

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

2016-10-06 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/496 CB-11936 - Support four new App Transport Security (ATS) keys ### Platforms affected iOS ### What does this PR do? This PR is to support the feature in

[GitHub] cordova-plugin-dialogs issue #88: /!\ Alert on startapp

2016-10-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/88 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-lib issue #496: CB-11936 - Support four new App Transport Security (...

2016-10-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/496 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) is 80.38% (diff: 100%) > Merging [#496](https://codecov.io/gh/apache/cordova-lib/pull/496?src=pr) into

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-inappbrowser issue #190: CB-11955 (osx) Added Initial OSX pla...

2016-10-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/190 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-lib issue #496: CB-11936 - Support four new App Transport Security (...

2016-10-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/496 This needs to go into the next cordova-common release, that will go into the cordova-ios platform, before cordova-ios 4.3.0 is released. --- If your project is set up for it, you can reply to

[GitHub] cordova-docs issue #648: CB-11936 - Add docs for the four new App Transport ...

2016-10-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/648 Only pull in for *cordova-ios 4.3.0* release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios issue #263: CB-11952 - Introduce buildFlag option

2016-10-06 Thread adzellman
Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/263 I'm going to clean this up and submit a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios issue #264: CB-11936 - Support four new App Transport Security (...

2016-10-06 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/264 The tests are expected to fail. Depends on https://github.com/apache/cordova-lib/pull/496 cordova-common being pulled into this repo first. Once that is done, rebase, squash, and the

[GitHub] cordova-plugin-inappbrowser pull request #190: CB-11955 (osx) Added Initial ...

2016-10-06 Thread pwlin
GitHub user pwlin opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/190 CB-11955 (osx) Added Initial OSX platform support ### Platforms affected OSX ### What does this PR do? It adds preliminary support for OSX platform ###

[GitHub] cordova-plugin-dialogs issue #88: /!\ Alert on startapp

2016-10-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/88 Hi. You have created a pull request by mistake. Can you please close it and ask on stack overflow or cordova slack? --- If your project is set up for it, you can reply to

[GitHub] cordova-js pull request #130: Fix CB-3785 - enable EventListener interface s...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-android issue #339: CB-11964: Do a clean when installing a plugin to...

2016-10-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/339 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/339?src=pr) is 34.85% (diff: 45.45%) > Merging

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 do you have a usecase example when remove might be useful? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 `remove` wouldn't be a revert right. Since you have no way to store what got overwritten/merged --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-js pull request #136: handleEvent for addEventListener

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js issue #136: handleEvent for addEventListener

2016-10-06 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-js/pull/136 This has been implemented in #130 Please close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-js/pull/130 Thanks @rayshan! Sorry it took so long to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 @ktop so if I remove an `edit-config` tag from my `config.xml`, it won't actually remove it from `AndroidManifest.xml`. Guessing the solution for users in this case would be to rm and re-add

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

2016-10-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/265 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) is 59.92% (diff: 97.67%) > Merging [#265](https://codecov.io/gh/apache/cordova-ios/pull/265?src=pr) into

Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests

2016-10-06 Thread Steven Gill
Hey Everyone! So I decided to dig into this and wanted to summarize my findings. Please correct me if I'm wrong. 1) is a new tag that allows us to *merge* or *overwrite* elements in config files. it only supports editing *one* element per block of edit-config. If you need multiple edits, you

[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

2016-10-06 Thread rayshan
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/130 Yay! No worries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-lib pull request #493: CB-11908 Handle edit-config in config.xml on ...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #491: CB-11776 Add test case for different edit-config tar...

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/491 Thanks @ktop! Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib pull request #491: CB-11776 Add test case for different edit-con...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #487: CB-11777: Restore plugins before preparing

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/487 Nice investigating @dpogue! Good point about the hook order changing. My gut says it should be fine. Would that be a considered a major change is the question. --- If your

[Vote] Cordova-common@1.5.0 Release

2016-10-06 Thread Steven Gill
Please review and vote on this cordova-common Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11969 Both tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-11969/ The

[GitHub] cordova-lib issue #487: CB-11777: Restore plugins before preparing

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/487 Guess this won't matter if we rip restore out of prepare! https://github.com/cordova/cordova-discuss/pull/54 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 I'm going to merge this in for now so I can get the common release out. But it is definitely worth discussing some of these points. --- If your project is set up for it, you can reply to

Nightly build #170 for cordova has succeeded!

2016-10-06 Thread Apache Jenkins Server
Nightly build #170 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/170/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/492 Thanks for sending this pr @ktop! I've merged it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-android issue #336: CB-11907: Upgrading the Gradle Plugins so they w...

2016-10-06 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/336 Looks like updating the gradle has introduced a nasty bug: https://issues.apache.org/jira/browse/CB-11964 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-dialogs pull request #88: /!/Alert on startapp

2016-10-06 Thread jedofus
GitHub user jedofus opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/88 /!/Alert on startapp Hello , i have problem since i updated platform ios on cordova . i use this code on my onDeviceready() ` if (navigator.notification) { //