[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/498 Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 @vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict is not used anymore in npm@3 -- and we should remove engineStrict anyways. This PR has moved to

Re: camera plugin - target bigger than original picture

I was the one who asked for the email as I think we should discuss it before merging. I agree with Fares idea, if the height or width are greater than the originals then I think we shouldn't upscale the image and return the original image instead. But that should be documented (current PR doesn't

Re: [Vote] Cordova-common@1.5.0 Release

The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Shazron Abdullah Vladimir Kotikov Jesse MacFadyen The vote has passed. On Fri, Oct 7, 2016 at 11:36 AM, Jesse wrote: > I vote +1: > * Ran coho audit-license-headers > * Ran coho

camera plugin - target bigger than original picture

Hi, I sent a pull request for the cordova camera plugin : https://github.com/apache/cordova-plugin-camera/pull/238 I was asked to send you an email. This pull request prevents the plugin from creating bigger pictures than original ones. Thanks Fares Hantous Marki http://markiapp.com/

[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/262 @stevengill yes, it should be `>=4.0.0` and remove the `engineStrict` key as well. I'll add it soon --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-cli issue #262: CB-11976 - Add deprecated node version warning for 0...

Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/262 LGTM Should we update https://github.com/apache/cordova-cli/blob/master/package.json#L8 in this PR? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 This makes sense, but is a backwards incompatible change since the behaviour changes, and some may be using that behaviour. Either: 1. Increment the major version number,

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-geolocation issue #83: CB-11962: (ios) Added variable NSLocat...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/83 Cordova CI Build has completed successfully. **Commit** -

Re: camera plugin - target bigger than original picture

+1 but with caveats as I outlined in the PR. On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I was the one who asked for the email as I think we should discuss it > before merging. > > I agree with Fares idea, if the height or width are greater than the >

Nightly build #174 for cordova has succeeded!

Nightly build #174 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/174/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-cli issue #263: CB-11913 - Re-fix appveyor.yml to use specific node ...

Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/263 Now that I've got appveyor node versions "working", it reflects the node 6 failures on Travis. Now to get node 6 working (npm link shenanigans). --- If your project is set up for it, you can

[GitHub] cordova-ios issue #265: CB-11952 - Introduce buildFlag option

Github user adzellman commented on the issue: https://github.com/apache/cordova-ios/pull/265 @shazron All checks have passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 We have to print the warning out in the getPlatformAPI method, somewhere before this line:

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/498 I would personally favor this change to be "opt-in". I like the idea that npm checks for a newer release before using the cached version of a package. --- If your project is set up for it,

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/497 Closing. Can't have an effective warn in here, moving to cordova-cli. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All. ### What does this PR do? Before running each command, it will check if the node

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82566198 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -72,4 +75,53 @@ function restoreSettings() { } } +/** + * Fetches the

[GitHub] cordova-plugin-dialogs pull request #88: /!\ Alert on startapp

Github user jedofus closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar issue #64: CB-11858: Add possibility to utilize And...

Github user tobiasviehweger commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Just read up again on the expected behaviour here: http://devgirl.org/2014/07/31/phonegap-developers-guid/ It seems blacktranslucent & blackopaque should not be used

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82563323 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -72,4 +75,53 @@ function restoreSettings() { } } +/** + *

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82563870 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) { }

[GitHub] cordova-lib issue #497: CB-11976 - Add deprecated node version warning for 0...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/497 @shazron, we still have `"node": ">=0.9.9"` in [package.json](https://github.com/apache/cordova-lib/blob/master/cordova-lib/package.json#L16). Might want to update it, so the users

[GitHub] cordova-lib pull request #499: Cb 11960

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/499 Cb 11960 ### Platforms affected Will work when adding all platforms. ### What does this PR do? When adding or removing a platform (with --save), the specified

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

Github user TimBarham commented on the issue: https://github.com/apache/cordova-lib/pull/498 @brodybits - that hasn't changed. At the point where we're looking for a cached version, we have already determined the latest version that matches the requested range (for both platforms and

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82568768 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) { }

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user fareshan commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 I just sent the email. I can complete the documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib issue #498: CB-11985 Check if cached platform/plugin exists befo...

Github user brodybits commented on the issue: https://github.com/apache/cordova-lib/pull/498 Thanks @TimBarham for the explanation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/238 I think this should discussed before merging. Can you send an email to dev@cordova.apache.org? Also, if we decide to merge it, you should document the behaviour for

[GitHub] cordova-cli pull request #262: CB-11976 - Add deprecated node version warnin...

GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/262 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All. ### What does this PR do? Before running each command, it will check if the node

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

Github user adzellman closed the pull request at: https://github.com/apache/cordova-ios/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option

GitHub user adzellman reopened a pull request: https://github.com/apache/cordova-ios/pull/265 CB-11952 - Introduce buildFlag option ### Platforms affected iOS ### What does this PR do? - adds buildFlag option for passing args to xcodebuild - There can be