[GitHub] cordova-ios issue #273: Cb-12098 (iOS) update supportedinterfaceorientations...

2016-11-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/273 @sterlingann please update the code according to recommendations in the code review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: [DISCUSS] cordova-ios 4.3.1 patch release

2016-11-16 Thread Kerri Shotts
Cool. I’m working on a couple things related to launch storyboards: - CB-12155: automated tests for launch storyboards, so we can feel confident things are working as they should — in progress; probably 33% done (so if I’m lucky, done by EOW). - CB-12084: clean breaking Xcode project — this

[GitHub] cordova-ios issue #279: CB-12084: Update project build settings & plist

2016-11-16 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/279 let there be tests! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: [DISCUSS] cordova-ios 4.3.1 patch release

2016-11-16 Thread Shazron
Kerri, I will cherry-pick the fixes for the two issues you worked on into the 4.3.x branch when you are done. On Wed, Nov 16, 2016 at 1:31 PM, Shazron wrote: > Any other issues that need to go in this release? The main focus has been > to patch any new features that were

[GitHub] cordova-ios issue #279: CB-12084: Update project build settings & plist

2016-11-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/279 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/279?src=pr) is 60.58% (diff: 76.47%) > Merging [#279](https://codecov.io/gh/apache/cordova-ios/pull/279?src=pr) into

[DISCUSS] cordova-ios 4.3.1 patch release

2016-11-16 Thread Shazron
Any other issues that need to go in this release? The main focus has been to patch any new features that were released in 4.3.0. If not, they would go in 4.4.0 (next version) or 5.0.0 (next year). See:

[GitHub] cordova-ios pull request #279: CB-12084: Update project build settings & pli...

2016-11-16 Thread kerrishotts
GitHub user kerrishotts opened a pull request: https://github.com/apache/cordova-ios/pull/279 CB-12084: Update project build settings & plist ### Platforms affected - iOS ### What does this PR do? Addresses the bug discovered in CB-12084 where

Nightly build #229 for cordova has succeeded!

2016-11-16 Thread Apache Jenkins Server
Nightly build #229 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/229/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-network-information pull request #51: CB-11230 CB-11505 iOS: ...

2016-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...

2016-11-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 Merging, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-network-information issue #51: CB-11230 CB-11505 iOS: Add com...

2016-11-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-network-information/pull/51 @shazron, could you take a look please? This PR just aligns curent implementation for `CDVReachability` with latest Apple's changes. In particular it removes

[GitHub] cordova-plugin-media issue #120: CB-11513: (ios) Fixed: iOS memory warning s...

2016-11-16 Thread romedius
Github user romedius commented on the issue: https://github.com/apache/cordova-plugin-media/pull/120 @stevengill if you have some spare time, could you take a look at this patch too, or point me to the right maintainer? Thank you! --- If your project is set up for it, you can