[GitHub] cordova-windows issue #212: CB-9287 Not enough Icons and Splashscreens for W...

2016-12-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/212 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: [DISCUSS] Plugins Release

2016-12-01 Thread julio cesar sanchez
Bump I updated cordova-plugin-media to work with iOS 10, we should release it. Joe also wanted to release cordova-plugin-camera. We should do the full plugin release. 2016-10-28 0:57 GMT+02:00 julio cesar sanchez : > No, geolocation works fine on iOS 10, the last commit it's just to allow > th

Re: [DISCUSS] Plugins Release

2016-12-01 Thread Simon MacDonald
Well Steve is in Hawaii for 10 days so someone else will have to step up for a plugins release. Simon Mac Donald http://simonmacdonald.com On Thu, Dec 1, 2016 at 8:00 AM, julio cesar sanchez wrote: > Bump > > I updated cordova-plugin-media to work with iOS 10, we should release it. > Joe also w

Re: [Vote] 4.3.1 iOS Release

2016-12-01 Thread Kerri Shotts
I vote +1: Created mobilespec for ios Ran mobilespec auto tests on iOS emulator, some failures (all expected on my end: file-transfer & 2 media tests) Ran npm test, no errors Created hello-world app via CLI, OK Ran on device OK Upgraded app via CLI, OK Ran cordova-lib tests, no errors Tested stor

[GitHub] cordova-plugin-camera pull request #242: CB-11714: (windows) added check for...

2016-12-01 Thread DisruptiveMind
GitHub user DisruptiveMind opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/242 CB-11714: (windows) added check for encoding in savePhoto() without height/width ### Platforms affected Windows 10 ### What does this PR do? Adds ext

Re: [DISCUSS] Plugins Release

2016-12-01 Thread Shazron
I've got a ladder, I'll step up. On Thu, Dec 1, 2016 at 5:02 AM, Simon MacDonald wrote: > Well Steve is in Hawaii for 10 days so someone else will have to step > up for a plugins release. > > Simon Mac Donald > http://simonmacdonald.com > > > On Thu, Dec 1, 2016 at 8:00 AM, julio cesar sanchez >

Re: [DISCUSS] cordova-ios 4.3.1 patch release

2016-12-01 Thread Shazron
Hi Fil, This is the DISCUSS thread. The issue you brought up has been answered by Steve -- it's up to the discretion of the person that releases to update any dependencies to the latest. Ideally updating the dependencies to the latest should be *after* the release, so as to let it bake a bit and s

[GitHub] cordova-plugin-inappbrowser issue #66: CB-7608 : add option useWidthViewPort...

2016-12-01 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/66 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/66/commits/27d28e9319a73d9a128824f815065

[GitHub] cordova-plugin-camera issue #242: CB-11714: (windows) added check for encodi...

2016-12-01 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/242 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/242/commits/a201722f6d9e94dcd071154287416f53b742308

Re: [DISCUSS] cordova-ios 4.3.1 patch release

2016-12-01 Thread Filip Maj
Sounds good. Thanks for pointing it out! On Dec 1, 2016 1:47 PM, "Shazron" wrote: > Hi Fil, > This is the DISCUSS thread. The issue you brought up has been answered by > Steve -- it's up to the discretion of the person that releases to update > any dependencies to the latest. > > Ideally updatin

[GitHub] cordova-plugin-inappbrowser pull request #66: CB-7608 : add option useWidthV...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request #200: CB-7608 (android) document us...

2016-12-01 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/200 CB-7608 (android) document useWidthViewPort ### Platforms affected Android ### What does this PR do? Documents new feature added in https://githu

[GitHub] cordova-plugin-inappbrowser pull request #200: CB-7608 (android) document us...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-browser pull request #25: CB-8260: (browser) Fix corrupted zip file ...

2016-12-01 Thread VinceOPS
GitHub user VinceOPS opened a pull request: https://github.com/apache/cordova-browser/pull/25 CB-8260: (browser) Fix corrupted zip file (build) ### Platforms affected Platform "browser" only. ### What does this PR do? Replace the node module `adm-zip`, whic

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559136 --- Diff: README.md --- @@ -114,6 +114,7 @@ instance, or the system browser. - __hardwareback__: set to `yes` to use the ha

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559723 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -815,6 +827,13 @@ - (void)close }); } +- (void)hide --- End d

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559822 --- Diff: src/ios/CDVInAppBrowser.h --- @@ -96,6 +97,7 @@ @property (nonatomic) NSURL* currentURL; - (void)close;

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559216 --- Diff: README.md --- @@ -131,6 +132,7 @@ instance, or the system browser. - __presentationstyle__: Set to `pagesheet`,

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90560844 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -568,7 +576,11 @@ - (void)createViews self.spinner.userInteractionEnabled = NO;

[GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...

2016-12-01 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90559621 --- Diff: src/ios/CDVInAppBrowser.m --- @@ -246,25 +246,11 @@ - (void)show:(CDVInvokedUrlCommand*)command - (void)hide:(CDVInvo

[GitHub] cordova-plugin-wkwebview-engine issue #22: CB-11937 - Travis CI build failin...

2016-12-01 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22 Looks like Travis is trying to "expand" any variables like $(TARGET_BUILD_DIR) when I am running a command that includes it, instead of just passing it through. --- If your

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2016-12-01 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 @jlchereau This PR cannot be merged as is, since there are issues to be resolved. Furthermore, this PR has been set up as a discussion PR to discuss changes and is not ready f

Nightly build #244 for cordova has succeeded!

2016-12-01 Thread Apache Jenkins Server
Nightly build #244 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/244/consoleFull - Jenkins for Apache Cordova -

Re: [DISCUSSION] Windows tag, what should it be doing?

2016-12-01 Thread Jesse
Hi Karen, I am not sure which is the best approach, but I agree that this is an issue. We need to keep the copy functionality. I'll think more and come back. Hopefully more people weigh in to ... Cheers, Jesse @purplecabbage risingj.com On Tue, Nov 29, 2016 at 9:06 AM, Karen Tran wrote: