[GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...

2017-08-22 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615068 --- Diff: src/ios/CDVWKWebViewEngine.m --- @@ -457,6 +457,19 @@ - (void) webView: (WKWebView *) webView

[GitHub] cordova-plugin-wkwebview-engine pull request #42: CB-13205: Dynamic swipe ba...

2017-08-22 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42#discussion_r134615278 --- Diff: src/www/ios/ios-wkwebview.js --- @@ -0,0 +1,9 @@ +var exec = require('cordova/exec'); + +const WkWebKit = {

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-22 Thread Shazron
Renamed board to 4.5.0, left Fil's issue and another that has a PR that is almost done review: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=173 On Tue, Aug 22, 2017 at 11:47 AM, Shazron wrote: > I'll get that in as the lone issue on the board. > I'm also

Nightly build #462 for cordova has failed

2017-08-22 Thread Apache Jenkins Server
Nightly build #462 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/462/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/462/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-22 Thread Filip Maj
CB-12830 [1] is something that I think we should sneak in to the release, time permitting. [1] https://issues.apache.org/jira/browse/CB-12830 On Sat, Aug 12, 2017 at 4:05 AM, Shazron wrote: >  I do! yes 4.4.1 > > On Aug 11, 2017 at 5:40 PM, julio cesar sanchez

[GitHub] cordova-plugin-splashscreen pull request #27: Support iPhone 6/6+ by using U...

2017-08-22 Thread noisysocks
Github user noisysocks closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: I'm baaaaaack!

2017-08-22 Thread Shazron
Welcome back John! Cordova support in Mobile Center? ;) On Tue, Aug 22, 2017 at 11:37 AM, John M. Wargo wrote: > Greetings Cordova Dev Team! > > Its been a while, so I thought I'd pop on the list and re-introduce myself. > > Hello, my name is John M. Wargo and I've been a

Re: I'm baaaaaack!

2017-08-22 Thread Joe Bowser
Welcome Back! On Aug 22, 2017 11:55 AM, "julio cesar sanchez" wrote: > Welcome back! > > El martes, 22 de agosto de 2017, Shazron escribió: > > > Welcome back John! > > Cordova support in Mobile Center? ;) > > > > On Tue, Aug 22, 2017 at 11:37 AM,

I'm baaaaaack!

2017-08-22 Thread John M. Wargo
Greetings Cordova Dev Team! Its been a while, so I thought I'd pop on the list and re-introduce myself. Hello, my name is John M. Wargo and I've been a Cordova developer since PhoneGap version 2 (more or less). I was a contributor for many years and wrote 4 books on Apache Cordova/PhoneGap,

Re: I'm baaaaaack!

2017-08-22 Thread Anis KADRI
Welcome back John! On Tue, Aug 22, 2017 at 11:37 AM John M. Wargo wrote: > Greetings Cordova Dev Team! > > Its been a while, so I thought I'd pop on the list and re-introduce myself. > > Hello, my name is John M. Wargo and I've been a Cordova developer since > PhoneGap

[GitHub] cordova-coho pull request #154: CB-12895 : Added eslint

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #565: CB-12944: Platform's spec is ignored in confi...

2017-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-wkwebview-engine pull request #42: Dynamic swipe back enabled...

2017-08-22 Thread ccorcos
GitHub user ccorcos opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Dynamic swipe back enabled preference ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

Re: I'm baaaaaack!

2017-08-22 Thread julio cesar sanchez
Welcome back! El martes, 22 de agosto de 2017, Shazron escribió: > Welcome back John! > Cordova support in Mobile Center? ;) > > On Tue, Aug 22, 2017 at 11:37 AM, John M. Wargo > wrote: > > > Greetings Cordova Dev Team! > > > > Its been a

[GitHub] cordova-plugin-wkwebview-engine pull request #38: Dynamic Swipe Preference

2017-08-22 Thread ccorcos
Github user ccorcos closed the pull request at: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-08-22 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron please check out my new PR https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 --- If your project is set up for it, you can reply to this email and

Re: I'm baaaaaack!

2017-08-22 Thread Jesse
Welcome again! @purplecabbage risingj.com On Tue, Aug 22, 2017 at 12:50 PM, Joe Bowser wrote: > Welcome Back! > > On Aug 22, 2017 11:55 AM, "julio cesar sanchez" > wrote: > > > Welcome back! > > > > El martes, 22 de agosto de 2017, Shazron

Re: [DISCUSS] cordova-ios 4.1.1 Release

2017-08-22 Thread Shazron
I'll get that in as the lone issue on the board. I'm also thinking this should be 4.5.0 instead of 4.4.1 because there is a new feature in there. On Tue, Aug 22, 2017 at 9:20 AM, Filip Maj wrote: > CB-12830 [1] is something that I think we should sneak in to the > release,

Re: I'm baaaaaack!

2017-08-22 Thread Steven Gill
Woo! Great to have you back. Looking forward to an updated edition of your book ;) On Tue, Aug 22, 2017 at 1:00 PM, Jesse wrote: > Welcome again! > > > @purplecabbage > risingj.com > > On Tue, Aug 22, 2017 at 12:50 PM, Joe Bowser wrote: > > > Welcome

Re: I'm baaaaaack!

2017-08-22 Thread Kerri Shotts
John! Nice to see your name pop up in my inbox!!! Congrats on your position as well! Hope to meet you at PGDay! ~Kerri On Tue, Aug 22, 2017 at 17:30 Simon MacDonald wrote: > Welcome back John! Will you be in Raleigh for NCDevCon this year? > > Simon Mac Donald >

[GitHub] cordova-plugin-wkwebview-engine issue #42: CB-13205: Dynamic swipe back enab...

2017-08-22 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/42 Also, make sure that `npm run eslint` passes -- this is causing Travis CI to fail. --- If your project is set up for it, you can reply to this email and have your reply

Re: I'm baaaaaack!

2017-08-22 Thread Simon MacDonald
Welcome back John! Will you be in Raleigh for NCDevCon this year? Simon Mac Donald http://simonmacdonald.com On Tue, Aug 22, 2017 at 2:37 PM, John M. Wargo wrote: > Greetings Cordova Dev Team! > > Its been a while, so I thought I'd pop on the list and re-introduce myself. >

[GitHub] cordova-plugin-media issue #120: CB-11513: (ios) Fixed: iOS memory warning s...

2017-08-22 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/120 could this get merged? I have been maintaining a forked plugin for months with this PR merged and it works well. --- If your project is set up for it, you can reply to this email and