[GitHub] cordova-js issue #148: CB-13232: added test for cordova's unquie local style...

Github user filmaj commented on the issue: https://github.com/apache/cordova-js/pull/148 Ah, this test clarifies the style _so much better_. I know we've thrown the idea around to change this, but until we do, I think it may be worth documenting this. The README, in general,

[GitHub] cordova-coho pull request #157: Fixed/revised tools-release-process.md

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-js pull request #148: CB-13232: added test for cordova's unique loca...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] cordova-ios 4.1.1 Release

Stalled on testing and fixing https://github.com/apache/cordova-ios/pull/335 before a release can be sent for vote On Thu, Aug 24, 2017 at 4:12 PM, Shazron wrote: > Issues on the board have been completed, the PRs need review: > > Board: >

[GitHub] cordova-coho pull request #157: Fixed/revised tools-release-process.md

GitHub user audreyso opened a pull request: https://github.com/apache/cordova-coho/pull/157 Fixed/revised tools-release-process.md ### Platforms affected ### What does this PR do? Fixed/revised tools-release-process.md ### What testing has been

[GitHub] cordova-lib pull request #590: CB-13145: Create playservices version prefere...

Github user audreyso closed the pull request at: https://github.com/apache/cordova-lib/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer issue #187: CB-12809: Google Play Blocker: Unsa...

Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/187 I think we also want to remove the stuff from the README around how `trustAllHosts` is supported on Android. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-file-transfer pull request #187: CB-12809: Google Play Blocke...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: [DISCUSS] cordova-ios 4.1.1 Release

By the way, I think we should include notes about cordova-plugin-console being integrated in the blog post / announcement for this release - that may trip up folks trying to update cordova-ios, if they had the console plugin manually installed already. On Thu, Aug 31, 2017 at 7:21 PM, Shazron

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136490187 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136487019 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136487749 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136486774 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136490386 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136489451 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

[GitHub] cordova-lib pull request #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/584#discussion_r136488898 --- Diff: spec/cordova/plugin/save.spec.js --- @@ -54,15 +61,145 @@ describe('cordova/plugin/save', function () { }); });

Nightly build #471 for cordova has failed

Nightly build #471 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/471/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/471/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #584: CB-12361 : added tests for plugin/save.js

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/584 Make sure to run `npm run cover` to see the coverage report for save.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [Vote] Cordova-Common@2.1.0 Release

I vote +1 * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test and it passed * linked with cordova-lib and ran tests, passed On Wed, Aug 30, 2017 at 3:39 PM, Audrey So