[GitHub] cordova-plugin-statusbar pull request #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread BrainstemStudio
Github user BrainstemStudio closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/86 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread BrainstemStudio
Github user BrainstemStudio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/86 @mhartington Testing now, did not know about viewport-fit will let you know what my test reveal, if it is unnecessary will remove the property. ---

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread mhartington
Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/86 With `StatusBarCropsWebview`, does this override/breaks the expected behavior of `viewport-fit`? In my tested, most of the sizing/cropping settings can be fixed just by adding

[GitHub] cordova-plugin-statusbar pull request #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread BrainstemStudio
GitHub user BrainstemStudio opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/86 CB-13291: iOS 11 statusbar fixes 1. Added new property "StatusBarCropsWebview" to allow iPhone X to display edge to edge using the "safeAreaInsets" top and bottom. By

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread BrainstemStudio
Github user BrainstemStudio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/86 @mhartington You are correct. The viewport-fit=cover makes doe fix the problem without the need to add the new property. I am going to revise the issue and submit.

[GitHub] cordova-docs pull request #732: CB-13284: Slackin.js on docs fails to load d...

2017-09-17 Thread devgeeks
GitHub user devgeeks opened a pull request: https://github.com/apache/cordova-docs/pull/732 CB-13284: Slackin.js on docs fails to load due to insecure response ### Platforms affected Docs ### What does this PR do? Changed location of slackin.js

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

2017-09-17 Thread andreszs
Github user andreszs commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/239 Is this the same cache that caches all images as they are requested by the app? (not the images from an eventual webview control, I mean every single image downloaded and shown

[GitHub] cordova-docs pull request #731: CB-13283 Fetching of download counts fails o...

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/731 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion pull request #53: CB-12726: Device Motion - SUN...

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/53 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-docs pull request #732: CB-13284: Slackin.js on docs fails to load d...

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/732 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-motion issue #57: CB-13068: Updated README to point to...

2017-09-17 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-device-motion/pull/57 Merged this in, Added `info` tag. @maverickmishra can you close this issue? --- - To

[GitHub] cordova-plugin-device-orientation pull request #36: CB-12728: Device Orienta...

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/36 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-device-orientation pull request #39: CB-13076: Updated README

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/39 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

Nightly build #488 for cordova has failed

2017-09-17 Thread Apache Jenkins Server
Nightly build #488 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/488/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/488/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-plugin-device-motion pull request #57: CB-13068: Updated README to p...

2017-09-17 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r139333464 --- Diff: README.md --- @@ -27,6 +27,18 @@ description: Access accelerometer data. # cordova-plugin-device-motion

[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/728 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #730: CB-13277: (docs) Improve README

2017-09-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/730 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org