[DISCUSS] Mark cordova-windows 6.0.0-dev

2018-02-07 Thread Chris Brody
Hello team, I found out today that the cordova-windows master branch is now targeting 6.0.0 due to some breaking changes ref: http://markmail.org/ message/rzfa2zoydyjq6xso Can someone please mark this in the cordova-windows master branch? I think this could help avoid some possible forms of

Re: [DISCUSS] Mark cordova-windows 6.0.0-dev

2018-02-07 Thread Shazron
Do you mean a README update or something else? On Thu, Feb 8, 2018 at 10:59 AM, Chris Brody wrote: > Hello team, > > I found out today that the cordova-windows master branch is now targeting > 6.0.0 due to some breaking changes ref: http://markmail.org/ >

Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-07 Thread Jan Piotrowski
Ok, so #235 and #246 are merged into `master` and we are down to one failing test case https://issues.apache.org/jira/browse/CB-13834 The test is failing with Visual Studio 2017 and I can't reproduce locally, but it happens consistently on AppVeyor CI. If anyone here has some time, it would be

Fix crash on cordova-windows@5

2018-02-07 Thread Chris Brody
Hello team, Windows 8.1 (8.1-win) build crashes in cordova-windows@5.0.0 (CB-12784 & CB-13175). It took multiple attempts to fix this on the cordova-windows master branch which I thought would be released 1-2 weeks ago for 5.1.0. I discovered today that the master branch is now for

Nightly build #626 for cordova has succeeded!

2018-02-07 Thread Apache Jenkins Server
Nightly build #626 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/626/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] Mark cordova-windows 6.0.0-dev

2018-02-07 Thread Chris Brody
I meant something else. Change like the following commits: - https://github.com/apache/cordova-windows/commit/34d1335187ac21f21061c638fd54364fa3afb422 - https://github.com/apache/cordova-windows/commit/ece4d0ffe16a0962c3c5d51c2289582f3d3238c9 but change version / VERSION value to

Re: [DISCUSS] Mark cordova-windows 6.0.0-dev

2018-02-07 Thread Jesse
Hi Chris, Are you okay if we go ahead and pull in https://github.com/apache/ cordova-windows/pull/247 rebase those changes into master also, and do a 6.0.0 release ( leaving windows 8.1 support in ) ? @purplecabbage risingj.com On Wed, Feb 7, 2018 at 7:18 PM, Chris Brody