GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-lib/pull/259
Fix prepare to wait the promise from plugman prepare.
This fixes the issue where after_prepare hook is fired before the prepare
process ends.
You can merge this pull request into a Git
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34558047
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify
Github user giuseppelt commented on the pull request:
https://github.com/apache/cordova-lib/pull/259#issuecomment-121279489
I made the changes to use the promise.
I signed the icla and mailed to secretary at apache. Do I have to do
further actions?
---
If your project is set up
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/207
CB-12930: (windows) Fix getDirectory trailing slash path
### Platforms affected
Windows
### What does this PR do?
Fix the issue
### What
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-osx/pull/44
Added support for 1024x1024 app icon
### Platforms affected
osx
### What does this PR do?
Add support for 1024 icons
### What testing has been done on
Github user giuseppelt closed the pull request at:
https://github.com/apache/cordova-osx/pull/44
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-osx/pull/43#discussion_r145098266
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -199,8 +201,8 @@ Api.prototype.addPlugin = function (plugin,
installOptions
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-windows/pull/196
Fix setSplashBgColor exception when no splashscreen is found
WindowsPhone allows to unset splashscreen (img) to avoid it to be shown.
This patch fixes whenever the "splashs
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Schema is incorrect or old.
According to
https://msdn.microsoft.com/en-us/library/windows/apps/ff769511(v=vs.105).aspx
splashscreen isn't required nor it's provi
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
This patch doesn't touch nothing, nor alter the manifest.
It's just a logic check, because the previous code assumes the node is
always found.
The code simply is `if (no
Github user giuseppelt commented on the issue:
https://github.com/apache/cordova-windows/pull/196
Jira issue https://issues.apache.org/jira/browse/CB-12036 set as Minor.
But, please, don't delay because the missing feature. The issue is beyond
that, the code is wrong be
11 matches
Mail list logo
