Github user janpio closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/234
Did I miss anything or were there further, later changes that required
another rebase?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janpio closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/57#discussion_r132629591
--- Diff: README.md ---
@@ -27,6 +27,18 @@ description: Access accelerometer data.
# cordova-plugin-device-motion
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/82
README: Fix issue tracker link
wrong component name in search
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janpio/cordova
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Sure!
Well, if you tell me roughly how to do that. Some pointers would be nice,
never have done something like that. Can I actually do that on Github?
---
If your
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Yeah, I totally get that.
Can you actually post the `git` commands you would use? Then I can use this
as my googling starting point. Wanted to learn that for quite some
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/82
Good catch at the individual issue being linked - not intended.
As long as the PULL_REQUEST_TEMPLATE.md doesn't really work for README
changes (doesn't effect any platform
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/183
Remove broken headline and useless reference to it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janpio/cordova-plugin
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists
### Platforms affected
n/a, only docs changes
### What does this PR do?
Resort
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-docs/pull/714
CB-12984: (docs) Add Android versions to "supported" table in
cordova-android docs
### Platforms affected
n/a, docs only change
### What does this PR do?
I added the
Github user janpio commented on the issue:
https://github.com/apache/cordova-cli/pull/284
Changes seem useful. Did you open another PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user janpio closed the pull request at:
https://github.com/apache/cordova-docs/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/714
Sure, thanks for taking care of it!
How does deployment work, when will this be on
https://cordova.apache.org/docs/en/dev/guide/platforms/android/index.html?
---
If your project
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/714
(and document ð )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
As a first "recovery" I branched after my now rewritten commit into
patch-1b and created a pull request from there at #234. This seems to have
worked and alm
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Thanks for the proper explanation! I almost understood it and went to work
with Sourcetree...
https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/234
[WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open
`options` lists
This is a followup to #225 to test if I got it working. Do not merge yet
please
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Yeah no, I have no idea what actually happened and why and how I could undo
it :/
So if you @filmaj are ok with it, let's just go with #234.
---
If your project is set up
Github user janpio closed the pull request at:
https://github.com/apache/cordova-docs/pull/717
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/717
Thanks.
Missed the commit message, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user janpio commented on the issue:
https://github.com/apache/cordova-cli/pull/284
Ah right, I saw you on Crowdin ;)
Note that normally there is this process of opening a issue at
issues.cordova.io and including that in the title of the PR. You should
probably create
Github user janpio commented on the issue:
https://github.com/apache/cordova-cli/pull/284
Yes, there can be multiple PR for one issues, it is just that a place
exists where the changes are logged. But if Filmaj told you to just go ahead,
do that - he is with the project, I am just
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-docs/pull/717
CB-12760: (android) fix internal anchor link
### Platforms affected
Android, docs only
### What does this PR do?
fixes an internal anchor link to work
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/82
(I actually still had this tab open for a issue, rebase etc later - sorry
about that. But thanks for taking the initiative.)
---
If your project is set up for it, you can reply
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/714
(1 month bump ð° )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-docs/pull/720
remove duplicate information
version has its own entry, no need to duplicate the explanation here.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/722
See the line above your edit:
> You should use double `--` to indicate that these are platform-specific
arguments, for example:
---
If your project is set up for it, you can re
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/722#discussion_r134116008
--- Diff: www/docs/en/6.x/guide/platforms/android/index.md ---
@@ -310,7 +310,7 @@ To sign an app, you need the following parameters
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-docs/pull/730
CB-13277: (docs) Improve README
https://issues.apache.org/jira/browse/CB-13277
### Platforms affected
none
### What does this PR do?
Improves the README
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/239
No need to apologize, I was just curious what this does and if it would
make sense to actually have this in the plugin for all users, maybe behind a
configuration or option
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-weinre/pull/15#discussion_r144259287
--- Diff: README.md ---
@@ -17,7 +17,7 @@
* under the License.
-->
-weinre is WEb INspector REmote.
+weinre is Web INspec
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/723#discussion_r135991198
--- Diff: www/_posts/2017-08-29-browser-serve-release.md ---
@@ -0,0 +1,65 @@
+---
+layout: post
+author:
+name: Steve Gill
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136139240
--- Diff: src/windows/FileProxy.js ---
@@ -751,7 +751,13 @@ module.exports = {
if (!fs || !validName(path)){
fail
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/714
Ok, so back to your issue. Meh...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/727#discussion_r137936770
--- Diff: www/_posts/2017-09-08-ios-release.md ---
@@ -0,0 +1,72 @@
+---
+layout: post
+author:
+name: Shazron Abdullah
+url
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/727#discussion_r137936759
--- Diff: www/_posts/2017-09-08-ios-release.md ---
@@ -0,0 +1,72 @@
+---
+layout: post
+author:
+name: Shazron Abdullah
+url
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/727
Now that it's published I noticed that it would have been good to include
the CLI command to remove `cordova-plugin-console`: `cordova plugin rm
cordova-plugin-console
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/25
Nice.
Does this mean that the 2.0.0 of the console plugin can be installed on
`cordova-ios` 4.5.0 without causing the build problems
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/727#discussion_r137941937
--- Diff: www/_posts/2017-09-08-ios-release.md ---
@@ -0,0 +1,72 @@
+---
+layout: post
+author:
+name: Shazron Abdullah
+url
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/709
A bit late to the party, but where does this actually apply and work? (iOS,
Android, Windows?)
---
-
To unsubscribe, e-mail
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-coho/pull/159
CB-13279: Remove duplication of cordova-docs content from other places
remove blog post and cordova-docs build instructions
You can merge this pull request into a Git repository by running
GitHub user janpio opened a pull request:
https://github.com/apache/cordova-coho/pull/158
CB-13278: remove doc-translation-process.md
as its content was transferred to
https://github.com/apache/cordova-docs/blob/master/doc/translate.md via TODO
You can merge this pull request
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/238
@denisx304 Does this PR enable me to set random cookies for e.g. google.com
when opening InAppBrowser to open google.com?
---
If your project is set up for it, you can reply
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/51
The probability of merging pull requests are higher when they follow the
Pull Request template of the project:
https://github.com/apache/cordova-plugin-statusbar/blob/master/.github
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/238
You are right, this is equivalent to messing with the local cookies with
the developer tools of your browser.
---
If your project is set up for it, you can reply to this email
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/238
May I asked what is a use case for this? What problem does this solve?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user janpio commented on the issue:
https://github.com/apache/cordova-docs/pull/714
Is there a way to trigger this manualy rebuilding and uploading of the docs
by one of the PMC members?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/239
What exactly is AppCaching in this context?
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
Github user janpio commented on the issue:
https://github.com/apache/cordova-osx/pull/43
Yay, that was quick. Can you talk me (and everybody reading) through the
changes? Where does the logic come from? ios
50 matches
Mail list logo
