GitHub user ktop opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/124
CB-8727 Fix failing WebSQL test on Android 5.1
- scrollByLines is an unknown function in Android 5.1
- removed because it causes the exception and does not affect the test
itself
You
Github user ktop commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100264782
Can someone take a look at this? I think it should be a simple merge
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/214#issuecomment-101021261
I'll move the discussion to the right place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/214
CB-8978 Added new image element tag for config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktop/cordova-lib master
Alternatively you
Github user ktop closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ktop closed the pull request at:
https://github.com/apache/cordova-lib/pull/432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/449
CB-11023 Add edit-config functionality
New edit-config tag for plugin.xml will allow users to modify xml
attributes.
Ex. Assumes your AndroidManifest.xml has a second activity element
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/432
I'm gonna open a new pull request with new changes. Closing this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
ahh must be because I didn't set up my git config after my computer got
re-imaged. I have it set now and hopefully it will appear after I rebase.
---
If your project is set up for it, you can
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@riknoll
Where does it say "unknown"? I don't see it.
If we have plugin-1, plugin-2 --force, and then add plugin-3 with --force,
plugin-1 and plugin-2 should not be appli
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
My latest commit will find all conflicts when --force is used and remove
them before adding the new plugin. @riknoll or @macdonst can you try it out and
let me know if you have any issues
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
Cool, let me rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@riknoll I've rebased so this should be ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-docs/pull/614
CB-11023 New edit-config tag in plugin.xml
Documenting the new edit-config tag in plugin.xml.
@riknoll can you review? I tried to keep the examples short, but explain
enough to get
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/449
@riknoll yea sure. Are there instructions on how/where documentation goes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/379
CB-10235 Added clearer error message for info command
When using the cordova info command, if Android isn't set up properly, then
the error message printed out isn't too helpful. I added
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/380
CB-10553 Fix framework tag handler for Android
The framework tag was not being handled during plugin-install for Android.
In the conditional check, it checks for the string literal 'platform
Github user ktop closed the pull request at:
https://github.com/apache/cordova-lib/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/357#issuecomment-180583758
I will redo this pull request. I was having some repository problems so
I'll just start over.
---
If your project is set up for it, you can reply to this email
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-android/pull/283
CB-10897 Refactor URI Parsing for Whitelist
Fix for CB-10897.
I moved out the code that parses the 'origin' from the whitelist to a
separate function so that it can also be used
Github user ktop commented on the pull request:
https://github.com/apache/cordova-android/pull/283#issuecomment-201509250
@infil00p can you review again? see my previous comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/432
CB-11023 Add attribute through config-file tag
Add functionality to be able to add attributes to xml files through
config-file tag.
Syntax:
Able to add multiple attributes
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213530432
If we can modify existing attributes, and then the plugin gets removed, the
modified attribute will also get removed. I don't think there is a way to
revert it back
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823
@macdonst
I had Edna test the first time around before I opened the PR and she was
able to get it working, so that is weird that it is adding a new element
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220440531
@riknoll Vladimir is correct, there is no mechanism for either yet.
I think warnings are good, but does that mean the plugins that get
installed first get
Github user ktop commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/432#discussion_r63922339
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -116,6 +117,13 @@ function preparePlatforms (platformList, projectRoot,
options
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-220647997
I'd like to clear up some confusion I have on adding attributes.
Before, we had decided on going with this syntax where the child elements
of config-file tag
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216629805
@macdonst @purplecabbage
On my other machine (Mac), I see the same behavior that you both were
seeing. I was able to fix it by doing a `cordova-coho/coho npm-link
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-216543951
@purplecabbage
My workspace is working off of the master branches with the tools npm
linked.
I modified the plugin.xml of cordova-plugin-device
Github user ktop commented on the issue:
https://github.com/apache/cordova-docs/pull/614
@riknoll I've made the changes here and will open a PR in the CLI doc to
mention the plugin conflicts and link to the plugin.xml doc for reference.
---
If your project is set up for it, you can
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-cli/pull/258
CB-11023 Add doc for conflicting plugins
Added a section under plugins for dealing with plugin conflicts involving
the new edit-config tag. References the plugin.xml guide for more information
Github user ktop commented on the issue:
https://github.com/apache/cordova-docs/pull/614
I shortened the AndroidManifest to snippets.
I could see the force add content going into both locations, but in the CLI
guide it should be more describing the error about conflicting
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-docs/pull/679
CB-12163 Add doc for reference attr for resource-file in Windows
### Platforms affected
- Windows
- plugin.xml doc
### What does this PR do?
Adds documentation
Github user ktop commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@daserge
Now that there has been a cordova-common release, can we refresh
cordova-common in cordova-windows and get this merged?
---
If your project is set up for it, you can reply
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/214
Yep, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ktop closed the pull request at:
https://github.com/apache/cordova-lib/pull/214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ktop commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@daserge we need to wait for a cordova-common release since the commit I'm
dependent on has been merged https://github.com/apache/cordova-lib/pull/509
---
If your project is set up
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/492
CB-11908 Add edit-config to config.xml
Handles edit-config for config.xml.
Fixed up the conflict checking so that config.xml will take precedence over
plugin.xml changes.
Added
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/493
CB-11908 Handle edit-config in config.xml on prepare
Needs this PR: https://github.com/apache/cordova-lib/pull/492
You can merge this pull request into a Git repository by running:
$ git
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/486
CB-11776 check edit-config target exists
Missing a case in the conflict checking for edit-config. If the target
doesn't exist in .json, and cannot resolve to an existing target,
then no conflict
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/492
Thanks, I fixed the errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ktop commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@daserge Thanks for the bump, Tim's email was in my spam. Yes, this would
be a breaking change as it is now. We should wait until we come to a final
decision before proceeding with this pr
Github user ktop commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/213#discussion_r92438038
--- Diff: template/cordova/lib/PluginHandler.js ---
@@ -53,18 +53,37 @@ var handlers = {
},
'resource-file
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/509
CB-12163 Add reference attrib to resource-file for Windows
### Platforms affected
cordova-common for Windows
### What does this PR do?
Adds a new attribute
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/508
CB-11908 Add tests for edit-config in config.xml and fix typo
### Platforms affected
cordova-common
### What does this PR do?
I had this commit ready to go, but forgot
Github user ktop commented on the issue:
https://github.com/apache/cordova-lib/pull/468
SGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-windows/pull/213
CB-12163 Make resource-file copy files again
### Platforms affected
- Windows
### What does this PR do?
- Revert the functionality of resource-file in plugin.xml
Github user ktop commented on the issue:
https://github.com/apache/cordova-windows/pull/213
@vladimir-kotikov Can you review? This pr reverts resource-file to what it
used to do so it will copy files.
---
If your project is set up for it, you can reply to this email and have your
48 matches
Mail list logo
