[GitHub] cordova-lib pull request #:

2016-12-16 Thread yyfearth
Github user yyfearth commented on the pull request: https://github.com/apache/cordova-lib/commit/328980c2a91dada8049f1e4f27103df67ba07532#commitcomment-20221128 In cordova-lib/src/plugman/fetch.js: In cordova-lib/src/plugman/fetch.js on line 72: it will always trigger since

[GitHub] cordova-lib pull request #511: CB-12261: Fix subdirectories deprecated warni...

2016-12-16 Thread yyfearth
GitHub user yyfearth opened a pull request: https://github.com/apache/cordova-lib/pull/511 CB-12261: Fix subdirectories deprecated warning always shows and stop fetch for… ### Platforms affected All ### What does this PR do? Fix the issue created by CB-11979

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 I have create RP #511 CB-12261 to fix the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib issue #511: CB-12261: Fix subdirectories deprecated warning alwa...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/511 I think the CI has issue for the android sdk. Travis-CI got: `Failed to find 'ANDROID_HOME' environment variable. Try setting setting it manually. Failed to find 'android' command

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 This fix has issue now since ``` options.subdir = options.subdir || '.'; ... if (result[2]) options.subdir = result[2]; // not work if it is empty ... if(options.subdir