[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2017-05-10 Thread Ganster41
Github user Ganster41 commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 It's all ok, but why you declared it as required feature? In this way Google Play doesn't allow installing app with this plugin to devices without GPS. It can be fixed by adding

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-10-03 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 @mikepsinn it would be great to add a note in the readme! We will see how this change affects users. If lots of people complain over time, we may end up going the other

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-10-01 Thread mikepsinn
Github user mikepsinn commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 @stevengill Good points. Thanks for the explanation! Do you think I should add something to the "Android Quirks" section of the README warning people that their app won

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-09-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 @mikepsinn pretty sure. Currently, the geolocation plugin already adds the `ACCESS_FINE_LOCATION` permission. So assuming we aren't removing that, we need to add the "

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-09-28 Thread mikepsinn
Github user mikepsinn commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 @stevengill @asfgit @audreyso Just curios, are you sure we want to add this? According to Google, it will "ensure that Google Play only distributes your app to devic

[GitHub] cordova-plugin-geolocation issue #81: CB-11875 added android.hardware.locati...

2016-09-22 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/81 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-geolocation/pull/81/commits/01dd58f7a607917736e92a01345a06a