[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2017-01-02 Thread ephemer
Github user ephemer commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Let's merge #187! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-11-30 Thread jlchereau
Github user jlchereau commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 I have experienced the defect described here with oAuth flows but considering [Google deprecation of webviews for oAuth flows](https://developers.googleblog.com/2016/08/moderni

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 I like the implementation in #187 for the `show` method, what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 There is a google+ plugin https://github.com/EddyVerbruggen/cordova-plugin-googleplus BTW, I'm not saying that this shouldn't be merged, I'm saying that it shouldn'

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread dotNetkow
Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Thanks for sharing. Really good to know - someone needs to start building a "Google Sign-In" plugin! ;) Naturally, I disagree on this, what with an infinite amount of

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-29 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Starting in October 20th google won't allow to use WebViews (like inAppBrowser) for OAuth, so I think that's another reason to not change the behaviour of the plugin just to

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-08-28 Thread dotNetkow
Github user dotNetkow commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 hi @shazron - any way your team could consider this? OAuth is a major reason folks use InAppBrowser, and for years now it's been feasible and "supported" in a sense with UIWebV

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-06-30 Thread alesveselka
Github user alesveselka commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 Good job! So far only solution that fixed the problem for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.