[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-09 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron there is an issue https://issues.apache.org/jira/browse/CB-12542, and it has a PR already --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-09 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @jcesarmobile great! I'll link the issues and look at the diff and integrate it, and create a proper PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-09 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shanesmith Mind filing a new issue at issues.cordova.io so we can track this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-03-08 Thread shanesmith
Github user shanesmith commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This change has broken recording from what I'm seeing. The plugin requires the file to have a "wav" extension, however now that the audio is being encoded as

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-01-26 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron I just checked Jira and CB-11817 is the correct Jira issue for this issue --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2017-01-26 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Which JIRA issue is this really under? it's not the right one in the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-12-21 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is a really trivial fix could it please get merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-10-18 Thread ghenry22
Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron any chance this could get merged? It's a really small change that basically just fixes an oversight in the current version, which makes recording much more efficient and

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-09-21 Thread hounsellal
Github user hounsellal commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is very important. The file sizes are way smaller by this little change - I literally spent 2 days trying to compress the audio files with a lamejs library because they were so

[GitHub] cordova-plugin-media issue #116: CB-11817: (iOS) Fix unused recording settin...

2016-09-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Cordova CI Build has completed successfully. **Commit** -