[GitHub] cordova-plugin-screen-orientation pull request #4: Fixes JIRA bug CB-11628

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #4: Fixes JIRA bug CB-11628

[maverickmishra]

GitHub user maverickmishra opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/4

Fixes JIRA bug CB-11628



### Platforms affected
iOS, Android and Windows


### What does this PR do?
It uses one javascript file for iOS, Android and Windows

### What testing has been done on this change?
Tested on iOS, Android and Windows.


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/maverickmishra/cordova-plugin-screen-orientation master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit 2d8500f6a59f378473c846a86bc07935e8215ce1
Author: maverickmishra 
Date:   2016-08-29T21:33:03Z

 One js file for ios, android and windows

commit dd13eb5bdf7de9d766aba72416c9258b8f6c69a3
Author: maverickmishra 
Date:   2016-08-29T23:23:51Z

 add gitignore and npmignore files

commit 86a9c8131d7d40906a92b6cc2ff395112fdf7039
Author: maverickmishra 
Date:   2016-08-29T23:31:24Z

 removed .DS_Store files

commit c00a7c4b8546694b8fd96f119a2c845bc13e2c71
Author: maverickmishra 
Date:   2016-08-31T00:11:10Z

 changed orientation spec and modified Readme

commit f881c95e9a580d9bccf7ee531291afb0b1b4cac9
Author: maverickmishra 
Date:   2016-08-31T00:12:46Z

 basic tests added

commit 90f5f2531a6a354d8e8b889e707099b214d9e09d
Author: maverickmishra 
Date:   2016-09-20T17:36:36Z

 Added promises to plugin

commit 84b013f17c71922fa42bfd9185dbc9be3a1fe831
Author: maverickmishra 
Date:   2016-10-17T18:12:53Z

added comments and formatted code

commit 5d97d51144c5b1dad40b650e160e3ef8bde41a1b
Author: maverickmishra 
Date:   2016-10-17T23:25:16Z

 added demo project and modified version

commit 35f68c985e0daa3fc9704b08a1a145df2a93adc0
Author: maverickmishra 
Date:   2016-10-17T23:27:43Z

 modified Readme

commit f2f2dbde729b9d3ac5884de6ee80ae354a3bf5ef
Author: maverickmishra 
Date:   2016-10-17T23:29:20Z

 rectified Readme




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org