[GitHub] cordova-plugin-statusbar pull request #67: CB-12024: Browser platform suppor...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r113349852
  
--- Diff: README.md ---
@@ -73,6 +73,9 @@ if (cordova.platformId == 'android') {
 }
 ```
 
+### Browser Support
+Only a limited selection of browsers offer support for setting status bar 
colors.
--- End diff --

Can you expand on which browsers offer this support? I feel like that's 
valuable information for this documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #67: CB-12024: Browser platform suppor...

[filmaj]

Github user filmaj commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r113349809
  
--- Diff: README.md ---
@@ -73,6 +73,9 @@ if (cordova.platformId == 'android') {
 }
 ```
 
+### Browser Support
--- End diff --

May I suggest renaming this heading to "Browser Quirks", to align with the 
other section headings (i.e. "Android Quirks").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #67: CB-12024: Browser platform suppor...

[dudeofawesome]

GitHub user dudeofawesome opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/67

CB-12024: Browser platform support

The StatusBar plugin can support the Browser platform at least on Chrome 
for Android, and potentially on other browsers as well.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudeofawesome/cordova-plugin-statusbar 
CB-12024cordova-plugin-statusbar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit e312add9be30c29f588b6e4405d2211a632369c5
Author: Louis Orleans 
Date:   2016-10-15T23:30:52Z

Initial work to support browser platform

commit 78bafacd30bcb1ca818d300448883336d4b2d7f0
Author: Louis Orleans 
Date:   2016-10-15T23:43:33Z

Changing StyleLightContent color

commit a81826cba0114cadf1d4476633ba52288452af59
Author: Louis Orleans 
Date:   2016-10-15T23:46:30Z

Adding partial support for more browsers

commit 7b0f75b8ae79b36b0194370b6c35cf37f635031a
Author: Louis Orleans 
Date:   2016-10-16T01:12:56Z

Adding partial support for iOS Safari

Also, reorganizing code

commit 791f66625dfcb09a50bd12e70b0d0b47d931e99c
Author: Louis Orleans 
Date:   2016-10-16T01:31:09Z

Adding Browser platform to README




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org