[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321710879 nvm I see that I have access to your PR branch already :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321708176 Or you can check the "Allow Edits from Maintainers" checkbox on this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321707919 Please run `npm install && npm run eslint`, then fix the eslint issues and commit them. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477 ``` Parsing C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml failed { Error: ENOENT: no such file or directory, open 'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml' ``` Note that it is doubling up on the `ios-config-xml` in the path. I'll have to test in Windows to see what's up. Wait for Travis to finish testing to see if its a common error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
shazron commented on issue #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve? URL: https://github.com/apache/cordova-ios/pull/326#issuecomment-321110477 ``` Parsing C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml failed { Error: ENOENT: no such file or directory, open 'C:\projects\cordova-ios\tests\spec\unit\fixtures\ios-config-xml\ios-config-xml\SampleApp\config.xml' ``` Note that it is doubling up on the `ios-config-xml` in the path. I'll have to test in Windows to see what's up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org