Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-17 Thread Jesse
I used the latest on 2 machines, both were successful with commands build,
build -- --appx=8.1-win, build -- --appx=8.1-phone

Ship it!

===

Windows box 1
$ cordova requirements windows

Requirements check results for windows:
Windows OS: installed Windows 10
MSBuild Tools: installed 12.0
Visual Studio: installed 14.0
Windows SDK: installed 8.1
Windows Phone SDK: installed 8.1

Windows box 2
$ cordova requirements windows

Requirements check results for windows:
Windows OS: installed Windows 10
MSBuild Tools: installed 14.0
Visual Studio: installed 15.3
Windows SDK: installed 10.0
Windows Phone SDK: installed 10.0



@purplecabbage
risingj.com

On Fri, Feb 16, 2018 at 9:27 AM, Jan Piotrowski 
wrote:

> Current state of master is pretty stable now. It would be really
> helpful if you could help me test it.
>
> Run these two commands in a project that is already using cordova-windows:
>
>   cordova platform rm windows
>   cordova platform add https://github.com/apache/cordova-windows
>
> Use only the second line on existing projects without cordova-windows;
> or if you want to test in a new project these:
>
>   cordova create windowsMasterTest
>   cordova platform add https://github.com/apache/cordova-windows
>
> Then use `cordova build windows` to create a build or `cordova run
> windows` to build, install and run it directly.
>
> (As Windows10 is default in this version, add `-- --appx=8.1-win` or
> `-- --appx=8.1-phone` to the command if you want to build for Windows
> (Phone) 8.1)
>
> Let me know of any unexpected errors or output you are getting. (If
> something goes wrong, it would be helpful to include the output of
> `cordova requirements windows` for environment information).
> Also let me know if everything is fine of course - I actually prefer those
> ;)
>
> Thank you!
>
> Jan
>
> 2018-02-15 1:09 GMT+01:00 Jan Piotrowski :
> > Another update:
> >
> > - TargetPlatformVersion problem was solved by adding a `prepare` step
> > to the e2e tests
> > - `cordova requirements` is fixed for current setups
> > - VS2017 can not be used to build Win8.1 projects it seems (or did I
> > mess up?): https://issues.apache.org/jira/browse/CB-13874
> > - MSBuildTools selection is broken for current VS17 (15.5) and
> > different setups of it. Solution:
> > https://issues.apache.org/jira/browse/CB-13877 +
> > https://issues.apache.org/jira/browse/CB-13878
> > - That one specific test failure at AppVeyor is still being
> > investigated (no idea for now, maybe "just" an overlapping process
> > problem)
> >
> > But progress is made.
> >
> > J
> >
> > 2018-02-13 22:49 GMT+01:00 Terence M. Bandoian :
> >> There is also:
> >>
> >>
> >>
> >> It apparently has the same meaning as Windows.Universal-MinVersion but
> sets
> >> the value in the jsproj file vs the appxmanifest file.  Is there any
> reason
> >> a user would want different values in those two files?
> >>
> >> -Terence
> >>
> >>
> >>
> >> On 2/9/2018 7:01 PM, Terence M. Bandoian wrote:
> >>>
> >>> I'm not sure they're what you're looking for but there are three
> >>> version-related Windows preferences that seem to be supported in
> config.xml:
> >>>
> >>> 
> >>>  >>> value="10.0.14393.0" />
> >>>  >>> value="10.0.16299.125" />
> >>>
> >>> Does one or more of these resolve this?
> >>>
> >>> -Terence
> >>>
> >>>
> >>>
> >>> On 2/9/2018 6:41 PM, Jesse wrote:
> 
>  Created an issue for making this configurable. CB-13862
> 
> 
>  @purplecabbage
>  risingj.com
> 
>  On Fri, Feb 9, 2018 at 4:23 PM, Jesse 
> wrote:
> 
> > All correct and I agree, except we do need to update
> > TargetPlatformVersion
> > pr here: https://github.com/apache/cordova-windows/pull/250
> > Please test this pr on your windows machine and make sure you can
> create
> > and run a new cordova-windows project without having to modify the
> > jsproj
> > file manually.
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski  >
> > wrote:
> >
> >> Ok, so this version can be compared to the iOS or Android API
> version?
> >> Then it defintely makes sense to do some work to make this
> >> configurable in a better way in the future.
> >> Jesse, do you want to create the issue? You seem to have a specific
> >> idea already.
> >>
> >> To recap:
> >> - We think the test failure is a problem only happening on AppVeyor
> >> and should not affect actual users
> >> - We are ok with starting a 6.0.0 release with the current `master`
> >> state with this one failing test on AppVeyor
> >> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if
> we
> >> indeed find the solution
> >>
> >> Agree?
> >>
> >> If so, I will start the release process until Monday.
> >>
> 

Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-16 Thread Jan Piotrowski
Current state of master is pretty stable now. It would be really
helpful if you could help me test it.

Run these two commands in a project that is already using cordova-windows:

  cordova platform rm windows
  cordova platform add https://github.com/apache/cordova-windows

Use only the second line on existing projects without cordova-windows;
or if you want to test in a new project these:

  cordova create windowsMasterTest
  cordova platform add https://github.com/apache/cordova-windows

Then use `cordova build windows` to create a build or `cordova run
windows` to build, install and run it directly.

(As Windows10 is default in this version, add `-- --appx=8.1-win` or
`-- --appx=8.1-phone` to the command if you want to build for Windows
(Phone) 8.1)

Let me know of any unexpected errors or output you are getting. (If
something goes wrong, it would be helpful to include the output of
`cordova requirements windows` for environment information).
Also let me know if everything is fine of course - I actually prefer those ;)

Thank you!

Jan

2018-02-15 1:09 GMT+01:00 Jan Piotrowski :
> Another update:
>
> - TargetPlatformVersion problem was solved by adding a `prepare` step
> to the e2e tests
> - `cordova requirements` is fixed for current setups
> - VS2017 can not be used to build Win8.1 projects it seems (or did I
> mess up?): https://issues.apache.org/jira/browse/CB-13874
> - MSBuildTools selection is broken for current VS17 (15.5) and
> different setups of it. Solution:
> https://issues.apache.org/jira/browse/CB-13877 +
> https://issues.apache.org/jira/browse/CB-13878
> - That one specific test failure at AppVeyor is still being
> investigated (no idea for now, maybe "just" an overlapping process
> problem)
>
> But progress is made.
>
> J
>
> 2018-02-13 22:49 GMT+01:00 Terence M. Bandoian :
>> There is also:
>>
>>
>>
>> It apparently has the same meaning as Windows.Universal-MinVersion but sets
>> the value in the jsproj file vs the appxmanifest file.  Is there any reason
>> a user would want different values in those two files?
>>
>> -Terence
>>
>>
>>
>> On 2/9/2018 7:01 PM, Terence M. Bandoian wrote:
>>>
>>> I'm not sure they're what you're looking for but there are three
>>> version-related Windows preferences that seem to be supported in config.xml:
>>>
>>> 
>>> >> value="10.0.14393.0" />
>>> >> value="10.0.16299.125" />
>>>
>>> Does one or more of these resolve this?
>>>
>>> -Terence
>>>
>>>
>>>
>>> On 2/9/2018 6:41 PM, Jesse wrote:

 Created an issue for making this configurable. CB-13862


 @purplecabbage
 risingj.com

 On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:

> All correct and I agree, except we do need to update
> TargetPlatformVersion
> pr here: https://github.com/apache/cordova-windows/pull/250
> Please test this pr on your windows machine and make sure you can create
> and run a new cordova-windows project without having to modify the
> jsproj
> file manually.
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
> wrote:
>
>> Ok, so this version can be compared to the iOS or Android API version?
>> Then it defintely makes sense to do some work to make this
>> configurable in a better way in the future.
>> Jesse, do you want to create the issue? You seem to have a specific
>> idea already.
>>
>> To recap:
>> - We think the test failure is a problem only happening on AppVeyor
>> and should not affect actual users
>> - We are ok with starting a 6.0.0 release with the current `master`
>> state with this one failing test on AppVeyor
>> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
>> indeed find the solution
>>
>> Agree?
>>
>> If so, I will start the release process until Monday.
>>
>> J
>>
>> PS: I will contact AppVeyor to find out if they can maybe help -
>> blocked file, maybe because of some other running process?
>>
>>
>>
>>
>> 2018-02-09 23:13 GMT+01:00 Jesse :
>>>
>>> There is a list of the timeline for all relevant versions here:
>>> https://docs.microsoft.com/en-us/windows/uwp/updates-and-ver
>>
>> sions/choose-a-uwp-version
>>>
>>> There are 2 important values at play:
>>> Target Version : this should probably be the most recent release we
>>> support, probably 16299
>>> Minimum Version : this should be as far back as we can go ...
>>> probably 10586
>>>
>>> Ultimately we will need to add a method to configure these values via
>>> config.xml preferences, but I don't think we should wait for that to
>>
>> happen.
>>>
>>> Changing these values on my windows machine meant all the tests
>>> passed,
>>
>> 

Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-14 Thread Jan Piotrowski
Another update:

- TargetPlatformVersion problem was solved by adding a `prepare` step
to the e2e tests
- `cordova requirements` is fixed for current setups
- VS2017 can not be used to build Win8.1 projects it seems (or did I
mess up?): https://issues.apache.org/jira/browse/CB-13874
- MSBuildTools selection is broken for current VS17 (15.5) and
different setups of it. Solution:
https://issues.apache.org/jira/browse/CB-13877 +
https://issues.apache.org/jira/browse/CB-13878
- That one specific test failure at AppVeyor is still being
investigated (no idea for now, maybe "just" an overlapping process
problem)

But progress is made.

J

2018-02-13 22:49 GMT+01:00 Terence M. Bandoian :
> There is also:
>
>
>
> It apparently has the same meaning as Windows.Universal-MinVersion but sets
> the value in the jsproj file vs the appxmanifest file.  Is there any reason
> a user would want different values in those two files?
>
> -Terence
>
>
>
> On 2/9/2018 7:01 PM, Terence M. Bandoian wrote:
>>
>> I'm not sure they're what you're looking for but there are three
>> version-related Windows preferences that seem to be supported in config.xml:
>>
>> 
>> > value="10.0.14393.0" />
>> > value="10.0.16299.125" />
>>
>> Does one or more of these resolve this?
>>
>> -Terence
>>
>>
>>
>> On 2/9/2018 6:41 PM, Jesse wrote:
>>>
>>> Created an issue for making this configurable. CB-13862
>>>
>>>
>>> @purplecabbage
>>> risingj.com
>>>
>>> On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:
>>>
 All correct and I agree, except we do need to update
 TargetPlatformVersion
 pr here: https://github.com/apache/cordova-windows/pull/250
 Please test this pr on your windows machine and make sure you can create
 and run a new cordova-windows project without having to modify the
 jsproj
 file manually.


 @purplecabbage
 risingj.com

 On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
 wrote:

> Ok, so this version can be compared to the iOS or Android API version?
> Then it defintely makes sense to do some work to make this
> configurable in a better way in the future.
> Jesse, do you want to create the issue? You seem to have a specific
> idea already.
>
> To recap:
> - We think the test failure is a problem only happening on AppVeyor
> and should not affect actual users
> - We are ok with starting a 6.0.0 release with the current `master`
> state with this one failing test on AppVeyor
> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
> indeed find the solution
>
> Agree?
>
> If so, I will start the release process until Monday.
>
> J
>
> PS: I will contact AppVeyor to find out if they can maybe help -
> blocked file, maybe because of some other running process?
>
>
>
>
> 2018-02-09 23:13 GMT+01:00 Jesse :
>>
>> There is a list of the timeline for all relevant versions here:
>> https://docs.microsoft.com/en-us/windows/uwp/updates-and-ver
>
> sions/choose-a-uwp-version
>>
>> There are 2 important values at play:
>> Target Version : this should probably be the most recent release we
>> support, probably 16299
>> Minimum Version : this should be as far back as we can go ...
>> probably 10586
>>
>> Ultimately we will need to add a method to configure these values via
>> config.xml preferences, but I don't think we should wait for that to
>
> happen.
>>
>> Changing these values on my windows machine meant all the tests
>> passed,
>
> I
>>
>> had failing tests using master as-is.
>>
>> The failing test on appveyor is something different related to
>
> environment
>>
>> I believe.  Making these same changes that worked on my machine did
>> not
>
> fix
>>
>> the fail on appveyor.
>>
>> I think we should go ahead with the 6.0.0 release, and plan to do a
>
> patch
>>
>> release in the near future when we work out the details of a
>
> configurable
>>
>> target/minimum version.
>>
>>
>>
>>
>>
>> @purplecabbage
>> risingj.com
>>
>> On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody 
>
> wrote:
>>>
>>> On Feb 9, 2018 3:15 PM, "Jan Piotrowski" 
>>> wrote:
>>>
>>> Jesse, they do - but I am not sure why. Problem is I don't fully
>>> understand what is going on there... which is why I am hesitant to
>>> just ignore it.
>>>
>>>
>>>
>>> Makes sense to me
>>>
>>>
>>> Chris, where and how exactly does one install the "target platform
>
> SDK"?
>>>
>>>
>>>
>>> Visual Studio 2017 comes with an installer program. It is possible to
>>> 

Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-13 Thread Terence M. Bandoian

There is also:

   

It apparently has the same meaning as Windows.Universal-MinVersion but 
sets the value in the jsproj file vs the appxmanifest file.  Is there 
any reason a user would want different values in those two files?


-Terence


On 2/9/2018 7:01 PM, Terence M. Bandoian wrote:
I'm not sure they're what you're looking for but there are three 
version-related Windows preferences that seem to be supported in 
config.xml:



value="10.0.14393.0" />
value="10.0.16299.125" />


Does one or more of these resolve this?

-Terence



On 2/9/2018 6:41 PM, Jesse wrote:

Created an issue for making this configurable. CB-13862


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:

All correct and I agree, except we do need to update 
TargetPlatformVersion

pr here: https://github.com/apache/cordova-windows/pull/250
Please test this pr on your windows machine and make sure you can 
create
and run a new cordova-windows project without having to modify the 
jsproj

file manually.


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
wrote:


Ok, so this version can be compared to the iOS or Android API version?
Then it defintely makes sense to do some work to make this
configurable in a better way in the future.
Jesse, do you want to create the issue? You seem to have a specific
idea already.

To recap:
- We think the test failure is a problem only happening on AppVeyor
and should not affect actual users
- We are ok with starting a 6.0.0 release with the current `master`
state with this one failing test on AppVeyor
- We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
indeed find the solution

Agree?

If so, I will start the release process until Monday.

J

PS: I will contact AppVeyor to find out if they can maybe help -
blocked file, maybe because of some other running process?




2018-02-09 23:13 GMT+01:00 Jesse :

There is a list of the timeline for all relevant versions here:
https://docs.microsoft.com/en-us/windows/uwp/updates-and-ver

sions/choose-a-uwp-version

There are 2 important values at play:
Target Version : this should probably be the most recent release we
support, probably 16299
Minimum Version : this should be as far back as we can go ...
probably 10586

Ultimately we will need to add a method to configure these values via
config.xml preferences, but I don't think we should wait for that to

happen.
Changing these values on my windows machine meant all the tests 
passed,

I

had failing tests using master as-is.

The failing test on appveyor is something different related to

environment
I believe.  Making these same changes that worked on my machine 
did not

fix

the fail on appveyor.

I think we should go ahead with the 6.0.0 release, and plan to do a

patch

release in the near future when we work out the details of a

configurable

target/minimum version.





@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody 

wrote:
On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  
wrote:


Jesse, they do - but I am not sure why. Problem is I don't fully
understand what is going on there... which is why I am hesitant to
just ignore it.



Makes sense to me


Chris, where and how exactly does one install the "target platform

SDK"?



Visual Studio 2017 comes with an installer program. It is 
possible to
install an older platform SDK version but I do not want to do 
this on

my

PC.


What happens if you do not change the `TargetPlatformVersion` 
manually

but have only that one installed?



I would get an error message that the needed platform SDK version 
does

not

exist.


VS2017 did not exist at the time of the last release (or at least
nobody cared) so CI didn't use it to test.



Makes sense


This should have been added
earlier, but I only added it 3 weeks ago with
https://github.com/apache/cordova-windows/commit/
f5f4b21ad2c030ff61550bc947dca196c570f0ad
- which then showed this bug.



Good work on your part


(If any of the other failures that were
then fixes also were caused only by VS2017 I can not say
unfortunately)



It would be nice to investigate and test this, if anyone has the 
time

for

it.


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org







-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-12 Thread Jan Piotrowski
Testing for CB-13870 showed that is is not only `cordova requirements`
that is broken with a new installation of VS2017, but the whole build
process is wonky:
https://issues.apache.org/jira/browse/CB-13872

There is a workaround setting an env var VSINSTALLDIR, but that is undocumented:
https://forum.ionicframework.com/t/building-windows-10-app/92416/9

Lucky for us MS seems to be aware of the problem, so this exists:
https://github.com/Microsoft/vswhere
`%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -all
-requires Microsoft.Component.MSBuild -property installationPath`
returns the correct path we want to look for the build tools, so we
can probably use that.
I will have to rewrite the MSBuildTools.js a bit, but that isn't the
worst idea anyway as it evolved over time and also has strange
duplication.

J

2018-02-12 14:52 GMT+01:00 Jan Piotrowski :
> After some investigration I now understand the problem, see the update
> on CB-13870. I consider this a blocking bug for a release of 6.0.0 as
> `cordova requirements` functionality is broken with current tooling.
>
> Let's see if we can fix this...
>
> J
>
> 2018-02-12 13:42 GMT+01:00 Jan Piotrowski :
>> Well, during some more testing I noticed problems with `cordova 
>> requirements`:
>>
>>> λ cordova requirements
>>> Requirements check results for windows:
>>> Windows OS: not installed
>>> Error: Cannot read property 'os' of undefined
>>
>> The same is true for running `bin/check_reqs` directly which should do
>> the same/similar thing. After looking into that it seems like this way
>> to check the reqs is broken since a few years, so this is not a new
>> thing and won't hold up the release by itself, but I created two
>> issues about it: https://issues.apache.org/jira/browse/CB-13868
>> https://issues.apache.org/jira/browse/CB-13869
>>
>> Back to `cordova requirements`: This also seems to be a follow up
>> problem of the change of the default platform from `8.1` to `UAP` - in
>> this case the script knows nothing about "UAP" but only "10.0".
>> Further I then noticed that different checks (VS2017 and MSBuild) are
>> missing version numbers here - so this currently can not work with
>> current tooling.
>> Issue for this is here: https://issues.apache.org/jira/browse/CB-13870
>>
>> This will take some time :/
>>
>> J
>>
>> 2018-02-11 2:03 GMT+01:00 Chris Brody :
>>> On Fri, Feb 9, 2018 at 8:01 PM, Terence M. Bandoian 
>>> wrote:
>>>
 I'm not sure they're what you're looking for but there are three
 version-related Windows preferences that seem to be supported in 
 config.xml:

 
 >>> value="10.0.14393.0" />
 >>> value="10.0.16299.125" />

 Does one or more of these resolve this?
>>>
>>>
>>> Does not seem to work for me
>>>
>>>
>>> On 2/9/2018 6:41 PM, Jesse wrote:

> Created an issue for making this configurable. CB-13862
>

>>> +1
>>>
>>> On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:
>
> All correct and I agree, except we do need to update TargetPlatformVersion
>> pr here: https://github.com/apache/cordova-windows/pull/250
>> Please test this pr on your windows machine and make sure you can create
>> and run a new cordova-windows project without having to modify the jsproj
>> file manually.
>>
>
>>> +1. As I said in cordova-windows PR#250 it works for me on Visual Studio
>>> 2015 and Visual Studio 2017. Ship it!
>>>
>>>
>>>
 On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
>> wrote:
>>
>> To recap:
>>> - We think the test failure is a problem only happening on AppVeyor
>>> and should not affect actual users
>>> - We are ok with starting a 6.0.0 release with the current `master`
>>> state with this one failing test on AppVeyor
>>> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
>>> indeed find the solution
>>>
>>> Agree?
>>>
>>
>>> +1 agreed on my part
>>>
>>>
 If so, I will start the release process until Monday.
>>>
>>
>>> +100
>>>
>>>
 PS: I will contact AppVeyor to find out if they can maybe help -
>>> blocked file, maybe because of some other running process?
>>>
>>
>>> +1 thanks!

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-12 Thread Jan Piotrowski
After some investigration I now understand the problem, see the update
on CB-13870. I consider this a blocking bug for a release of 6.0.0 as
`cordova requirements` functionality is broken with current tooling.

Let's see if we can fix this...

J

2018-02-12 13:42 GMT+01:00 Jan Piotrowski :
> Well, during some more testing I noticed problems with `cordova requirements`:
>
>> λ cordova requirements
>> Requirements check results for windows:
>> Windows OS: not installed
>> Error: Cannot read property 'os' of undefined
>
> The same is true for running `bin/check_reqs` directly which should do
> the same/similar thing. After looking into that it seems like this way
> to check the reqs is broken since a few years, so this is not a new
> thing and won't hold up the release by itself, but I created two
> issues about it: https://issues.apache.org/jira/browse/CB-13868
> https://issues.apache.org/jira/browse/CB-13869
>
> Back to `cordova requirements`: This also seems to be a follow up
> problem of the change of the default platform from `8.1` to `UAP` - in
> this case the script knows nothing about "UAP" but only "10.0".
> Further I then noticed that different checks (VS2017 and MSBuild) are
> missing version numbers here - so this currently can not work with
> current tooling.
> Issue for this is here: https://issues.apache.org/jira/browse/CB-13870
>
> This will take some time :/
>
> J
>
> 2018-02-11 2:03 GMT+01:00 Chris Brody :
>> On Fri, Feb 9, 2018 at 8:01 PM, Terence M. Bandoian 
>> wrote:
>>
>>> I'm not sure they're what you're looking for but there are three
>>> version-related Windows preferences that seem to be supported in config.xml:
>>>
>>> 
>>> >> value="10.0.14393.0" />
>>> >> value="10.0.16299.125" />
>>>
>>> Does one or more of these resolve this?
>>
>>
>> Does not seem to work for me
>>
>>
>> On 2/9/2018 6:41 PM, Jesse wrote:
>>>
 Created an issue for making this configurable. CB-13862

>>>
>> +1
>>
>> On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:

 All correct and I agree, except we do need to update TargetPlatformVersion
> pr here: https://github.com/apache/cordova-windows/pull/250
> Please test this pr on your windows machine and make sure you can create
> and run a new cordova-windows project without having to modify the jsproj
> file manually.
>

>> +1. As I said in cordova-windows PR#250 it works for me on Visual Studio
>> 2015 and Visual Studio 2017. Ship it!
>>
>>
>>
>>> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
> wrote:
>
> To recap:
>> - We think the test failure is a problem only happening on AppVeyor
>> and should not affect actual users
>> - We are ok with starting a 6.0.0 release with the current `master`
>> state with this one failing test on AppVeyor
>> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
>> indeed find the solution
>>
>> Agree?
>>
>
>> +1 agreed on my part
>>
>>
>>> If so, I will start the release process until Monday.
>>
>
>> +100
>>
>>
>>> PS: I will contact AppVeyor to find out if they can maybe help -
>> blocked file, maybe because of some other running process?
>>
>
>> +1 thanks!

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-12 Thread Jan Piotrowski
Well, during some more testing I noticed problems with `cordova requirements`:

> λ cordova requirements
> Requirements check results for windows:
> Windows OS: not installed
> Error: Cannot read property 'os' of undefined

The same is true for running `bin/check_reqs` directly which should do
the same/similar thing. After looking into that it seems like this way
to check the reqs is broken since a few years, so this is not a new
thing and won't hold up the release by itself, but I created two
issues about it: https://issues.apache.org/jira/browse/CB-13868
https://issues.apache.org/jira/browse/CB-13869

Back to `cordova requirements`: This also seems to be a follow up
problem of the change of the default platform from `8.1` to `UAP` - in
this case the script knows nothing about "UAP" but only "10.0".
Further I then noticed that different checks (VS2017 and MSBuild) are
missing version numbers here - so this currently can not work with
current tooling.
Issue for this is here: https://issues.apache.org/jira/browse/CB-13870

This will take some time :/

J

2018-02-11 2:03 GMT+01:00 Chris Brody :
> On Fri, Feb 9, 2018 at 8:01 PM, Terence M. Bandoian 
> wrote:
>
>> I'm not sure they're what you're looking for but there are three
>> version-related Windows preferences that seem to be supported in config.xml:
>>
>> 
>> > value="10.0.14393.0" />
>> > value="10.0.16299.125" />
>>
>> Does one or more of these resolve this?
>
>
> Does not seem to work for me
>
>
> On 2/9/2018 6:41 PM, Jesse wrote:
>>
>>> Created an issue for making this configurable. CB-13862
>>>
>>
> +1
>
> On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:
>>>
>>> All correct and I agree, except we do need to update TargetPlatformVersion
 pr here: https://github.com/apache/cordova-windows/pull/250
 Please test this pr on your windows machine and make sure you can create
 and run a new cordova-windows project without having to modify the jsproj
 file manually.

>>>
> +1. As I said in cordova-windows PR#250 it works for me on Visual Studio
> 2015 and Visual Studio 2017. Ship it!
>
>
>
>> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
 wrote:

 To recap:
> - We think the test failure is a problem only happening on AppVeyor
> and should not affect actual users
> - We are ok with starting a 6.0.0 release with the current `master`
> state with this one failing test on AppVeyor
> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
> indeed find the solution
>
> Agree?
>

> +1 agreed on my part
>
>
>> If so, I will start the release process until Monday.
>

> +100
>
>
>> PS: I will contact AppVeyor to find out if they can maybe help -
> blocked file, maybe because of some other running process?
>

> +1 thanks!

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-10 Thread Chris Brody
On Fri, Feb 9, 2018 at 8:01 PM, Terence M. Bandoian 
wrote:

> I'm not sure they're what you're looking for but there are three
> version-related Windows preferences that seem to be supported in config.xml:
>
> 
>  value="10.0.14393.0" />
>  value="10.0.16299.125" />
>
> Does one or more of these resolve this?


Does not seem to work for me


On 2/9/2018 6:41 PM, Jesse wrote:
>
>> Created an issue for making this configurable. CB-13862
>>
>
+1

On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:
>>
>> All correct and I agree, except we do need to update TargetPlatformVersion
>>> pr here: https://github.com/apache/cordova-windows/pull/250
>>> Please test this pr on your windows machine and make sure you can create
>>> and run a new cordova-windows project without having to modify the jsproj
>>> file manually.
>>>
>>
+1. As I said in cordova-windows PR#250 it works for me on Visual Studio
2015 and Visual Studio 2017. Ship it!



> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
>>> wrote:
>>>
>>> To recap:
 - We think the test failure is a problem only happening on AppVeyor
 and should not affect actual users
 - We are ok with starting a 6.0.0 release with the current `master`
 state with this one failing test on AppVeyor
 - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
 indeed find the solution

 Agree?

>>>
+1 agreed on my part


> If so, I will start the release process until Monday.

>>>
+100


> PS: I will contact AppVeyor to find out if they can maybe help -
 blocked file, maybe because of some other running process?

>>>
+1 thanks!


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Terence M. Bandoian
I'm not sure they're what you're looking for but there are three 
version-related Windows preferences that seem to be supported in config.xml:



value="10.0.14393.0" />
value="10.0.16299.125" />


Does one or more of these resolve this?

-Terence



On 2/9/2018 6:41 PM, Jesse wrote:

Created an issue for making this configurable. CB-13862


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:


All correct and I agree, except we do need to update TargetPlatformVersion
pr here: https://github.com/apache/cordova-windows/pull/250
Please test this pr on your windows machine and make sure you can create
and run a new cordova-windows project without having to modify the jsproj
file manually.


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
wrote:


Ok, so this version can be compared to the iOS or Android API version?
Then it defintely makes sense to do some work to make this
configurable in a better way in the future.
Jesse, do you want to create the issue? You seem to have a specific
idea already.

To recap:
- We think the test failure is a problem only happening on AppVeyor
and should not affect actual users
- We are ok with starting a 6.0.0 release with the current `master`
state with this one failing test on AppVeyor
- We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
indeed find the solution

Agree?

If so, I will start the release process until Monday.

J

PS: I will contact AppVeyor to find out if they can maybe help -
blocked file, maybe because of some other running process?




2018-02-09 23:13 GMT+01:00 Jesse :

There is a list of the timeline for all relevant versions here:
https://docs.microsoft.com/en-us/windows/uwp/updates-and-ver

sions/choose-a-uwp-version

There are 2 important values at play:
Target Version : this should probably be the most recent release we
support, probably 16299
Minimum Version : this should be as far back as we can go ...
probably 10586

Ultimately we will need to add a method to configure these values via
config.xml preferences, but I don't think we should wait for that to

happen.

Changing these values on my windows machine meant all the tests passed,

I

had failing tests using master as-is.

The failing test on appveyor is something different related to

environment

I believe.  Making these same changes that worked on my machine did not

fix

the fail on appveyor.

I think we should go ahead with the 6.0.0 release, and plan to do a

patch

release in the near future when we work out the details of a

configurable

target/minimum version.





@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody 

wrote:

On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:

Jesse, they do - but I am not sure why. Problem is I don't fully
understand what is going on there... which is why I am hesitant to
just ignore it.



Makes sense to me


Chris, where and how exactly does one install the "target platform

SDK"?



Visual Studio 2017 comes with an installer program. It is possible to
install an older platform SDK version but I do not want to do this on

my

PC.


What happens if you do not change the `TargetPlatformVersion` manually
but have only that one installed?



I would get an error message that the needed platform SDK version does

not

exist.


VS2017 did not exist at the time of the last release (or at least
nobody cared) so CI didn't use it to test.



Makes sense


This should have been added
earlier, but I only added it 3 weeks ago with
https://github.com/apache/cordova-windows/commit/
f5f4b21ad2c030ff61550bc947dca196c570f0ad
- which then showed this bug.



Good work on your part


(If any of the other failures that were
then fixes also were caused only by VS2017 I can not say
unfortunately)



It would be nice to investigate and test this, if anyone has the time

for

it.


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jesse
Created an issue for making this configurable. CB-13862


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 4:23 PM, Jesse  wrote:

> All correct and I agree, except we do need to update TargetPlatformVersion
> pr here: https://github.com/apache/cordova-windows/pull/250
> Please test this pr on your windows machine and make sure you can create
> and run a new cordova-windows project without having to modify the jsproj
> file manually.
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski 
> wrote:
>
>> Ok, so this version can be compared to the iOS or Android API version?
>> Then it defintely makes sense to do some work to make this
>> configurable in a better way in the future.
>> Jesse, do you want to create the issue? You seem to have a specific
>> idea already.
>>
>> To recap:
>> - We think the test failure is a problem only happening on AppVeyor
>> and should not affect actual users
>> - We are ok with starting a 6.0.0 release with the current `master`
>> state with this one failing test on AppVeyor
>> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
>> indeed find the solution
>>
>> Agree?
>>
>> If so, I will start the release process until Monday.
>>
>> J
>>
>> PS: I will contact AppVeyor to find out if they can maybe help -
>> blocked file, maybe because of some other running process?
>>
>>
>>
>>
>> 2018-02-09 23:13 GMT+01:00 Jesse :
>> > There is a list of the timeline for all relevant versions here:
>> > https://docs.microsoft.com/en-us/windows/uwp/updates-and-ver
>> sions/choose-a-uwp-version
>> >
>> > There are 2 important values at play:
>> > Target Version : this should probably be the most recent release we
>> > support, probably 16299
>> > Minimum Version : this should be as far back as we can go ...
>> > probably 10586
>> >
>> > Ultimately we will need to add a method to configure these values via
>> > config.xml preferences, but I don't think we should wait for that to
>> happen.
>> >
>> > Changing these values on my windows machine meant all the tests passed,
>> I
>> > had failing tests using master as-is.
>> >
>> > The failing test on appveyor is something different related to
>> environment
>> > I believe.  Making these same changes that worked on my machine did not
>> fix
>> > the fail on appveyor.
>> >
>> > I think we should go ahead with the 6.0.0 release, and plan to do a
>> patch
>> > release in the near future when we work out the details of a
>> configurable
>> > target/minimum version.
>> >
>> >
>> >
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> > On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody 
>> wrote:
>> >
>> >> On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:
>> >>
>> >> Jesse, they do - but I am not sure why. Problem is I don't fully
>> >> understand what is going on there... which is why I am hesitant to
>> >> just ignore it.
>> >>
>> >>
>> >>
>> >> Makes sense to me
>> >>
>> >>
>> >> Chris, where and how exactly does one install the "target platform
>> SDK"?
>> >>
>> >>
>> >>
>> >> Visual Studio 2017 comes with an installer program. It is possible to
>> >> install an older platform SDK version but I do not want to do this on
>> my
>> >> PC.
>> >>
>> >>
>> >> What happens if you do not change the `TargetPlatformVersion` manually
>> >> but have only that one installed?
>> >>
>> >>
>> >>
>> >> I would get an error message that the needed platform SDK version does
>> not
>> >> exist.
>> >>
>> >>
>> >> VS2017 did not exist at the time of the last release (or at least
>> >> nobody cared) so CI didn't use it to test.
>> >>
>> >>
>> >>
>> >> Makes sense
>> >>
>> >>
>> >> This should have been added
>> >> earlier, but I only added it 3 weeks ago with
>> >> https://github.com/apache/cordova-windows/commit/
>> >> f5f4b21ad2c030ff61550bc947dca196c570f0ad
>> >> - which then showed this bug.
>> >>
>> >>
>> >>
>> >> Good work on your part
>> >>
>> >>
>> >> (If any of the other failures that were
>> >> then fixes also were caused only by VS2017 I can not say
>> >> unfortunately)
>> >>
>> >>
>> >>
>> >> It would be nice to investigate and test this, if anyone has the time
>> for
>> >> it.
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jesse
All correct and I agree, except we do need to update TargetPlatformVersion
pr here: https://github.com/apache/cordova-windows/pull/250
Please test this pr on your windows machine and make sure you can create
and run a new cordova-windows project without having to modify the jsproj
file manually.


@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski  wrote:

> Ok, so this version can be compared to the iOS or Android API version?
> Then it defintely makes sense to do some work to make this
> configurable in a better way in the future.
> Jesse, do you want to create the issue? You seem to have a specific
> idea already.
>
> To recap:
> - We think the test failure is a problem only happening on AppVeyor
> and should not affect actual users
> - We are ok with starting a 6.0.0 release with the current `master`
> state with this one failing test on AppVeyor
> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
> indeed find the solution
>
> Agree?
>
> If so, I will start the release process until Monday.
>
> J
>
> PS: I will contact AppVeyor to find out if they can maybe help -
> blocked file, maybe because of some other running process?
>
>
>
>
> 2018-02-09 23:13 GMT+01:00 Jesse :
> > There is a list of the timeline for all relevant versions here:
> > https://docs.microsoft.com/en-us/windows/uwp/updates-and-
> versions/choose-a-uwp-version
> >
> > There are 2 important values at play:
> > Target Version : this should probably be the most recent release we
> > support, probably 16299
> > Minimum Version : this should be as far back as we can go ...
> > probably 10586
> >
> > Ultimately we will need to add a method to configure these values via
> > config.xml preferences, but I don't think we should wait for that to
> happen.
> >
> > Changing these values on my windows machine meant all the tests passed, I
> > had failing tests using master as-is.
> >
> > The failing test on appveyor is something different related to
> environment
> > I believe.  Making these same changes that worked on my machine did not
> fix
> > the fail on appveyor.
> >
> > I think we should go ahead with the 6.0.0 release, and plan to do a patch
> > release in the near future when we work out the details of a configurable
> > target/minimum version.
> >
> >
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody 
> wrote:
> >
> >> On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:
> >>
> >> Jesse, they do - but I am not sure why. Problem is I don't fully
> >> understand what is going on there... which is why I am hesitant to
> >> just ignore it.
> >>
> >>
> >>
> >> Makes sense to me
> >>
> >>
> >> Chris, where and how exactly does one install the "target platform SDK"?
> >>
> >>
> >>
> >> Visual Studio 2017 comes with an installer program. It is possible to
> >> install an older platform SDK version but I do not want to do this on my
> >> PC.
> >>
> >>
> >> What happens if you do not change the `TargetPlatformVersion` manually
> >> but have only that one installed?
> >>
> >>
> >>
> >> I would get an error message that the needed platform SDK version does
> not
> >> exist.
> >>
> >>
> >> VS2017 did not exist at the time of the last release (or at least
> >> nobody cared) so CI didn't use it to test.
> >>
> >>
> >>
> >> Makes sense
> >>
> >>
> >> This should have been added
> >> earlier, but I only added it 3 weeks ago with
> >> https://github.com/apache/cordova-windows/commit/
> >> f5f4b21ad2c030ff61550bc947dca196c570f0ad
> >> - which then showed this bug.
> >>
> >>
> >>
> >> Good work on your part
> >>
> >>
> >> (If any of the other failures that were
> >> then fixes also were caused only by VS2017 I can not say
> >> unfortunately)
> >>
> >>
> >>
> >> It would be nice to investigate and test this, if anyone has the time
> for
> >> it.
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jan Piotrowski
Ok, so this version can be compared to the iOS or Android API version?
Then it defintely makes sense to do some work to make this
configurable in a better way in the future.
Jesse, do you want to create the issue? You seem to have a specific
idea already.

To recap:
- We think the test failure is a problem only happening on AppVeyor
and should not affect actual users
- We are ok with starting a 6.0.0 release with the current `master`
state with this one failing test on AppVeyor
- We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we
indeed find the solution

Agree?

If so, I will start the release process until Monday.

J

PS: I will contact AppVeyor to find out if they can maybe help -
blocked file, maybe because of some other running process?




2018-02-09 23:13 GMT+01:00 Jesse :
> There is a list of the timeline for all relevant versions here:
> https://docs.microsoft.com/en-us/windows/uwp/updates-and-versions/choose-a-uwp-version
>
> There are 2 important values at play:
> Target Version : this should probably be the most recent release we
> support, probably 16299
> Minimum Version : this should be as far back as we can go ...
> probably 10586
>
> Ultimately we will need to add a method to configure these values via
> config.xml preferences, but I don't think we should wait for that to happen.
>
> Changing these values on my windows machine meant all the tests passed, I
> had failing tests using master as-is.
>
> The failing test on appveyor is something different related to environment
> I believe.  Making these same changes that worked on my machine did not fix
> the fail on appveyor.
>
> I think we should go ahead with the 6.0.0 release, and plan to do a patch
> release in the near future when we work out the details of a configurable
> target/minimum version.
>
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody  wrote:
>
>> On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:
>>
>> Jesse, they do - but I am not sure why. Problem is I don't fully
>> understand what is going on there... which is why I am hesitant to
>> just ignore it.
>>
>>
>>
>> Makes sense to me
>>
>>
>> Chris, where and how exactly does one install the "target platform SDK"?
>>
>>
>>
>> Visual Studio 2017 comes with an installer program. It is possible to
>> install an older platform SDK version but I do not want to do this on my
>> PC.
>>
>>
>> What happens if you do not change the `TargetPlatformVersion` manually
>> but have only that one installed?
>>
>>
>>
>> I would get an error message that the needed platform SDK version does not
>> exist.
>>
>>
>> VS2017 did not exist at the time of the last release (or at least
>> nobody cared) so CI didn't use it to test.
>>
>>
>>
>> Makes sense
>>
>>
>> This should have been added
>> earlier, but I only added it 3 weeks ago with
>> https://github.com/apache/cordova-windows/commit/
>> f5f4b21ad2c030ff61550bc947dca196c570f0ad
>> - which then showed this bug.
>>
>>
>>
>> Good work on your part
>>
>>
>> (If any of the other failures that were
>> then fixes also were caused only by VS2017 I can not say
>> unfortunately)
>>
>>
>>
>> It would be nice to investigate and test this, if anyone has the time for
>> it.
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jesse
There is a list of the timeline for all relevant versions here:
https://docs.microsoft.com/en-us/windows/uwp/updates-and-versions/choose-a-uwp-version

There are 2 important values at play:
Target Version : this should probably be the most recent release we
support, probably 16299
Minimum Version : this should be as far back as we can go ...
probably 10586

Ultimately we will need to add a method to configure these values via
config.xml preferences, but I don't think we should wait for that to happen.

Changing these values on my windows machine meant all the tests passed, I
had failing tests using master as-is.

The failing test on appveyor is something different related to environment
I believe.  Making these same changes that worked on my machine did not fix
the fail on appveyor.

I think we should go ahead with the 6.0.0 release, and plan to do a patch
release in the near future when we work out the details of a configurable
target/minimum version.





@purplecabbage
risingj.com

On Fri, Feb 9, 2018 at 1:14 PM, Chris Brody  wrote:

> On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:
>
> Jesse, they do - but I am not sure why. Problem is I don't fully
> understand what is going on there... which is why I am hesitant to
> just ignore it.
>
>
>
> Makes sense to me
>
>
> Chris, where and how exactly does one install the "target platform SDK"?
>
>
>
> Visual Studio 2017 comes with an installer program. It is possible to
> install an older platform SDK version but I do not want to do this on my
> PC.
>
>
> What happens if you do not change the `TargetPlatformVersion` manually
> but have only that one installed?
>
>
>
> I would get an error message that the needed platform SDK version does not
> exist.
>
>
> VS2017 did not exist at the time of the last release (or at least
> nobody cared) so CI didn't use it to test.
>
>
>
> Makes sense
>
>
> This should have been added
> earlier, but I only added it 3 weeks ago with
> https://github.com/apache/cordova-windows/commit/
> f5f4b21ad2c030ff61550bc947dca196c570f0ad
> - which then showed this bug.
>
>
>
> Good work on your part
>
>
> (If any of the other failures that were
> then fixes also were caused only by VS2017 I can not say
> unfortunately)
>
>
>
> It would be nice to investigate and test this, if anyone has the time for
> it.
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Chris Brody
On Feb 9, 2018 3:15 PM, "Jan Piotrowski"  wrote:

Jesse, they do - but I am not sure why. Problem is I don't fully
understand what is going on there... which is why I am hesitant to
just ignore it.



Makes sense to me


Chris, where and how exactly does one install the "target platform SDK"?



Visual Studio 2017 comes with an installer program. It is possible to
install an older platform SDK version but I do not want to do this on my PC.


What happens if you do not change the `TargetPlatformVersion` manually
but have only that one installed?



I would get an error message that the needed platform SDK version does not
exist.


VS2017 did not exist at the time of the last release (or at least
nobody cared) so CI didn't use it to test.



Makes sense


This should have been added
earlier, but I only added it 3 weeks ago with
https://github.com/apache/cordova-windows/commit/
f5f4b21ad2c030ff61550bc947dca196c570f0ad
- which then showed this bug.



Good work on your part


(If any of the other failures that were
then fixes also were caused only by VS2017 I can not say
unfortunately)



It would be nice to investigate and test this, if anyone has the time for
it.


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jan Piotrowski
Jesse, they do - but I am not sure why. Problem is I don't fully
understand what is going on there... which is why I am hesitant to
just ignore it.

> The tests pass on my machine if I would change  to
10.0.15063.0 (I don't have the old target platform SDK installed with VS
2017 and don't intend to add it there)

Chris, where and how exactly does one install the "target platform SDK"?
What happens if you do not change the `TargetPlatformVersion` manually
but have only that one installed?

> It is though the AppVeyor tests that Jan
already discovered some fixes that were needed for VS 2017, if I am not
mistaken. @Jan can you explain this further or am I mistaken somehow?

VS2017 did not exist at the time of the last release (or at least
nobody cared) so CI didn't use it to test. This should have been added
earlier, but I only added it 3 weeks ago with
https://github.com/apache/cordova-windows/commit/f5f4b21ad2c030ff61550bc947dca196c570f0ad
- which then showed this bug. (If any of the other failures that were
then fixes also were caused only by VS2017 I can not say
unfortunately)

J

2018-02-09 17:24 GMT+01:00 Chris Brody :
> P.S. I would not favor making a major version release before resolving the
> CI issue on AppVeyor somehow. It is though the AppVeyor tests that Jan
> already discovered some fixes that were needed for VS 2017, if I am not
> mistaken. @Jan can you explain this further or am I mistaken somehow?
>
> On Fri, Feb 9, 2018 at 11:17 AM, Chris Brody  wrote:
>
>> The tests pass on my machine if I would change  to
>> 10.0.15063.0 (I don't have the old target platform SDK installed with VS
>> 2017 and don't intend to add it there)
>>
>> On Fri, Feb 9, 2018 at 11:12 AM, Jesse  wrote:
>>
>>> Do the tests pass on your machines? If so, I think we should move forward
>>> with the 6.0.0 release, and write this off as a CI environment issue.
>>>
>>> On Feb 9, 2018, at 7:45 AM, Jan Piotrowski  wrote:
>>>
>>> >> I wonder if we should also consider CB-12499 to be breaking,
>>> considering
>>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>>> >
>>> > No. "Breaking" (in context of semver) refers to changing existing
>>> > functionality to not work any more or work differently.
>>> > CB-12499 just seems "broken" right now.
>>> >
>>> > It introduces a new file and "link" to it in the Win10 project template:
>>> > https://github.com/apache/cordova-windows/pull/228/files And that file
>>> is
>>> > now causing issues with the test run with VS2017 on AppVeyor.
>>> >
>>> > We now just have to get the test working and pass or revert that change
>>> for
>>> > now because we can't get it to work properly.
>>> > (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2
>>> people
>>> > involved in merging that functionality, maybe they can say more about it
>>> > over there).
>>> >
>>> >> All tests are enabled now right?
>>> >> Or am I mistaken?
>>> >
>>> > Yes.
>>> > No.
>>> >
>>> > -J
>>> >
>>> >
>>> > 2018-02-09 15:36 GMT+01:00 Chris Brody :
>>> >
>>> >> I wonder if we should also consider CB-12499 to be breaking,
>>> considering
>>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>>> >>
>>> >> All tests are enabled now right? Or am I mistaken?
>>> >>
>>> >> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
>>> >> wrote:
>>> >>
>>> >>> All that change existing functionality a user could depend on.
>>> >>>
>>> >>> In this case:
>>> >>> https://issues.apache.org/jira/browse/CB-13237
>>> >>> Possibly also the ones disabling the tests (which happened before that
>>> >> one,
>>> >>> otherwise this would have been caught)
>>> >>>
>>> >>> J
>>> >>>
>>> >>> 2018-02-08 17:06 GMT+01:00 Chris Brody :
>>> >>>
>>>  Can someone explain exactly which changes in the master branch should
>>> >> be
>>>  considered "breaking"?
>>> 
>>> >>>
>>> >>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>>
>>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Chris Brody
P.S. I would not favor making a major version release before resolving the
CI issue on AppVeyor somehow. It is though the AppVeyor tests that Jan
already discovered some fixes that were needed for VS 2017, if I am not
mistaken. @Jan can you explain this further or am I mistaken somehow?

On Fri, Feb 9, 2018 at 11:17 AM, Chris Brody  wrote:

> The tests pass on my machine if I would change  to
> 10.0.15063.0 (I don't have the old target platform SDK installed with VS
> 2017 and don't intend to add it there)
>
> On Fri, Feb 9, 2018 at 11:12 AM, Jesse  wrote:
>
>> Do the tests pass on your machines? If so, I think we should move forward
>> with the 6.0.0 release, and write this off as a CI environment issue.
>>
>> On Feb 9, 2018, at 7:45 AM, Jan Piotrowski  wrote:
>>
>> >> I wonder if we should also consider CB-12499 to be breaking,
>> considering
>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>> >
>> > No. "Breaking" (in context of semver) refers to changing existing
>> > functionality to not work any more or work differently.
>> > CB-12499 just seems "broken" right now.
>> >
>> > It introduces a new file and "link" to it in the Win10 project template:
>> > https://github.com/apache/cordova-windows/pull/228/files And that file
>> is
>> > now causing issues with the test run with VS2017 on AppVeyor.
>> >
>> > We now just have to get the test working and pass or revert that change
>> for
>> > now because we can't get it to work properly.
>> > (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2
>> people
>> > involved in merging that functionality, maybe they can say more about it
>> > over there).
>> >
>> >> All tests are enabled now right?
>> >> Or am I mistaken?
>> >
>> > Yes.
>> > No.
>> >
>> > -J
>> >
>> >
>> > 2018-02-09 15:36 GMT+01:00 Chris Brody :
>> >
>> >> I wonder if we should also consider CB-12499 to be breaking,
>> considering
>> >> that Default.rd.xml triggers the test failure on AppVeyor.
>> >>
>> >> All tests are enabled now right? Or am I mistaken?
>> >>
>> >> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
>> >> wrote:
>> >>
>> >>> All that change existing functionality a user could depend on.
>> >>>
>> >>> In this case:
>> >>> https://issues.apache.org/jira/browse/CB-13237
>> >>> Possibly also the ones disabling the tests (which happened before that
>> >> one,
>> >>> otherwise this would have been caught)
>> >>>
>> >>> J
>> >>>
>> >>> 2018-02-08 17:06 GMT+01:00 Chris Brody :
>> >>>
>>  Can someone explain exactly which changes in the master branch should
>> >> be
>>  considered "breaking"?
>> 
>> >>>
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Chris Brody
The tests pass on my machine if I would change  to
10.0.15063.0 (I don't have the old target platform SDK installed with VS
2017 and don't intend to add it there)

On Fri, Feb 9, 2018 at 11:12 AM, Jesse  wrote:

> Do the tests pass on your machines? If so, I think we should move forward
> with the 6.0.0 release, and write this off as a CI environment issue.
>
> On Feb 9, 2018, at 7:45 AM, Jan Piotrowski  wrote:
>
> >> I wonder if we should also consider CB-12499 to be breaking, considering
> >> that Default.rd.xml triggers the test failure on AppVeyor.
> >
> > No. "Breaking" (in context of semver) refers to changing existing
> > functionality to not work any more or work differently.
> > CB-12499 just seems "broken" right now.
> >
> > It introduces a new file and "link" to it in the Win10 project template:
> > https://github.com/apache/cordova-windows/pull/228/files And that file
> is
> > now causing issues with the test run with VS2017 on AppVeyor.
> >
> > We now just have to get the test working and pass or revert that change
> for
> > now because we can't get it to work properly.
> > (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2
> people
> > involved in merging that functionality, maybe they can say more about it
> > over there).
> >
> >> All tests are enabled now right?
> >> Or am I mistaken?
> >
> > Yes.
> > No.
> >
> > -J
> >
> >
> > 2018-02-09 15:36 GMT+01:00 Chris Brody :
> >
> >> I wonder if we should also consider CB-12499 to be breaking, considering
> >> that Default.rd.xml triggers the test failure on AppVeyor.
> >>
> >> All tests are enabled now right? Or am I mistaken?
> >>
> >> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
> >> wrote:
> >>
> >>> All that change existing functionality a user could depend on.
> >>>
> >>> In this case:
> >>> https://issues.apache.org/jira/browse/CB-13237
> >>> Possibly also the ones disabling the tests (which happened before that
> >> one,
> >>> otherwise this would have been caught)
> >>>
> >>> J
> >>>
> >>> 2018-02-08 17:06 GMT+01:00 Chris Brody :
> >>>
>  Can someone explain exactly which changes in the master branch should
> >> be
>  considered "breaking"?
> 
> >>>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jesse
Do the tests pass on your machines? If so, I think we should move forward with 
the 6.0.0 release, and write this off as a CI environment issue. 

On Feb 9, 2018, at 7:45 AM, Jan Piotrowski  wrote:

>> I wonder if we should also consider CB-12499 to be breaking, considering
>> that Default.rd.xml triggers the test failure on AppVeyor.
> 
> No. "Breaking" (in context of semver) refers to changing existing
> functionality to not work any more or work differently.
> CB-12499 just seems "broken" right now.
> 
> It introduces a new file and "link" to it in the Win10 project template:
> https://github.com/apache/cordova-windows/pull/228/files And that file is
> now causing issues with the test run with VS2017 on AppVeyor.
> 
> We now just have to get the test working and pass or revert that change for
> now because we can't get it to work properly.
> (In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2 people
> involved in merging that functionality, maybe they can say more about it
> over there).
> 
>> All tests are enabled now right?
>> Or am I mistaken?
> 
> Yes.
> No.
> 
> -J
> 
> 
> 2018-02-09 15:36 GMT+01:00 Chris Brody :
> 
>> I wonder if we should also consider CB-12499 to be breaking, considering
>> that Default.rd.xml triggers the test failure on AppVeyor.
>> 
>> All tests are enabled now right? Or am I mistaken?
>> 
>> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
>> wrote:
>> 
>>> All that change existing functionality a user could depend on.
>>> 
>>> In this case:
>>> https://issues.apache.org/jira/browse/CB-13237
>>> Possibly also the ones disabling the tests (which happened before that
>> one,
>>> otherwise this would have been caught)
>>> 
>>> J
>>> 
>>> 2018-02-08 17:06 GMT+01:00 Chris Brody :
>>> 
 Can someone explain exactly which changes in the master branch should
>> be
 considered "breaking"?
 
>>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Jan Piotrowski
> I wonder if we should also consider CB-12499 to be breaking, considering
> that Default.rd.xml triggers the test failure on AppVeyor.

No. "Breaking" (in context of semver) refers to changing existing
functionality to not work any more or work differently.
CB-12499 just seems "broken" right now.

It introduces a new file and "link" to it in the Win10 project template:
https://github.com/apache/cordova-windows/pull/228/files And that file is
now causing issues with the test run with VS2017 on AppVeyor.

We now just have to get the test working and pass or revert that change for
now because we can't get it to work properly.
(In https://issues.apache.org/jira/browse/CB-13834 I mentioned the 2 people
involved in merging that functionality, maybe they can say more about it
over there).

> All tests are enabled now right?
> Or am I mistaken?

Yes.
No.

-J


2018-02-09 15:36 GMT+01:00 Chris Brody :

> I wonder if we should also consider CB-12499 to be breaking, considering
> that Default.rd.xml triggers the test failure on AppVeyor.
>
> All tests are enabled now right? Or am I mistaken?
>
> On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
> wrote:
>
> > All that change existing functionality a user could depend on.
> >
> > In this case:
> > https://issues.apache.org/jira/browse/CB-13237
> > Possibly also the ones disabling the tests (which happened before that
> one,
> > otherwise this would have been caught)
> >
> > J
> >
> > 2018-02-08 17:06 GMT+01:00 Chris Brody :
> >
> > > Can someone explain exactly which changes in the master branch should
> be
> > > considered "breaking"?
> > >
> >
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-09 Thread Chris Brody
I wonder if we should also consider CB-12499 to be breaking, considering
that Default.rd.xml triggers the test failure on AppVeyor.

All tests are enabled now right? Or am I mistaken?

On Thu, Feb 8, 2018 at 12:49 PM, Jan Piotrowski 
wrote:

> All that change existing functionality a user could depend on.
>
> In this case:
> https://issues.apache.org/jira/browse/CB-13237
> Possibly also the ones disabling the tests (which happened before that one,
> otherwise this would have been caught)
>
> J
>
> 2018-02-08 17:06 GMT+01:00 Chris Brody :
>
> > Can someone explain exactly which changes in the master branch should be
> > considered "breaking"?
> >
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-08 Thread Jan Piotrowski
All that change existing functionality a user could depend on.

In this case:
https://issues.apache.org/jira/browse/CB-13237
Possibly also the ones disabling the tests (which happened before that one,
otherwise this would have been caught)

J

2018-02-08 17:06 GMT+01:00 Chris Brody :

> Can someone explain exactly which changes in the master branch should be
> considered "breaking"?
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-08 Thread Chris Brody
Can someone explain exactly which changes in the master branch should be
considered "breaking"?


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-02-07 Thread Jan Piotrowski
Ok, so #235 and #246 are merged into `master` and we are down to one
failing test case https://issues.apache.org/jira/browse/CB-13834

The test is failing with Visual Studio 2017 and I can't reproduce locally,
but it happens consistently on AppVeyor CI.
If anyone here has some time, it would be really helpful if you could check
out `master` and see if you can reproduce.

(Test runs of last commit to master can be seen here:
https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.854)

Best,
Jan

2018-01-26 1:42 GMT+01:00 Jan Piotrowski :

> The failures in https://github.com/apache/cordova-windows/pull/235 are
> unrelated to that PR. Those are caused by the "Musts": If
> https://github.com/apache/cordova-windows/pull/246 gets merged this
> will be down to one, and the last one is
> https://issues.apache.org/jira/browse/CB-13834
>
> -J
>
> 2018-01-26 1:12 GMT+01:00 Jesse :
> > Yeah, I agree that dumping 8.1 completely would be a lot of work, let
> move
> > forward without that part.
> >
> > I think I agree with all your assessments!
> >
> > For the maybes:
> > I think CB-13817  is
> less
> > important, as it is something that even MS allows. They changed to call
> all
> > UAP => UWP but they still have docs that say UAP.
> > I would like to see https://github.com/apache/cordova-windows/pull/235
> make
> > it in, we'll need to look into the failures.
> >
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski 
> > wrote:
> >
> >> Hello.
> >>
> >> After we had to scrap release 5.1.0 because of an unexpected breaking
> >> change (and broken CI and failing tests), I took the time to work a
> >> bit on this and am now planning to go forward with a 6.0.0 release of
> >> cordova-windows soonish.
> >>
> >> Current status:
> >>
> >> Must
> >> - https://github.com/apache/cordova-windows/pull/246 (of
> >> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
> >> merged
> >> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
> >> fixed, reviewed and merged
> >>
> >> Maybe
> >> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
> >> everywhere we currently use "UAP" (which will be kept as an alias)
> >> - https://github.com/apache/cordova-windows/pull/235 should be
> >> reviewed and merged as it is a nice new feature for Windows
> >>
> >> After
> >> - Later https://github.com/apache/cordova-docs/pull/785 needs some
> >> more work so docs at least partially match reality when 6.0.0 will be
> >> released
> >>
> >> Am I missing anything?
> >>
> >> In the last release email Jesse suggested dropping 8.1 alltogether.
> >> After spending some time with the code this would a) be super nice as
> >> s much stuff could be deleted and removed but also b) pretty hard
> >> as it is all connected and interwoven. Won't be quick to do.
> >> More importantly I think we should use the release blog post to ask
> >> cordova-windows users if 8.1 is still needed for them and how they are
> >> using it in general so we get some input on how to proceed. (Some
> >> feedback from Microsoft wouldn't be the worst idea either) If no one
> >> uses it, we can do a clean 7.0.0 that removes it.
> >>
> >> Best,
> >> Jan
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>


Re: [DISCUSS] Cordova-Windows 6.0.0

2018-01-25 Thread Jan Piotrowski
The failures in https://github.com/apache/cordova-windows/pull/235 are
unrelated to that PR. Those are caused by the "Musts": If
https://github.com/apache/cordova-windows/pull/246 gets merged this
will be down to one, and the last one is
https://issues.apache.org/jira/browse/CB-13834

-J

2018-01-26 1:12 GMT+01:00 Jesse :
> Yeah, I agree that dumping 8.1 completely would be a lot of work, let move
> forward without that part.
>
> I think I agree with all your assessments!
>
> For the maybes:
> I think CB-13817  is less
> important, as it is something that even MS allows. They changed to call all
> UAP => UWP but they still have docs that say UAP.
> I would like to see https://github.com/apache/cordova-windows/pull/235 make
> it in, we'll need to look into the failures.
>
>
>
>
> @purplecabbage
> risingj.com
>
> On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski 
> wrote:
>
>> Hello.
>>
>> After we had to scrap release 5.1.0 because of an unexpected breaking
>> change (and broken CI and failing tests), I took the time to work a
>> bit on this and am now planning to go forward with a 6.0.0 release of
>> cordova-windows soonish.
>>
>> Current status:
>>
>> Must
>> - https://github.com/apache/cordova-windows/pull/246 (of
>> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
>> merged
>> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
>> fixed, reviewed and merged
>>
>> Maybe
>> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
>> everywhere we currently use "UAP" (which will be kept as an alias)
>> - https://github.com/apache/cordova-windows/pull/235 should be
>> reviewed and merged as it is a nice new feature for Windows
>>
>> After
>> - Later https://github.com/apache/cordova-docs/pull/785 needs some
>> more work so docs at least partially match reality when 6.0.0 will be
>> released
>>
>> Am I missing anything?
>>
>> In the last release email Jesse suggested dropping 8.1 alltogether.
>> After spending some time with the code this would a) be super nice as
>> s much stuff could be deleted and removed but also b) pretty hard
>> as it is all connected and interwoven. Won't be quick to do.
>> More importantly I think we should use the release blog post to ask
>> cordova-windows users if 8.1 is still needed for them and how they are
>> using it in general so we get some input on how to proceed. (Some
>> feedback from Microsoft wouldn't be the worst idea either) If no one
>> uses it, we can do a clean 7.0.0 that removes it.
>>
>> Best,
>> Jan
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: [DISCUSS] Cordova-Windows 6.0.0

2018-01-25 Thread Jesse
Yeah, I agree that dumping 8.1 completely would be a lot of work, let move
forward without that part.

I think I agree with all your assessments!

For the maybes:
I think CB-13817  is less
important, as it is something that even MS allows. They changed to call all
UAP => UWP but they still have docs that say UAP.
I would like to see https://github.com/apache/cordova-windows/pull/235 make
it in, we'll need to look into the failures.




@purplecabbage
risingj.com

On Thu, Jan 25, 2018 at 3:54 PM, Jan Piotrowski 
wrote:

> Hello.
>
> After we had to scrap release 5.1.0 because of an unexpected breaking
> change (and broken CI and failing tests), I took the time to work a
> bit on this and am now planning to go forward with a 6.0.0 release of
> cordova-windows soonish.
>
> Current status:
>
> Must
> - https://github.com/apache/cordova-windows/pull/246 (of
> https://issues.apache.org/jira/browse/CB-13829) has to be reviewed and
> merged
> - https://issues.apache.org/jira/browse/CB-13834 has to be analyzed,
> fixed, reviewed and merged
>
> Maybe
> - https://issues.apache.org/jira/browse/CB-13817 could implement "UWP"
> everywhere we currently use "UAP" (which will be kept as an alias)
> - https://github.com/apache/cordova-windows/pull/235 should be
> reviewed and merged as it is a nice new feature for Windows
>
> After
> - Later https://github.com/apache/cordova-docs/pull/785 needs some
> more work so docs at least partially match reality when 6.0.0 will be
> released
>
> Am I missing anything?
>
> In the last release email Jesse suggested dropping 8.1 alltogether.
> After spending some time with the code this would a) be super nice as
> s much stuff could be deleted and removed but also b) pretty hard
> as it is all connected and interwoven. Won't be quick to do.
> More importantly I think we should use the release blog post to ask
> cordova-windows users if 8.1 is still needed for them and how they are
> using it in general so we get some input on how to proceed. (Some
> feedback from Microsoft wouldn't be the worst idea either) If no one
> uses it, we can do a clean 7.0.0 that removes it.
>
> Best,
> Jan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>