[jira] [Commented] (RAT-246) .gitignore in parent dir not honored
[
https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358930#comment-16358930
]
Philipp Ottlinger commented on RAT-246:
---
Thanks for the example - there seems to be an issue with DotFiles.
Apart from that your project uses 0.11 in the regular build - the following
changes updated to a later release version and fixed the regular build.
{code}
✔ /tmp/maven-wagon [RAT-246|✚ 3]
21:40 $ gitd
diff --git a/.gitignore b/.gitignore
index b050d3a..7647c2e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,3 +15,4 @@ target
.java-version
.someignoredfile
+*.sh
diff --git a/pom.xml b/pom.xml
index 19cd18a..58aefe6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -357,6 +357,7 @@ under the License.
org.apache.rat
apache-rat-plugin
+ 0.12
**/*.odg
@@ -381,7 +382,7 @@ under the License.
org.apache.rat
apache-rat-plugin
-[0.11,)
+[0.12,)
check
diff --git a/rat-246.sh b/rat-246.sh
index b237c81..d365f52 100755
--- a/rat-246.sh
+++ b/rat-246.sh
@@ -13,4 +13,4 @@ if git add .someignoredfile 2>/dev/null; then
exit 1
fi
-mvn apache-rat:check
+mvn clean apache-rat:check
✔ /tmp/maven-wagon [RAT-246|✚ 3]
21:40 $
{code}
Your usecase is a .checkstyle file that is autogenerated by an IDE, right?
> .gitignore in parent dir not honored
>
>
> Key: RAT-246
> URL: https://issues.apache.org/jira/browse/RAT-246
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.12, 0.13
>Reporter: Ilya Basin
>Priority: Minor
>
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle
> file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores
> .checkstyle files, so I repeated my tests with a different filename.
> If a pattern is explicitly mentioned in the .gitignore in the project folder,
> RAT does not complain. However, if the pattern is only mentioned in a parent
> .gitignore, the RAT check fails.
> {code:java}
> [il@reallin wagon-scm]$ touch .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore
> [il@reallin wagon-scm]$ git add .someignoredfile
> The following paths are ignored by one of your .gitignore files:
> wagon-providers/wagon-scm/.someignoredfile
> Use -f if you really want to add them.
> fatal: no files added
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check
> (default-cli) on project wagon-scm: Too many files with unapproved license: 1
> See RAT report in: target/rat.txt -> [Help 1]
> [il@reallin wagon-scm]$ cat target/rat.txt
> Files with unapproved licenses:
> .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [INFO] BUILD SUCCESS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RAT-246) .gitignore in parent dir not honored
[
https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358360#comment-16358360
]
Ilya Basin commented on RAT-246:
g...@github.com:basinilya/maven-wagon.git , branch RAT-246
I added a shell script "rat-246.sh" to the root to demonstrate the problem.
I'm using the plugin version 0.13-SNAPSHOT, from the apache-snapshots maven
repo.
> .gitignore in parent dir not honored
>
>
> Key: RAT-246
> URL: https://issues.apache.org/jira/browse/RAT-246
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.12, 0.13
>Reporter: Ilya Basin
>Priority: Minor
>
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle
> file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores
> .checkstyle files, so I repeated my tests with a different filename.
> If a pattern is explicitly mentioned in the .gitignore in the project folder,
> RAT does not complain. However, if the pattern is only mentioned in a parent
> .gitignore, the RAT check fails.
> {code:java}
> [il@reallin wagon-scm]$ touch .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore
> [il@reallin wagon-scm]$ git add .someignoredfile
> The following paths are ignored by one of your .gitignore files:
> wagon-providers/wagon-scm/.someignoredfile
> Use -f if you really want to add them.
> fatal: no files added
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check
> (default-cli) on project wagon-scm: Too many files with unapproved license: 1
> See RAT report in: target/rat.txt -> [Help 1]
> [il@reallin wagon-scm]$ cat target/rat.txt
> Files with unapproved licenses:
> .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [INFO] BUILD SUCCESS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RAT-246) .gitignore in parent dir not honored
[
https://issues.apache.org/jira/browse/RAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16358235#comment-16358235
]
Philipp Ottlinger commented on RAT-246:
---
[~basinilya] not sure what you but
[https://github.com/ottlinger/creadur-rat-examples/tree/master/RAT-246] shows a
working example. Did you enable the SCM-configuration in your pom.xml?
> .gitignore in parent dir not honored
>
>
> Key: RAT-246
> URL: https://issues.apache.org/jira/browse/RAT-246
> Project: Apache Rat
> Issue Type: Bug
>Affects Versions: 0.12, 0.13
>Reporter: Ilya Basin
>Priority: Minor
>
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle
> file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores
> .checkstyle files, so I repeated my tests with a different filename.
> If a pattern is explicitly mentioned in the .gitignore in the project folder,
> RAT does not complain. However, if the pattern is only mentioned in a parent
> .gitignore, the RAT check fails.
> {code:java}
> [il@reallin wagon-scm]$ touch .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore
> [il@reallin wagon-scm]$ git add .someignoredfile
> The following paths are ignored by one of your .gitignore files:
> wagon-providers/wagon-scm/.someignoredfile
> Use -f if you really want to add them.
> fatal: no files added
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check
> (default-cli) on project wagon-scm: Too many files with unapproved license: 1
> See RAT report in: target/rat.txt -> [Help 1]
> [il@reallin wagon-scm]$ cat target/rat.txt
> Files with unapproved licenses:
> .someignoredfile
> [il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore
> [il@reallin wagon-scm]$ mvn apache-rat:check
> [INFO] BUILD SUCCESS
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
