RE: consequences of change to typesystem [EXTERNAL]

2018-04-06 Thread Mullane, Sean *HS
Sean -Original Message- From: Miller, Timothy [mailto:timothy.mil...@childrens.harvard.edu] Sent: Tuesday, April 03, 2018 4:54 PM To: dev@ctakes.apache.org Subject: Re: consequences of change to typesystem [EXTERNAL] Yes, that's right. Especially for one-off contributions, it

Re: consequences of change to typesystem [EXTERNAL]

2018-04-06 Thread Ewan Mellor
t branch. Ask for assistance testing the > branch and then merge the branch into trunk." > > Hope it makes sense. > > Regards, > Gandhi > > -Original Message- > From: Mullane, Sean *HS [mailto:sp...@hscmail.mcc.virginia.edu] > Sent: Tuesday, April 03, 20

Re: consequences of change to typesystem [EXTERNAL]

2018-04-03 Thread Miller, Timothy
f > ctakes and then commit your changes to that branch.  Ask for > assistance testing the branch and then merge the branch into trunk." > > Hope it makes sense. > > Regards, > Gandhi > > -----Original Message- > From: Mullane, Sean *HS [mailto:sp...@hscmail.mcc.virgin

RE: consequences of change to typesystem [EXTERNAL]

2018-04-03 Thread Gandhi Rajan Natarajan
du] Sent: Wednesday, March 28, 2018 6:54 PM To: 'Finan, Sean'; dev@ctakes.apache.org Subject: RE: consequences of change to typesystem [EXTERNAL] Sean, Glad I asked. I will try either what you suggested or the similar approach of adding some code to handle the bare-annotation-as

RE: consequences of change to typesystem [EXTERNAL]

2018-04-03 Thread Mullane, Sean *HS
PM To: 'Finan, Sean'; dev@ctakes.apache.org Subject: RE: consequences of change to typesystem [EXTERNAL] Sean, Glad I asked. I will try either what you suggested or the similar approach of adding some code to handle the bare-annotation-as-feature case similarly to how annotations insi

RE: consequences of change to typesystem [EXTERNAL]

2018-03-28 Thread Mullane, Sean *HS
...@childrens.harvard.edu] Sent: Wednesday, March 28, 2018 8:40 AM To: dev@ctakes.apache.org Subject: Re: consequences of change to typesystem [EXTERNAL] Hi Sean, In case nobody else has replied, Yes, this would definitely break a whole lot of things. I am not saying that it is a bad idea, just that the

Re: consequences of change to typesystem [EXTERNAL]

2018-03-28 Thread Finan, Sean
Hi Sean, In case nobody else has replied, Yes, this would definitely break a whole lot of things. I am not saying that it is a bad idea, just that the current BinaryTextRelation interface is used as-is in probably a thousand places, and while some refactoring might be trivial I wouldn't bet th