Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
Thanks alot @dragonsinth for going through this so carefully. I like your
additional simplifications, and sorry for the project style inconsistencies
that I missed!
I've pulled in your commi
Github user dragonsinth commented on the issue:
https://github.com/apache/curator/pull/250
@njhill this looks good to me with a few changes. I pushed one extra
commit onto https://github.com/apache/curator/tree/CURATOR-447 for you to look
at. If you agree with my changes (some of th
Github user dragonsinth commented on the issue:
https://github.com/apache/curator/pull/250
I'm sure this is probably right, but the old code has a _lot_ of miles on
it. I have to read through super carefully and convince myself that there are
no behavioral changes.
---
Github user dragonsinth commented on the issue:
https://github.com/apache/curator/pull/250
Sorry, been busy then out of town. I'll look tomorrow.
---
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth any interest in these changes? Maybe I should rename the PR
since as you pointed out the memory saving aspect isn't very significant (I
measured about 2% on a cache of 50k empty nodes),
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth I've removed the `outstandingOps` change commit from the PR,
and added a new commit which reverts the `TreeNode extends
AtomicReference` change. Hopefully that helps to make this more
p
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
Thanks @dragonsinth, there's of course no rush at all!
I agree that `TreeNode extends AtomicReference` isn't a "win" as such, it
just looked cleaner to me than using another `AtomicReferenceF
Github user dragonsinth commented on the issue:
https://github.com/apache/curator/pull/250
Hi @njhill just got back to work from vacation, and this is a little more
than I can just eyeball, I gotta think through it a bit when I have more time.
I think I would like to see the removal
Github user Randgalt commented on the issue:
https://github.com/apache/curator/pull/250
I'll defer to @dragonsinth
---
Github user njhill commented on the issue:
https://github.com/apache/curator/pull/250
@dragonsinth @Randgalt any interest in these updates? FWIW I've had them
running in production for some time.
---
10 matches
Mail list logo
