[jira] [Commented] (CURATOR-379) unfixForNamespace corrupts child path when it contains namespace

2017-01-13 Thread Jordan Zimmerman (JIRA)

[ 
https://issues.apache.org/jira/browse/CURATOR-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821829#comment-15821829
 ] 

Jordan Zimmerman commented on CURATOR-379:
--

I don't see how this issue can ever exhibit. The namespace is pre-pended going 
in and removed going out so it shouldn't matter. Do you have a test case that 
shows how this can happen? The current test case is a contrived call directly 
unfixForNamespace().

> unfixForNamespace corrupts child path when it contains namespace
> 
>
> Key: CURATOR-379
> URL: https://issues.apache.org/jira/browse/CURATOR-379
> Project: Apache Curator
>  Issue Type: Bug
>  Components: Framework
>Affects Versions: 2.11.1
>Reporter: Marvin Bredal Lillehaug
>Priority: Minor
>
> When a child path starts with the namespace unfixForNamespace removes the 
> namespace string, thus creating a invalid path.
> With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CURATOR-379) unfixForNamespace corrupts child path when it contains namespace

2017-01-11 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CURATOR-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817869#comment-15817869
 ] 

ASF GitHub Bot commented on CURATOR-379:


GitHub user computerlove opened a pull request:

https://github.com/apache/curator/pull/194

[CURATOR-379] unfixForNamespace corrupts child path when it contains 
namespace

When a child path starts with the namespace unfixForNamespace removes the 
namespace string, thus creating a invalid path.
With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/computerlove/curator CURATOR-379

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/curator/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #194


commit 635b0e4005a0a03848ab59c9363c54d743ec2953
Author: Marvin Bredal Lillehaug 
Date:   2017-01-11T10:00:01Z

CURATOR-379

commit 2b11a9614b501abd3344acaafc46231224c570fe
Author: Marvin Bredal Lillehaug 
Date:   2017-01-11T10:04:49Z

CURATOR-379




> unfixForNamespace corrupts child path when it contains namespace
> 
>
> Key: CURATOR-379
> URL: https://issues.apache.org/jira/browse/CURATOR-379
> Project: Apache Curator
>  Issue Type: Bug
>  Components: Framework
>Affects Versions: 2.11.1
>Reporter: Marvin Bredal Lillehaug
>Priority: Minor
>
> When a child path starts with the namespace unfixForNamespace removes the 
> namespace string, thus creating a invalid path.
> With namespace "foo" the result of unfixForNamespace("/foobar") is "bar".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)