Re: Pull Requests needing review

2017-01-16 Thread Jordan Zimmerman
I had huge hopes for Gradle. I was one of the first users of Gradle at Netflix. But, over time I realized that it’s just Ant with a Groovy wrapper. No thanks. -JZ > On Jan 16, 2017, at 3:19 PM, Scott Blum wrote: > > LOL. I definitely feel the love/hate from maven days.

Re: Pull Requests needing review

2017-01-16 Thread Scott Blum
LOL. I definitely feel the love/hate from maven days. I don't have a *conceptual* problem with Maven (except that I wish it were more geared towards storing versioned dependencies locally forever), it's the execution that's extremely poor. And extending its capabilities is a nightmare.

Re: Pull Requests needing review

2017-01-15 Thread Scott Blum
I glanced at the maven shade one, seemed okay. Maven is such a shit ball though that the rule of thumb is that of the output is right, it's right. Lol On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" wrote: > Thanks Cameron > > > On Jan 13, 2017, at 11:33 PM, Cameron

Re: Pull Requests needing review

2017-01-15 Thread Jordan Zimmerman
Thanks Cameron > On Jan 13, 2017, at 11:33 PM, Cameron McKenzie wrote: > > I've been looking at the CURATOR-99 PR, but it's going to take a while, > it's quite a large PR. > > The Maven shading one, I'm not going to be much use reviewing as my > knowledge of Maven is

Re: Pull Requests needing review

2017-01-13 Thread Cameron McKenzie
I've been looking at the CURATOR-99 PR, but it's going to take a while, it's quite a large PR. The Maven shading one, I'm not going to be much use reviewing as my knowledge of Maven is very limited. cheers On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: >

Pull Requests needing review

2017-01-13 Thread Jordan Zimmerman
Hello Folks, The following Pull Requests could really use review. If you have a moment it would be appreciated: [CURATOR-200] Shade Guava into Curator - https://github.com/apache/curator/pull/190 [CURATOR-99] Java 8 DSL for Curator -