coheigea commented on pull request #869:
URL: https://github.com/apache/cxf/pull/869#issuecomment-979280672
I think the test-case is valid, so please instead consider adding POST/PUT
as you suggested above.
--
This is an automated message from the Apache Git Service.
To respond to the me
jgallimore opened a new pull request #878:
URL: https://github.com/apache/cxf/pull/878
…rameters are read from HttpServletRequest.getParameter()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reta commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757191549
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
##
@@ -1153,6 +1153,17 @@ private static Object processFormParam(Message
reta commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757199139
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/FormUtils.java
##
@@ -175,8 +176,20 @@ public static void
populateMapFromString(Multival
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-979650037
Thank you for the contribution, @jgallimore, I have the concerns regarding
this change, looking into the issue in order to understand the decoding flaws.
--
This is an automated messag
jgallimore commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757522380
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java
##
@@ -1153,6 +1153,17 @@ private static Object processFormParam(Me
jgallimore commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757524512
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/FormUtils.java
##
@@ -175,8 +176,20 @@ public static void
populateMapFromString(Mu
jgallimore commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-980006717
Thank you so much for the very quick review, @reta. I'm very happy to work
with you and the team to come to the right solution on this. Please feel free
to nudge me in the right di
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-980008632
Thanks @jgallimore
> On thing I am wondering is whether the systest does a good job of
highlighting the issue. I can certainly add some tests with an embedded Tomcat
if that is u
rmannibucau commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757542186
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/FormUtils.java
##
@@ -175,8 +176,20 @@ public static void
populateMapFromString(M
reta commented on a change in pull request #878:
URL: https://github.com/apache/cxf/pull/878#discussion_r757553221
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/FormUtils.java
##
@@ -175,8 +176,20 @@ public static void
populateMapFromString(Multival
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-980800406
@jgallimore I think I understood the problem and I have a very simple
solution to suggest, would you mind if I push the changes to your PR so you
could take a look and provide the feedba
jgallimore commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-981129525
@reta Yes please, that would be fantastic, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-981139939
@jgallimore done, please let me know what do you think, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jgallimore commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-981564396
Thanks @reta - this looks good to me, I'm not seeing a double decode happen
for this case anymore. Do we want to try and figure out a way to enable
@Encoded endpoints where we're r
AnilKumarHurkadli commented on pull request #869:
URL: https://github.com/apache/cxf/pull/869#issuecomment-981875635
> I think the test-case is valid, so please instead consider adding POST/PUT
as you suggested above.
@coheigea @reta I have fixed the test case failure that was happen
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-981960210
@jgallimore thank you
> Do we want to try and figure out a way to enable @encoded endpoints where
we're reading from the HTTP parameter map?
At least for me, the uncertaint
coheigea merged pull request #869:
URL: https://github.com/apache/cxf/pull/869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf
jgallimore commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-982450069
From my perspective, I'd keep the PR as-is. If there's a need for the
original encoded data, then its best to not consume the InputStream - instead
leave it alone for CXF to parse.
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-982653238
@jgallimore thank you, sounds reasonable
> Is this good to merge in, or does it need anything else? I'm very happy to
help in any way.
I would like to run JAX-RS TCK tests o
reta edited a comment on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-982653238
@jgallimore thank you, sounds reasonable
> Is this good to merge in, or does it need anything else? I'm very happy to
help in any way.
I would like to run JAX-RS TCK
reta opened a new pull request #879:
URL: https://github.com/apache/cxf/pull/879
A number of JAX-RS TCK of tests use HTTP TRACE to verify the client / server
behavior, but TRACE HTTP method dispatching is not supported by
AbstractHTTPServlet, causing tests do not fail.
--
This is an
reta commented on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-983231657
@jgallimore just finished the TCK run, no new test case failure, I think we
are good to go once build checks are done, thank you!
--
This is an automated message from the Apache Git Se
reta edited a comment on pull request #878:
URL: https://github.com/apache/cxf/pull/878#issuecomment-983231657
@jgallimore just finished the JAX-RS TCK run, no new test case failures, I
think we are good to go once build checks are done, thank you!
--
This is an automated message from th
amarkevich opened a new pull request #880:
URL: https://github.com/apache/cxf/pull/880
lightweight healthcheck endpoint using HTTP HEAD method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reta commented on pull request #879:
URL: https://github.com/apache/cxf/pull/879#issuecomment-983822431
@ffang mind please taking a look? Just run the JAX-RS TCKs, with this change
we shaved off 20 test failures:
```
[javatest.batch] Test results: passed: 2,630; failed: 33 (-> 53
reta merged pull request #878:
URL: https://github.com/apache/cxf/pull/878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
amarkevich merged pull request #880:
URL: https://github.com/apache/cxf/pull/880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@c
reta merged pull request #879:
URL: https://github.com/apache/cxf/pull/879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #881:
URL: https://github.com/apache/cxf/pull/881
Fixing jaxrs.spec.provider.standardnotnull clientDataSourceProviderTest
Before:
```
Tests that passed: 2630
Tests that failed: 33
Total: 2663
```
| keyword
reta opened a new pull request #882:
URL: https://github.com/apache/cxf/pull/882
Minor wiremock and mockwebserver dependency updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
reta merged pull request #881:
URL: https://github.com/apache/cxf/pull/881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta merged pull request #882:
URL: https://github.com/apache/cxf/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #883:
URL: https://github.com/apache/cxf/pull/883
Update maven-javadoc-plugin to 3.3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
reta merged pull request #883:
URL: https://github.com/apache/cxf/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #884:
URL: https://github.com/apache/cxf/pull/884
Update Netty to 4.1.72.Final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reta commented on a change in pull request #884:
URL: https://github.com/apache/cxf/pull/884#discussion_r768209154
##
File path: osgi/karaf/features/src/main/resources/features.xml
##
@@ -192,6 +192,7 @@
cxf-http
mvn:${cxf.servlet-api.group}/${cxf.servle
reta commented on pull request #884:
URL: https://github.com/apache/cxf/pull/884#issuecomment-993015267
@ffang would you mind please taking a look, the change is trivial but new
dependency has been introduced by Netty
(https://github.com/netty/netty/pull/11745) and led to OSGi features upd
ffang commented on a change in pull request #884:
URL: https://github.com/apache/cxf/pull/884#discussion_r769054417
##
File path: osgi/karaf/features/src/main/resources/features.xml
##
@@ -192,6 +192,7 @@
cxf-http
mvn:${cxf.servlet-api.group}/${cxf.servl
reta merged pull request #884:
URL: https://github.com/apache/cxf/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta commented on pull request #863:
URL: https://github.com/apache/cxf/pull/863#issuecomment-996320565
Closing, fixed by
https://github.com/apache/cxf/commit/da1fece268c806a8d03cc204135492e99a5690af#diff-dc147309c94b363cda1a07590a2f5cdba75c81da7f509b182a11dec6f7ca8e65
--
This is an auto
reta closed pull request #863:
URL: https://github.com/apache/cxf/pull/863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #885:
URL: https://github.com/apache/cxf/pull/885
Right now there is one module which uses `mockwebserver` for test
scaffolding, this is not really necessary since we already have `wiremock`
dependency in place. One or another should be used, although `wiremo
reta commented on pull request #885:
URL: https://github.com/apache/cxf/pull/885#issuecomment-997138551
@andymc12 if you don't mind taking a quick look, trying to reduce the amount
of competing test dependencies, thank you
--
This is an automated message from the Apache Git Service.
To
reta opened a new pull request #886:
URL: https://github.com/apache/cxf/pull/886
Update Swagger to 1.6.4 and 2.1.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
reta merged pull request #886:
URL: https://github.com/apache/cxf/pull/886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #887:
URL: https://github.com/apache/cxf/pull/887
StaxTransformFeature deep-dropping doesn't work with any element
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
reta commented on pull request #887:
URL: https://github.com/apache/cxf/pull/887#issuecomment-1000907663
@coheigea @ffang @dkulp guys not sure who is familiar with this code, but
would really appreciate if someone glances through, essentially fixing endless
loop, thank you!
--
This is a
hypervisorfdi commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775178308
##
File path:
core/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
##
@@ -262,12 +262,22 @@ private void handleDefaultMode(QName
reta commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775185383
##
File path:
core/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
##
@@ -262,12 +262,22 @@ private void handleDefaultMode(QName name, QNa
hypervisorfdi commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775216735
##
File path:
core/src/test/java/org/apache/cxf/staxutils/transform/InTransformReaderTest.java
##
@@ -69,6 +69,116 @@ public void testReplaceSimpleElemen
hypervisorfdi commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775216802
##
File path:
core/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
##
@@ -261,13 +261,22 @@ private void handleDefaultMode(QName
reta commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775245355
##
File path:
core/src/test/java/org/apache/cxf/staxutils/transform/InTransformReaderTest.java
##
@@ -69,6 +69,116 @@ public void testReplaceSimpleElement() throw
reta commented on a change in pull request #887:
URL: https://github.com/apache/cxf/pull/887#discussion_r775245477
##
File path:
core/src/main/java/org/apache/cxf/staxutils/transform/InTransformReader.java
##
@@ -261,13 +261,22 @@ private void handleDefaultMode(QName name, QNa
reta opened a new pull request #888:
URL: https://github.com/apache/cxf/pull/888
Jakarta EE Platform 9.1 specs (used by CXF and integrations):
- Jakarta Activation 2.0
- Jakarta Annotations 2.0
- Jakarta Bean Validation 3.0
- Jakarta Connectors 2.0
- Jakarta Contexts and
reta opened a new pull request #889:
URL: https://github.com/apache/cxf/pull/889
The regression introduced by
[CXF-8633](https://issues.apache.org/jira/browse/CXF-8633) causes intermittent
tests failures wirh `ConcurrentModificationException`:
```
Caused by: java.util.Concurrent
reta commented on a change in pull request #889:
URL: https://github.com/apache/cxf/pull/889#discussion_r776109741
##
File path:
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/AbstractClient.java
##
@@ -440,8 +440,7 @@ protected ResponseBuilder setResponseBuilder(Messa
reta opened a new pull request #890:
URL: https://github.com/apache/cxf/pull/890
Update Apache Openwebbeans to 2.0.25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
reta merged pull request #890:
URL: https://github.com/apache/cxf/pull/890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #10:
URL: https://github.com/apache/cxf-xjc-utils/pull/10
The `xjc-utils` use the `javax` artifacts for code generation, it would make
sense to branch off `4.0.0` (master) to support Jakarka artifacts and align
with CXF plans to support Jakarta as well.
reta merged pull request #10:
URL: https://github.com/apache/cxf-xjc-utils/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
reta merged pull request #885:
URL: https://github.com/apache/cxf/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #11:
URL: https://github.com/apache/cxf-xjc-utils/pull/11
Interesting regression has been observed with JAXB 2.3.5 and 3.x: the CXF
builds are failing with :
```
[ERROR] rt\wsdl\src\test\resources\schemas\wsdl\test-conf.xjb [25:88]:
"http://sch
reta merged pull request #887:
URL: https://github.com/apache/cxf/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta merged pull request #11:
URL: https://github.com/apache/cxf-xjc-utils/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
reta opened a new pull request #891:
URL: https://github.com/apache/cxf/pull/891
Update Apache HttpClient 4.x and 5.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
reta merged pull request #891:
URL: https://github.com/apache/cxf/pull/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta merged pull request #889:
URL: https://github.com/apache/cxf/pull/889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
globalbus opened a new pull request #892:
URL: https://github.com/apache/cxf/pull/892
NPE on NamePasswordCallbackHandler
https://issues.apache.org/jira/projects/CXF/issues/CXF-8641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ffang merged pull request #892:
URL: https://github.com/apache/cxf/pull/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.ap
reta opened a new pull request #893:
URL: https://github.com/apache/cxf/pull/893
`ResponseImpl#hasEntity` returns 'false' when entity is buffered but entity
stream is fully consumed with processing exception.
--
This is an automated message from the Apache Git Service.
To respond to the
reta commented on a change in pull request #893:
URL: https://github.com/apache/cxf/pull/893#discussion_r787300871
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java
##
@@ -152,6 +152,9 @@ public boolean hasEntity() {
Object actu
coheigea opened a new pull request #894:
URL: https://github.com/apache/cxf/pull/894
@reta Can you help to remove the Abdera parts from the CDI systests? It
looks like if it's removed then the tests break completely.
--
This is an automated message from the Apache Git Service.
To respond
coheigea merged pull request #894:
URL: https://github.com/apache/cxf/pull/894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf
coheigea commented on pull request #894:
URL: https://github.com/apache/cxf/pull/894#issuecomment-1018363087
Thanks @reta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
reta merged pull request #893:
URL: https://github.com/apache/cxf/pull/893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #895:
URL: https://github.com/apache/cxf/pull/895
Fixing `jaxrs.ee.rs.container.responsecontext getEntityAnnotationsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
reta commented on a change in pull request #895:
URL: https://github.com/apache/cxf/pull/895#discussion_r791304120
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
##
@@ -156,8 +156,8 @@ private void serializeMessage(Serve
reta commented on a change in pull request #895:
URL: https://github.com/apache/cxf/pull/895#discussion_r791304120
##
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
##
@@ -156,8 +156,8 @@ private void serializeMessage(Serve
olwulff commented on pull request #896:
URL: https://github.com/apache/cxf/pull/896#issuecomment-1023249957
PR created: https://github.com/apache/cxf/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
olwulff removed a comment on pull request #896:
URL: https://github.com/apache/cxf/pull/896#issuecomment-1023249957
PR created: https://github.com/apache/cxf/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
coheigea commented on pull request #896:
URL: https://github.com/apache/cxf/pull/896#issuecomment-1024033107
Just a note to make sure to run all tests before submitting PRs, as the PR
caused a test failure in the STS tests. I'll just fix it locally after merging
the PR.
--
This is an au
coheigea merged pull request #896:
URL: https://github.com/apache/cxf/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf
reta merged pull request #895:
URL: https://github.com/apache/cxf/pull/895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #897:
URL: https://github.com/apache/cxf/pull/897
Fix
org.apache.cxf.systest.jaxrs.JAXRSContinuationsServlet3Test.testSuspendSetTimeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
reta merged pull request #897:
URL: https://github.com/apache/cxf/pull/897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
reta opened a new pull request #898:
URL: https://github.com/apache/cxf/pull/898
As per JSR 370:
```
@ConstrainedTo:
Can be used to restrict the applicability of a provider to just the Client
API or just the Server API. If omitted, a
provider can be used in either conte
olwulff opened a new pull request #899:
URL: https://github.com/apache/cxf/pull/899
…thorizingFilter
I've deprecated the setters on ClaimsAuthorizingFilter which are a wrapper
on the inner bean only. Instead, the inner bean can now be configured on its
own and assigned to the Claims
olwulff commented on pull request #899:
URL: https://github.com/apache/cxf/pull/899#issuecomment-1028721382
@coheigea Not sure why there is a code scanning error. I don't see a
relation to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message
coheigea commented on pull request #899:
URL: https://github.com/apache/cxf/pull/899#issuecomment-1028763239
It's OK @olwulff, we can ignore that error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
olwulff closed pull request #899:
URL: https://github.com/apache/cxf/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.
olwulff commented on pull request #899:
URL: https://github.com/apache/cxf/pull/899#issuecomment-1028863330
Will @coheigea merge this PR?
I'll create a second PR for the 3.5 branch. I assume I can't mark the two
setters as deprecated within a patch version. Right?
--
This is an au
coheigea commented on pull request #899:
URL: https://github.com/apache/cxf/pull/899#issuecomment-1028866696
Don't bother creating a second PR, I'll just cherry-pick it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
coheigea merged pull request #899:
URL: https://github.com/apache/cxf/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf
reta merged pull request #898:
URL: https://github.com/apache/cxf/pull/898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apa
juniiorviani opened a new pull request #900:
URL: https://github.com/apache/cxf/pull/900
Issue ref: https://issues.apache.org/jira/browse/CXF-8651
The JWS is generate with an invalid payload if I try to set a claim like
this:
JwtClaims claims = new JwtClaims();
String c
amarkevich commented on a change in pull request #900:
URL: https://github.com/apache/cxf/pull/900#discussion_r800249280
##
File path:
rt/rs/extensions/json-basic/src/main/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriter.java
##
@@ -22,6 +22,7 @@
import java.io.
amarkevich commented on pull request #900:
URL: https://github.com/apache/cxf/pull/900#issuecomment-1030941008
@juniiorviani could you add a unit test for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
amarkevich commented on a change in pull request #900:
URL: https://github.com/apache/cxf/pull/900#discussion_r800251391
##
File path:
rt/rs/extensions/json-basic/src/main/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriter.java
##
@@ -384,26 +401,38 @@ public Outpu
juniiorviani commented on pull request #900:
URL: https://github.com/apache/cxf/pull/900#issuecomment-1031686104
>
Sure thing, @amarkevich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
1 - 100 of 4588 matches
Mail list logo
