[GitHub] rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl
rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-451563915 Just for tracking purpose: OWB fix is on the snapshot so 2.0.10 will get it and the interceptor stack handling impl will be droppable This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl
rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-451357956 Well there is a ticket for that at cdi level (isnt it stupid technically? ;)). But the fix can be: provide the "internal most nested impl" as a specific bean and inject this "impl bean" to the factory :). You can even do the impl as an interceptor (no more invocation handler at all) for that case with no impl and just use the factory with a bean returning null as base. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl
rmannibucau commented on issue #482: [CXF-7926] Initial MP Rest Client 1.2 impl URL: https://github.com/apache/cxf/pull/482#issuecomment-451074661 Hi @andymc12 , happy new year :) about 1 maybe check out https://github.com/apache/geronimo-metrics/blob/master/geronimo-metrics/src/main/java/org/apache/geronimo/microprofile/metrics/cdi/CountedInterceptor.java#L91, it is not the best impl - which would use an extension to capture it and inject it in a specific interceptor - but a good compromise regarding the complexity. Then you have the annotated model from cdi which replaces all java reflect usages. About 2: [1] is the one, it enables to manage the interceptors (configured) for you Let me know - or ping me on slack/irc/gmail - if you need more pointers/help. [1] https://docs.jboss.org/cdi/api/2.0/javax/enterprise/inject/spi/InterceptionFactory.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services