Re: Review Request 65767: DATAFU-137 KEYS sigs and hashes must be linked from the download page
> On Feb. 27, 2018, 9:12 a.m., Eyal Allweil wrote: > > I looked at the code with a friend who knows Ruby. In general, it looks > > good. The only comment we had is that the "archived_source_release_link" > > method isn't being used. Based on the comment, we understood that the > > intention is to use it in the future, when 1.3.3 becomes a "past" release, > > since 1.3.0-1.3.2 had URLs inconsistent with 1.3.3 (and future releases), > > and therefore the method doesn't apply. Is that right? Yep that's right - Matthew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65767/#review198321 --- On Feb. 23, 2018, 5:13 a.m., Matthew Hayes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65767/ > --- > > (Updated Feb. 23, 2018, 5:13 a.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > --- > > Updated according to https://issues.apache.org/jira/browse/DATAFU-137 > > I wrote helper methods to format the links for the releases. Because older > releases used different and inconsistent extensions I didn't write a method > for these. > > > Diffs > - > > site/config.rb 745a3f8 > site/source/docs/download.html.markdown.erb 0a400f5 > > > Diff: https://reviews.apache.org/r/65767/diff/1/ > > > Testing > --- > > > Thanks, > > Matthew Hayes > >
Re: Review Request 65767: DATAFU-137 KEYS sigs and hashes must be linked from the download page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65767/#review198321 --- Ship it! I looked at the code with a friend who knows Ruby. In general, it looks good. The only comment we had is that the "archived_source_release_link" method isn't being used. Based on the comment, we understood that the intention is to use it in the future, when 1.3.3 becomes a "past" release, since 1.3.0-1.3.2 had URLs inconsistent with 1.3.3 (and future releases), and therefore the method doesn't apply. Is that right? - Eyal Allweil On Feb. 23, 2018, 7:13 a.m., Matthew Hayes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65767/ > --- > > (Updated Feb. 23, 2018, 7:13 a.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > --- > > Updated according to https://issues.apache.org/jira/browse/DATAFU-137 > > I wrote helper methods to format the links for the releases. Because older > releases used different and inconsistent extensions I didn't write a method > for these. > > > Diffs > - > > site/config.rb 745a3f8 > site/source/docs/download.html.markdown.erb 0a400f5 > > > Diff: https://reviews.apache.org/r/65767/diff/1/ > > > Testing > --- > > > Thanks, > > Matthew Hayes > >
Review Request 65767: DATAFU-137 KEYS sigs and hashes must be linked from the download page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65767/ --- Review request for DataFu. Repository: datafu Description --- Updated according to https://issues.apache.org/jira/browse/DATAFU-137 I wrote helper methods to format the links for the releases. Because older releases used different and inconsistent extensions I didn't write a method for these. Diffs - site/config.rb 745a3f8 site/source/docs/download.html.markdown.erb 0a400f5 Diff: https://reviews.apache.org/r/65767/diff/1/ Testing --- Thanks, Matthew Hayes
