Re: Merge PRs

2018-11-26 Thread Daniel Dias Dos Santos
Hi, Fantastic. Many thanks, Daniel. -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 26 de nov de 2018 às 14:32, Daniel Cunha escreveu: > Hi

Re: Merge PRs

2018-11-26 Thread Daniel Cunha
Hi Daniel, Is that your PR: https://github.com/apache/deltaspike/pull/77 ? Easily you can create a patch. Just add .patch in the end of the URL. https://github.com/apache/deltaspike/pull/77.patch Hope that helps. :) Em seg, 26 de nov de 2018 às 13:25, Daniel Dias Dos Santos <

Re: Merge PRs

2018-11-26 Thread Daniel Dias Dos Santos
hi cool, I try to do this with the PR I sent . thanks . -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em seg, 26 de nov de 2018 às 14:20, Thomas

Re: Merge PRs

2018-11-26 Thread Thomas Andraschko
Hi, as long as we don't use gitbox, it's really awkward to apply them. I would prefer a issue + attaching a patch. Am Mo., 26. Nov. 2018 um 16:37 Uhr schrieb Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com>: > HI , > > the best way is to send via github the PR? > > because I was

Re: Merge PRs

2018-11-26 Thread Daniel Dias Dos Santos
HI , the best way is to send via github the PR? because I was following the instructions here : https://deltaspike.apache.org/suggested-git-workflows.html thanks, -- *Daniel Dias dos Santos* Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin:

Re: Merge PRs

2018-11-12 Thread Romain Manni-Bucau
You pull them locally, merge and then push on asf, once "ok" you can ask the author to close it on github Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: Merge PRs

2018-11-12 Thread Thomas Andraschko
hmmm, how should we handle those pull requests then? Am Mo., 12. Nov. 2018 um 10:40 Uhr schrieb Mark Struberg : > Hi Thomas! > > DeltaSpike is not managed via gitbox but as a classic GIT repo. > Thus merging via github simply does not work. > > LieGrue, > strub > > > > Am 12.11.2018 um 09:37

Re: Merge PRs

2018-11-12 Thread Mark Struberg
Hi Thomas! DeltaSpike is not managed via gitbox but as a classic GIT repo. Thus merging via github simply does not work. LieGrue, strub > Am 12.11.2018 um 09:37 schrieb Thomas Andraschko > : > > Hi, > > i would like to merge 2 PRs and close 1 PRs but it seems that i don't have > write