Re: [data] dto and isNew

2014-06-16 Thread Thomas Hug
Thanks Karl for the clarification! If you assign a new group, I'd first make sure you have this one persisted as well (or we do too much in the mapper IMO). Then save the userDto with something like User toEntity(User user, UserDto dto) { ...

Re: [VOTE] logo-color

2014-06-16 Thread Pete Muir
+1 for blue. On 14 Jun 2014, at 19:55, Gerhard Petracek gerhard.petra...@gmail.com wrote: hi @ all, this second vote is about the color and therefore the final logo. i've uploaded the candidates provided by jim at [1]-[4]. please send a +1 for one of them. regards, gerhard [1]

Re: [data] dto and isNew

2014-06-16 Thread Karl Kildén
Hi, On could argue that the real problem is that the algorithm that decides if it should be a save or persist. It uses some portable way of deciding this that requires the entity to be managed. That algorithm could be improved in each project. @Override @RequiresTransaction public E

Re: [data] dto and isNew

2014-06-16 Thread Thomas Andraschko
Why don't we use entityManager#contains instead of checking the ID? 2014-06-16 10:22 GMT+02:00 Karl Kildén karl.kil...@gmail.com: Hi, On could argue that the real problem is that the algorithm that decides if it should be a save or persist. It uses some portable way of deciding this that

Re: [data] dto and isNew

2014-06-16 Thread Romain Manni-Bucau
Actually you want to override isNew and not save I think. This should be doable (@Alternative maybe) but the mapper should be responsible of ensuring collections are well mapped (find if needed) mainly because you dont always map 1-1 (otherwise it is almost useless). Le 16 juin 2014 09:22, Karl

Re: [data] dto and isNew

2014-06-16 Thread Romain Manni-Bucau
Cause mapping can be done through several transactions (think jaxrs) so it would be wrong. PersistenceUtil has some good things to gey id or null if new but IIRC some impl are broken. Le 16 juin 2014 09:31, Thomas Andraschko andraschko.tho...@gmail.com a écrit : Why don't we use

Re: [data] dto and isNew

2014-06-16 Thread Karl Kildén
Hrmm maybe I mixed things up now. If you have a relationship to another pre existing entity can it be detached when you save? All I am really looking for is the groupId to be updated but maybe JPA can't determine this in a good way. And updating the entity itself is solved by including it as an

Re: [data] dto and isNew

2014-06-16 Thread Romain Manni-Bucau
Yes you need to merge it but the responsability is yours (user) IMO. Le 16 juin 2014 09:56, Karl Kildén karl.kil...@gmail.com a écrit : Hrmm maybe I mixed things up now. If you have a relationship to another pre existing entity can it be detached when you save? All I am really looking for is

Re: [data] dto and isNew

2014-06-16 Thread Karl Kildén
But then I need to use the entityManager in the mapper or am I missing something? On 16 June 2014 11:17, Romain Manni-Bucau rmannibu...@gmail.com wrote: Yes you need to merge it but the responsability is yours (user) IMO. Le 16 juin 2014 09:56, Karl Kildén karl.kil...@gmail.com a écrit :

Re: [VOTE] Release of Apache DeltaSpike 1.0.0

2014-06-16 Thread Rafael Benevides
+1 Em 14/06/14 12:00, Gerhard Petracek escreveu: Hi, I was running the needed tasks to get the 8th release of Apache DeltaSpike out. The artifacts are deployed to Nexus [1] (and [2]). The tag is available at [3] and will get pushed to the ASF repository once the vote passed. Please take a

Re: [VOTE] logo-color

2014-06-16 Thread Rafael Benevides
+1 for red Em 14/06/14 14:55, Gerhard Petracek escreveu: hi @ all, this second vote is about the color and therefore the final logo. i've uploaded the candidates provided by jim at [1]-[4]. please send a +1 for one of them. regards, gerhard [1] http://s.apache.org/DS_LOGO_BLUE_VOTE2 [2]

Re: [VOTE] logo-color

2014-06-16 Thread Christian Kaltepoth
+1 for red 2014-06-16 13:41 GMT+02:00 Rafael Benevides benevi...@redhat.com: +1 for red Em 14/06/14 14:55, Gerhard Petracek escreveu: hi @ all, this second vote is about the color and therefore the final logo. i've uploaded the candidates provided by jim at [1]-[4]. please send a +1

Re: [VOTE] Release of Apache DeltaSpike 1.0.0

2014-06-16 Thread Thomas Andraschko
+1 2014-06-16 13:40 GMT+02:00 Rafael Benevides benevi...@redhat.com: +1 Em 14/06/14 12:00, Gerhard Petracek escreveu: Hi, I was running the needed tasks to get the 8th release of Apache DeltaSpike out. The artifacts are deployed to Nexus [1] (and [2]). The tag is available at [3]