Re: [DISCUSS] GitHub PR Builder

Yes, sorry, I wasn't clear. If you rebase their commit then it has a tendency to not close the PR which is when you need "This closes #123" John On Wed, Jul 6, 2016 at 6:21 AM Daniel Cunha wrote: > Hi John, > > When we're following the steps presented by asg-git, the PR

Re: [DISCUSS] Tests for Payara?

back then it worked with v4.1, however, v4.1.1 failed. regards, gerhard 2016-07-06 11:58 GMT+02:00 John D. Ament : > The glassfish one doesn't work on Payara? > > John > > On Wed, Jul 6, 2016 at 5:56 AM Gerhard Petracek > wrote: > > > i asked them

[jira] [Created] (DELTASPIKE-1181) Implement tests for Payara

John D. Ament created DELTASPIKE-1181: - Summary: Implement tests for Payara Key: DELTASPIKE-1181 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1181 Project: DeltaSpike Issue

Re: [DISCUSS] GitHub PR Builder

Hi John, When we're following the steps presented by asg-git, the PR is marked like merged. For example: https://github.com/apache/deltaspike/pull/57 The steps:

Re: [DISCUSS] Tests for Payara?

+1 On Wed, Jul 6, 2016 at 7:13 AM, Gerhard Petracek wrote: > back then it worked with v4.1, however, v4.1.1 failed. > > regards, > gerhard > > > > 2016-07-06 11:58 GMT+02:00 John D. Ament : > > > The glassfish one doesn't work on Payara? > > >

[GitHub] deltaspike pull request #:

Github user johnament commented on the pull request: https://github.com/apache/deltaspike/commit/b9bc748e79d60fa1de5b2556c53aee24519cf596#commitcomment-18146939 In deltaspike/parent/code/pom.xml: In deltaspike/parent/code/pom.xml on line 1808: A --- If your project is

[GitHub] deltaspike pull request #:

Github user bartoszmajsak commented on the pull request: https://github.com/apache/deltaspike/commit/b9bc748e79d60fa1de5b2556c53aee24519cf596#commitcomment-18146741 In deltaspike/parent/code/pom.xml: In deltaspike/parent/code/pom.xml on line 1808: Are you testing against IBM

Re: [DISCUSS] GitHub PR Builder

I think such build jobs are very valuable. So +1 for them. 2016-07-06 4:06 GMT+02:00 John D. Ament : > Hey guys > > We've been getting a few more PRs over github. Its IMHO easier to merge > those instead of patches in JIRA tickets. > > I went ahead and created a PR

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

Hi John, thanks for fixing it. The current solution will be very slow and we should make DelegateManualInvocationHandler and InterceptManualInvocationHandler ApplicationScoped. It would be still great if you could compare the performance e.g. for 10.000 calls with our old code (with static) vs

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

Oh sorry, you already made it ApplicationScoped with your second commit :) 2016-07-06 10:40 GMT+02:00 Thomas Andraschko : > Hi John, > > thanks for fixing it. > The current solution will be very slow and we should make > DelegateManualInvocationHandler and

Re: [DISCUSS] GitHub PR Builder

+1 Stupid question but how can i merge PRs from github? The last PRs from georgekankava are looking good. 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth : > I think such build jobs

[DISCUSS] Tests for Payara?

Hey guys Should we setup jenkins jobs/build profiles to test against Payara? Seems like it may be useful. John

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

Yeah, tests weren't working :-) But good news, the Weld2 profile is working now. I suppose that this issue was weld specific. John On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > Oh sorry, you already made it ApplicationScoped with your second commit

Re: [DISCUSS] Tests for Payara?

+1 Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog | Github | LinkedIn | Tomitriber

Re: [DISCUSS] GitHub PR Builder

Short answer is you can't. You need to pull the branch and push to our master. You need to make the commit message include the "This closes #123" line to make github know to close it. Or ask the requestor to close it. There is an open git-dual POC from infra. Last I looked, it wasn't doing

Re: [DISCUSS] Tests for Payara?

i asked them already (last year), however, they have(/had) an issue with their arquillian-adapter. regards, gerhard 2016-07-06 11:42 GMT+02:00 John D. Ament : > Hey guys > > Should we setup jenkins jobs/build profiles to test against Payara? Seems > like it may be

Re: [DISCUSS] Tests for Payara?

+1 :) 2016-07-06 11:55 GMT+02:00 Gerhard Petracek : > i asked them already (last year), however, they have(/had) an issue with > their arquillian-adapter. > > regards, > gerhard > > > > 2016-07-06 11:42 GMT+02:00 John D. Ament : > > > Hey guys > > > >

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

Great! :) 2016-07-06 11:48 GMT+02:00 John D. Ament : > Yeah, tests weren't working :-) > > But good news, the Weld2 profile is working now. I suppose that this issue > was weld specific. > > John > > On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko < >