j-be opened a new pull request #84: Scheduler control
URL: https://github.com/apache/deltaspike/pull/84
 
 
   **Disclaimer:** I wanted to test GitHub's new "Draft Pull Request" feature, 
which is why this exists.
   
   ### What it does
   Introduce a new SPI to DeltaSpike's scheduler module to control if the 
scheduler as a whole and individual job executions should start.
   
   Discussion on this is still ongoing in the bug tracker 
(https://issues.apache.org/jira/projects/DELTASPIKE/issues/DELTASPIKE-1369) and 
on the mailing list (Topic: [Scheduler] Enable/Disable based on custom 
condition). **Please join the discussion there, not here**.
   
   ### Open discussion points
   * [ ] Better name for `SchedulerControl.shouldJobBeStarted`?
     * `bool vetoJobExecution(Class<?> jobClass)` approach similar to [Quartz' 
ITriggerListener](https://www.quartz-scheduler.net/documentation/quartz-2.x/tutorial/trigger-and-job-listeners.html)?
   * [ ] Use `String jobName` instead of `Class<?> jobClass` in 
`SchedulerControl.shouldJobBeStarted`?
     * Use Quartz' `JobExecutionContext` -> introduces a mandatory dependency 
to Quartz
   * [ ] Remove default implementation `DefaultSchedulerControl` and replace by 
one of
     * Optional lookup via `BeanManager`
     * Make `SchedulerControl` the default implementation
     * Something else?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to