Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-06 Thread Thomas Andraschko
Great! :) 2016-07-06 11:48 GMT+02:00 John D. Ament : > Yeah, tests weren't working :-) > > But good news, the Weld2 profile is working now. I suppose that this issue > was weld specific. > > John > > On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko < >

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-06 Thread John D. Ament
Yeah, tests weren't working :-) But good news, the Weld2 profile is working now. I suppose that this issue was weld specific. John On Wed, Jul 6, 2016 at 4:40 AM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > Oh sorry, you already made it ApplicationScoped with your second commit

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-06 Thread Thomas Andraschko
Oh sorry, you already made it ApplicationScoped with your second commit :) 2016-07-06 10:40 GMT+02:00 Thomas Andraschko : > Hi John, > > thanks for fixing it. > The current solution will be very slow and we should make > DelegateManualInvocationHandler and

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-06 Thread Thomas Andraschko
Hi John, thanks for fixing it. The current solution will be very slow and we should make DelegateManualInvocationHandler and InterceptManualInvocationHandler ApplicationScoped. It would be still great if you could compare the performance e.g. for 10.000 calls with our old code (with static) vs

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-05 Thread John D. Ament
I ended up pushing a second commit which I think will make things better. But still not 100% sure. The problem is that the static invocation handler was holding a reference to InterceptorLookup, which gets lost between container boots (or even, if there are multiple bean managers around for some

Re: deltaspike git commit: DELTASPIKE-1179 Don't use a static reference to a contextual bean, in the case of beans being reloaded by multiple deployments.

2016-07-05 Thread John D. Ament
Hi @Thomas and others This was a tricky one but I think I got it. Don't have a good test for it yet. Basically, in the case of web profile tests, we didn't see this as an issue as the classloader gets cleared, so its not a problem. However, if you test proxy based classes in an SE environment,