Re: [I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-11-12 Thread via GitHub


github-actions[bot] commented on issue #7971:
URL: 
https://github.com/apache/incubator-devlake/issues/7971#issuecomment-2472003137

   This issue has been closed because it has been inactive for a long time. You 
can reopen it if you encounter the similar problem in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-11-12 Thread via GitHub


github-actions[bot] closed issue #7971: [Bug][Dashboard] Change Failure Rate 
Metric Different between Dashboards
URL: https://github.com/apache/incubator-devlake/issues/7971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-11-05 Thread via GitHub


github-actions[bot] commented on issue #7971:
URL: 
https://github.com/apache/incubator-devlake/issues/7971#issuecomment-2458458438

   This issue has been automatically marked as stale because it has been 
inactive for 60 days. It will be closed in next 7 days if no further activity 
occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-09-06 Thread via GitHub


klesh commented on issue #7971:
URL: 
https://github.com/apache/incubator-devlake/issues/7971#issuecomment-2333542266

   @Startrekzky Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-08-27 Thread via GitHub


dosubot[bot] commented on issue #7971:
URL: 
https://github.com/apache/incubator-devlake/issues/7971#issuecomment-2313125083

   
   The discrepancy in the Change Failure Rate metric between the DORA home 
dashboard and the "DORA Details - Change Failure Rate" page is likely due to 
differences in how deployments and incidents are aggregated and counted. 
Specifically, DevLake considers multiple deployments triggered by one pipeline 
as a single deployment and uses the last deployment's finished date as the 
deployment finished date. This aggregation can lead to discrepancies if the two 
dashboards are not using the same aggregation logic or if there are differences 
in the time filters applied 
[[1]](https://github.com/apache/incubator-devlake-website/blob/main/docs/Metrics/CFR.md).
   
   Additionally, the SQL queries used for calculating the Change Failure Rate 
differ in their logic for counting incidents:
   
   1. The first query counts incidents using this logic:
  ```sql
  count(
distinct case
  when i.id is not null then d.deployment_id
  else null
end
  ) as has_incident
  ```
  This effectively counts the deployment if it is linked to any incident.
   
   2. The second query simplifies it to:
  ```sql
  count(distinct i.id) as has_incident
  ```
  This directly counts the distinct incident IDs, which might yield 
different results depending on how deployments are linked to incidents 
[[2]](https://github.com/apache/incubator-devlake/blob/main/grafana/dashboards/DORADetails-ChangeFailureRate.json)[[3]](https://github.com/apache/incubator-devlake/blob/main/grafana/dashboards/DORA.json).
   
   These differences in incident counting logic can result in different Change 
Failure Rate values being displayed on the two dashboards.
   
   
   
   *To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[I] [Bug][Dashboard] Change Failure Rate Metric Different between Dashboards [incubator-devlake]

2024-08-27 Thread via GitHub


tc-jason-gregory opened a new issue, #7971:
URL: https://github.com/apache/incubator-devlake/issues/7971

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   On the DORA home dashboard, the Change Failure Rate shows one value. When 
you drill into the data and go to the "DORA Details - Change Failure Rate" 
page, the value is different.
   
![home-CFR](https://github.com/user-attachments/assets/3356ece2-18ba-4324-a0d8-e1fd755c328b)
   
![detail-CFR](https://github.com/user-attachments/assets/804b12d3-d0c3-4ec4-9270-8b2b8005e314)
   
   
   ### What do you expect to happen
   
   I expected the values to be the same.
   
   ### How to reproduce
   
   On the DORA home dashboard, the Change Failure Rate shows one value. When 
you drill into the data and go to the "DORA Details - Change Failure Rate" 
page, the value is different.
   
   ### Anything else
   
   I noted the queries are different for incident counting l as follows...
   
   1. The first query counts incidents using this logic:
   
   `count(
 distinct case
   when i.id is not null then d.deployment_id
   else null
 end
   ) as has_incident`
   
   This effectively counts the deployment if it is linked to any incident.
   
   2. The second query simplifies it to:
   
   `count(distinct i.id) as has_incident`
   
   This directly counts the distinct incident IDs, which might yield different 
results depending on how deployments are linked to incidents.
   
   ### Version
   
   v1.0.1-beta7@3f84bae
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]